Re: [PATCH v2] net/null: Add fast mbuf release TX offload

2025-07-25 Thread Ivan Malov
Hi Morten, Good patch. Please see below. On Sat, 26 Jul 2025, Morten Brørup wrote: Added fast mbuf release, re-using the existing mbuf pool pointer in the queue structure. Signed-off-by: Morten Brørup --- v2: * Also announce the offload as a per-queue capability. * Added missing test of per-

[PATCH v2] net/null: Add fast mbuf release TX offload

2025-07-25 Thread Morten Brørup
Added fast mbuf release, re-using the existing mbuf pool pointer in the queue structure. Signed-off-by: Morten Brørup --- v2: * Also announce the offload as a per-queue capability. * Added missing test of per-device offload configuration when configuring the queue. --- drivers/net/null/rte_eth

RE: [PATCH] net/null: Add fast mbuf release TX offload

2025-07-25 Thread Morten Brørup
> From: Varghese, Vipin [mailto:vipin.vargh...@amd.com] > Sent: Friday, 27 June 2025 14.07 > > [Public] > > Hi Morten, > > We have tested the effect of the patch using func-latency and PPs via > testpmd. > Please find our observations below > > - DPDK tag: 25.07-rc1 > - compiler: gcc 14.2 >

Re: [EXTERNAL] [PATCH] doc: announce DMA configuration structure changes

2025-07-25 Thread fengchengwen
Acked-by: Chengwen Feng On 2025/7/25 14:04, Pavan Nikhilesh Bhagavatula wrote: >>> Deprecate rte_dma_conf structure to allow for a more flexible >>> configuration of DMA devices. >>> The new structure will have a flags field instead of multiple >>> boolean fields for each feature. >>> >>> Signed-

[PATCH] dts: call hugepages configure at testrun setup

2025-07-25 Thread Patrick Robb
The node class contains a _configure_hugepages method to be called on the sut node if the user has specified a hugepages config value in their nodes configuration. However, the commit referenced below removed the code path to this function, making it unreachable. If the user has configured hugepage

Scheduled DPDK Community Lab downtime this weekend

2025-07-25 Thread Patrick Robb
Hello, I will be taking the DPDK Community Lab offline at 5pm EST today for system updates and backups on the Community Lab's Jenkins server. I expect to be able to bring the Community Lab back online at midday Saturday. If that schedule changes, I will provide updates on the Slack infra-issues ch

[PATCH v2] build: remove obsolete compiler checks

2025-07-25 Thread Bruce Richardson
DPDK now recommends compiler versions GCC 8+, and Clang 7+, so remove checks and workarounds for versions old than these. Signed-off-by: Bruce Richardson --- V2: Fix feedback from V1. * remove obsolete comment from arm/meson.build * sort octeontx alphabetically in driver list --- config/arm/meso

Re: [PATCH v11 07/13] net/sxe: support rss offload

2025-07-25 Thread Ivan Malov
Hi, (please see below) On Fri, 25 Jul 2025, Jie Liu wrote: Support rss offload. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 11 +- drivers/net/sxe/pf/sxe_offload.c | 299 ++ drivers/net/sxe/pf/sxe_offload.h | 33 +++ 3 files cha

Re: [RFC PATCH 11/14] net/ice: remove unsupported Rx offload

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:16PM +, Ciara Loftus wrote: > The offload RTE_ETH_RX_OFFLOAD_SCTP_CKSUM is not supported in the ice > driver so remove the one erronous use of it. > > Signed-off-by: Ciara Loftus > --- Acked-by: Bruce Richardson

Re: [RFC PATCH 10/14] net/intel: introduce infrastructure for Rx path selection

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:15PM +, Ciara Loftus wrote: > The code for determining which Rx path to select during initialisation > has become complicated in many intel drivers due to the amount of > different paths and features available within each path. This commit > aims to simplify and ge

[PATCH 6/6] dts: use artifacts in packet capture and softnic

2025-07-25 Thread Luca Vizzarro
Use the newly added artifact/file manager in the packet capture and softnic test suites. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/tests/TestSuite_packet_capture.py | 73 ++-- dts/tests/TestSuite_softnic.py| 95 +++ 2 files

[PATCH 5/6] dts: make log files into artifacts

2025-07-25 Thread Luca Vizzarro
Make log files behave like artifacts as dictated by the Artifact class. Implicitly, this will automatically place all the logs in a structured manner. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/logger.py | 113 +- dts/framew

[PATCH 4/6] dts: add artifact module

2025-07-25 Thread Luca Vizzarro
Add a new artifact module which provides DTS with remote and local file management capabilities. A new Artifact class is provided which acts as an abstract representation of a file that is present in any node in the testbed model. The same provides several helper file management functions, includin

[PATCH 3/6] dts: add current test suite and cases to context

2025-07-25 Thread Luca Vizzarro
Add the current test suite and case to the context, so that they can be accessed by helper functions, etc. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/context.py | 7 ++- dts/framework/test_run.py | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff

[PATCH 2/6] dts: add node retriever by identifier

2025-07-25 Thread Luca Vizzarro
Refactor the logic to identify nodes. Add facility to retrieve current nodes from context. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- dts/framework/testbed_model/node.py | 38 + dts/framework/testbed_model/topology.py | 8 ++ 2 files changed,

[PATCH 1/6] dts: merge RemoteSession class

2025-07-25 Thread Luca Vizzarro
Merge the RemoteSession class with SSHSession as there is no current use of a separate channel other than SSH. Signed-off-by: Luca Vizzarro Reviewed-by: Paul Szczepanek --- doc/api/dts/framework.remote_session.rst | 1 - .../framework.remote_session.ssh_session.rst | 8 -- dts/framewo

[PATCH 0/6] dts: add file management

2025-07-25 Thread Luca Vizzarro
Hello everyone, I am sending in a new major feature for DTS. This would introduce a unified and abstracted way to handle files in DTS. Everything is handled directly through the Artifact class, which provides several file-related methods, including a standard file object interface for file RW oper

Re: [RFC PATCH 09/14] net/iavf: remove redundant field from iavf adapter struct

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:14PM +, Ciara Loftus wrote: > The variable rx_vec_allowed was only used in one function, so > it's not necessary to have it part of the iavf_adapater structure. > > Signed-off-by: Ciara Loftus > --- Acked-by: Bruce Richardson

Re: [RFC PATCH 06/14] net/ice: use the new common vector capability function

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:11PM +, Ciara Loftus wrote: > Use the new function for determining the maximum simd bitwidth in > the ice driver. > > Signed-off-by: Ciara Loftus Few comments inline below. > --- > drivers/net/intel/ice/ice_ethdev.h | 5 +-- > drivers/net/intel/ice/ice_r

Re: [PATCH] maintainers: update for DTS

2025-07-25 Thread Thomas Monjalon
22/07/2025 18:05, Luca Vizzarro: > Paul is giving up his role of co-maintainer of DTS, electing Luca > Vizzarro in his place. > > Signed-off-by: Luca Vizzarro Acked-by: Paul Szczepanek Acked-by: Patrick Robb Applied, thank you for volunteering.

Re: [RFC PATCH 05/14] net/intel: introduce common vector capability function

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:10PM +, Ciara Loftus wrote: > From: Bruce Richardson > > A common need within the drivers is to select between SSE, AVX2 and > AVX-512 code paths. Provide a common function which helps with this > decision making, that returns the max simd bandwidth based on any

Re: [RFC PATCH 04/14] net/i40e: use the same Rx path across process types

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:09PM +, Ciara Loftus wrote: > In the interest of simplicity, let the primary process select the Rx > path to be used by all processes using the given device. > > The many logs which report individual Rx path selections have been > consolidated into one single log

Re: [PATCH 01/13] net/sxe: add base driver directory and doc

2025-07-25 Thread Ivan Malov
On Fri, 25 Jul 2025, Ivan Malov wrote: Hi, (please see below) On Thu, 24 Apr 2025, Jie Liu wrote: From: JieLiu Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver. Signed-off-by: Jie Liu --- MAINTAINERS

Re: [RFC PATCH 03/14] net/iavf: use the same Rx path across process types

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:08PM +, Ciara Loftus wrote: > In the interest of simplicity, let the primary process select the Rx > path to be used by all processes using the given device. > > The many logs which report individual Rx path selections have been > consolidated into one single log

Re: [RFC PATCH 02/14] net/iavf: rename Rx/Tx function type variables

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:07PM +, Ciara Loftus wrote: > Rename variables from burst_type to func_type to better reflect > the information the variables are storing. > > Signed-off-by: Ciara Loftus > --- Acked-by: Bruce Richardson

Re: [RFC PATCH 01/14] net/ice: use the same Rx path across process types

2025-07-25 Thread Bruce Richardson
On Fri, Jul 25, 2025 at 12:49:06PM +, Ciara Loftus wrote: > In the interest of simplicity, let the primary process select the Rx > path to be used by all processes using the given device. > > The many logs which report individual Rx path selections have been > consolidated into one single log.

Re: [PATCH 01/13] net/sxe: add base driver directory and doc

2025-07-25 Thread Ivan Malov
Hi, (please see below) On Thu, 24 Apr 2025, Jie Liu wrote: From: JieLiu Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver. Signed-off-by: Jie Liu --- MAINTAINERS | 6 +++ doc/guides/nics/features/sxe.i

Re: [PATCH] [PATCH v3] lib/ethdev: fix segfault in secondary process by validating dev_private pointer

2025-07-25 Thread Khadem Ullah
Hi Stephen, Thanks for the feedback. I???ve submitted v4 of this patch, which includes a mechanism to monitor the primary testpmd process from the secondary testpmd. This helps prevent crashes when the primary testpmd exits. Best regards, Khadem

[PATCH] [PATCH v4] lib/ethdev: fix segfault in secondary process by validating dev_private pointer

2025-07-25 Thread Khadem Ullah
In secondary processes, directly accessing 'dev->data->dev_private' can cause a segmentation fault if the primary process has exited or if the shared memory is no longer accessible. The secondary process not only crashes on device close but also segfaults when executing commands like "show device

[RFC PATCH 14/14] net/i40e: use the common Rx path selection infrastructure

2025-07-25 Thread Ciara Loftus
Replace the existing complicated logic with the use of the common function. Signed-off-by: Ciara Loftus --- drivers/net/intel/i40e/i40e_rxtx.c| 145 +- drivers/net/intel/i40e/i40e_rxtx.h| 15 ++ .../net/intel/i40e/i40e_rxtx_vec_altivec.c| 6 + drive

[RFC PATCH 13/14] net/iavf: use the common Rx path selection infrastructure

2025-07-25 Thread Ciara Loftus
Replace the existing complicated logic with the use of the common function. Signed-off-by: Ciara Loftus --- drivers/net/intel/iavf/iavf_rxtx.c| 292 +++--- drivers/net/intel/iavf/iavf_rxtx.h| 50 ++- drivers/net/intel/iavf/iavf_rxtx_vec_common.h | 14 +- dri

[RFC PATCH 12/14] net/ice: use the common Rx path selection infrastructure

2025-07-25 Thread Ciara Loftus
Replace the existing complicated logic with the use of the common function. Signed-off-by: Ciara Loftus --- drivers/net/intel/ice/ice_ethdev.h | 1 - drivers/net/intel/ice/ice_rxtx.c| 157 +--- drivers/net/intel/ice/ice_rxtx.h| 28 drivers

[RFC PATCH 11/14] net/ice: remove unsupported Rx offload

2025-07-25 Thread Ciara Loftus
The offload RTE_ETH_RX_OFFLOAD_SCTP_CKSUM is not supported in the ice driver so remove the one erronous use of it. Signed-off-by: Ciara Loftus --- drivers/net/intel/ice/ice_rxtx_vec_common.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/intel/ice/ice_rxtx_vec_common.h b/drivers

[RFC PATCH 10/14] net/intel: introduce infrastructure for Rx path selection

2025-07-25 Thread Ciara Loftus
The code for determining which Rx path to select during initialisation has become complicated in many intel drivers due to the amount of different paths and features available within each path. This commit aims to simplify and genericize the path selection logic. The following information about ea

[RFC PATCH 09/14] net/iavf: remove redundant field from iavf adapter struct

2025-07-25 Thread Ciara Loftus
The variable rx_vec_allowed was only used in one function, so it's not necessary to have it part of the iavf_adapater structure. Signed-off-by: Ciara Loftus --- drivers/net/intel/iavf/iavf.h| 1 - drivers/net/intel/iavf/iavf_ethdev.c | 1 - drivers/net/intel/iavf/iavf_rxtx.c | 6 ++

[RFC PATCH 08/14] net/i40e: use the new common vector capability function

2025-07-25 Thread Ciara Loftus
Use the new function for determining the maximum simd bitwidth in the i40e driver. Signed-off-by: Ciara Loftus --- drivers/net/intel/i40e/i40e_ethdev.h | 5 +- drivers/net/intel/i40e/i40e_rxtx.c | 57 -- drivers/net/intel/i40e/i40e_rxtx.h | 1 + driver

[RFC PATCH 06/14] net/ice: use the new common vector capability function

2025-07-25 Thread Ciara Loftus
Use the new function for determining the maximum simd bitwidth in the ice driver. Signed-off-by: Ciara Loftus --- drivers/net/intel/ice/ice_ethdev.h | 5 +-- drivers/net/intel/ice/ice_rxtx.c | 52 ++-- drivers/net/intel/ice/ice_rxtx.h | 1 + drivers/ne

[RFC PATCH 07/14] net/iavf: use the new common vector capability function

2025-07-25 Thread Ciara Loftus
Use the new function for determining the maximum simd bitwidth in the iavf driver. Signed-off-by: Ciara Loftus --- drivers/net/intel/iavf/iavf_rxtx.c | 27 +- drivers/net/intel/iavf/iavf_rxtx.h | 1 + drivers/net/intel/iavf/iavf_rxtx_vec_sse.c | 6 + 3 f

[RFC PATCH 05/14] net/intel: introduce common vector capability function

2025-07-25 Thread Ciara Loftus
From: Bruce Richardson A common need within the drivers is to select between SSE, AVX2 and AVX-512 code paths. Provide a common function which helps with this decision making, that returns the max simd bandwidth based on any user configured maximums and available CPU flags. Signed-off-by: Bruce

[RFC PATCH 04/14] net/i40e: use the same Rx path across process types

2025-07-25 Thread Ciara Loftus
In the interest of simplicity, let the primary process select the Rx path to be used by all processes using the given device. The many logs which report individual Rx path selections have been consolidated into one single log Signed-off-by: Ciara Loftus --- drivers/net/intel/i40e/i40e_ethdev.h

[RFC PATCH 03/14] net/iavf: use the same Rx path across process types

2025-07-25 Thread Ciara Loftus
In the interest of simplicity, let the primary process select the Rx path to be used by all processes using the given device. The many logs which report individual Rx path selections have been consolidated into one single log Signed-off-by: Ciara Loftus --- drivers/net/intel/iavf/iavf_rxtx.c |

[RFC PATCH 02/14] net/iavf: rename Rx/Tx function type variables

2025-07-25 Thread Ciara Loftus
Rename variables from burst_type to func_type to better reflect the information the variables are storing. Signed-off-by: Ciara Loftus --- drivers/net/intel/iavf/iavf.h | 8 +- drivers/net/intel/iavf/iavf_rxtx.c | 114 ++--- 2 files changed, 61 insertions(+), 61 de

[RFC PATCH 01/14] net/ice: use the same Rx path across process types

2025-07-25 Thread Ciara Loftus
In the interest of simplicity, let the primary process select the Rx path to be used by all processes using the given device. The many logs which report individual Rx path selections have been consolidated into one single log. Signed-off-by: Ciara Loftus --- drivers/net/intel/ice/ice_ethdev.c |

[RFC PATCH 00/14] net/intel: rx path selection simplification

2025-07-25 Thread Ciara Loftus
This series aims to simplify the process of selecting an Rx burst function for the i40e, iavf and ice drivers. Three main simplifications are made: 1. enforcing the same rx burst function for both primary and secondary processes. 2. using a common function for determining the maximum SIMD width bas

RE: [PATCH] acl: fix the value of the trans table

2025-07-25 Thread Konstantin Ananyev
Hi > The node_array[RTE_ACL_DFA_SIZE] is assigned to > RTE_ACL_IDLE_NODE and is used as a node of > RTE_ACL_NODE_SINGLE type, but it is currently based > on the implementation of idle arrays with a value of all > 0 to point to itself, which is unsafe, if the value of the > idle array is not 0, i

[PATCH v11 12/13] net/sxe: add simd function

2025-07-25 Thread Jie Liu
Add simd function. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_queue_common.c | 54 +- drivers/net/sxe/base/sxe_rx_common.c| 128 - drivers/net/sxe/pf/sxe_vec_common.h | 321 drivers/net/sxe/pf/sxe_vec_neon.c | 602 +++ drivers/net/sxe/

[PATCH v11 11/13] net/sxe: add custom cmd led ctrl

2025-07-25 Thread Jie Liu
Add custom cmd led ctrl. Signed-off-by: Jie Liu --- drivers/net/sxe/include/sxe/sxe_cli.h | 218 drivers/net/sxe/include/sxe/sxe_ioctl.h | 21 +++ drivers/net/sxe/sxe_testpmd.c | 66 +++ 3 files changed, 305 insertions(+) create mode 100644 drivers/net

[PATCH v11 09/13] net/sxe: support ptp

2025-07-25 Thread Jie Liu
Add ptp module. Signed-off-by: Jie Liu --- drivers/net/sxe/pf/sxe_ptp.c | 209 +++ drivers/net/sxe/pf/sxe_ptp.h | 26 + 2 files changed, 235 insertions(+) create mode 100644 drivers/net/sxe/pf/sxe_ptp.c create mode 100644 drivers/net/sxe/pf/sxe_ptp.h diff

[PATCH v11 10/13] net/sxe: add xstats function

2025-07-25 Thread Jie Liu
Add xstats function. Signed-off-by: Jie Liu --- drivers/net/sxe/pf/sxe_main.c | 8 + drivers/net/sxe/pf/sxe_stats.c | 589 + drivers/net/sxe/pf/sxe_stats.h | 68 3 files changed, 665 insertions(+) create mode 100644 drivers/net/sxe/pf/sxe_stats.c create

[PATCH v11 08/13] net/sxe: add dcb function

2025-07-25 Thread Jie Liu
Add dcb function. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build | 28 + drivers/net/sxe/pf/rte_pmd_sxe.h| 2 + drivers/net/sxe/pf/sxe_dcb.c| 946 drivers/net/sxe/pf/sxe_dcb.h| 99 +++ drivers/net/sxe/pf/sxe_main.c

[PATCH v11 07/13] net/sxe: support rss offload

2025-07-25 Thread Jie Liu
Support rss offload. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 11 +- drivers/net/sxe/pf/sxe_offload.c | 299 ++ drivers/net/sxe/pf/sxe_offload.h | 33 +++ 3 files changed, 338 insertions(+), 5 deletions(-) diff --git a/driver

[PATCH v11 06/13] net/sxe: add filter function

2025-07-25 Thread Jie Liu
Add filter function. Signed-off-by: Jie Liu --- drivers/net/sxe/pf/sxe_filter.c | 191 drivers/net/sxe/pf/sxe_filter.h | 29 + drivers/net/sxe/pf/sxe_main.c | 1 + 3 files changed, 221 insertions(+) diff --git a/drivers/net/sxe/pf/sxe_filter.c b/drivers

[PATCH v11 05/13] net/sxe: support vlan filter

2025-07-25 Thread Jie Liu
Support vlan filter. Signed-off-by: Jie Liu --- drivers/net/sxe/base/sxe_offload_common.c | 4 + drivers/net/sxe/pf/sxe_filter.c | 277 ++ drivers/net/sxe/pf/sxe_filter.h | 13 + drivers/net/sxe/pf/sxe_main.c | 2 + 4 files changed, 296 in

[PATCH v11 04/13] net/sxe: add link, flow ctrl, mac ops, mtu ops function

2025-07-25 Thread Jie Liu
Add link, flow ctrl, mac ops, mtu ops function. Signed-off-by: Jie Liu --- drivers/net/sxe/meson.build| 19 +- drivers/net/sxe/pf/sxe.h | 36 +- drivers/net/sxe/pf/sxe_ethdev.c| 638 +++- drivers/net/sxe/pf/sxe_filter.c| 278 + drivers/net/sxe/

[PATCH v11 01/13] net/sxe: add base driver directory and doc

2025-07-25 Thread Jie Liu
Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver. Signed-off-by: Jie Liu --- MAINTAINERS | 6 +++ doc/guides/nics/features/sxe.ini| 78 + doc/guides/nics/features/sxe_vf.ini

RE: Issue with DPDK-Burst Replay – No Frame Transmission Observed Despite Successful Replay

2025-07-25 Thread Ivan Malov
Hi Ernesto, On Fri, 25 Jul 2025, Ernesto Ruffini wrote: Hi, Did you try using usertools/dpdk-telemetry.py? It attaches to a running DPDK process (so your sending process should stay running and not close immediately), and can show many counters, including packets output by a device. At the co

[PATCH] acl: fix the value of the trans table

2025-07-25 Thread Huichao Cai
The node_array[RTE_ACL_DFA_SIZE] is assigned to RTE_ACL_IDLE_NODE and is used as a node of RTE_ACL_NODE_SINGLE type, but it is currently based on the implementation of idle arrays with a value of all 0 to point to itself, which is unsafe, if the value of the idle array is not 0, it will produce und

RE: Issue with DPDK-Burst Replay – No Frame Transmission Observed Despite Successful Replay

2025-07-25 Thread Ernesto Ruffini
Hi, Did you try using usertools/dpdk-telemetry.py? It attaches to a running DPDK process (so your sending process should stay running and not close immediately), and can show many counters, including packets output by a device. At the command prompt, you can type "/ethdev/stats,0" and it will sho

RE: Issue with DPDK-Burst Replay – No Frame Transmission Observed Despite Successful Replay

2025-07-25 Thread Gokul K R (MS/ETA7-ETAS)
Hi Ivan, Yes, I rechecked. The PCAP file has the correct source and destination MAC addresses, and promiscuous mode is enabled on receiver NIC. Question 1: Is there a recommended way to verify whether packets are actually being transmitted from the DPDK-bound NIC? Mit freundlichen Grüßen / Best

RE: Issue with DPDK-Burst Replay – No Frame Transmission Observed Despite Successful Replay

2025-07-25 Thread Gokul K R (MS/ETA7-ETAS)
Hi, In the meantime, I was able to successfully replay my PCAP file using the dpdk-burst-replay tool from your repository (https://github.com/FraudBuster/dpdk-burst-replay). Below is the output from the tool: sudo ./src/dpdk-replay wendutput.pcap :01:00.0 preloading wendutput.pcap file (of