RE: [EXTERNAL] [PATCH] doc: announce DMA configuration structure changes

Acked-by: Amit Prakash Shukla From: pbhagavat...@marvell.com Sent: Wednesday, April 16, 2025 4:36 PM To: Jerin Jacob Cc: Vamsi Krishna Attunuru ; g.si...@nxp.com; sachin.sax...@nxp.com; hemant.agra...@nxp.com; fengcheng...@huawei.com; bruce.richard...@intel.com; kevin.la...@intel.com; conor

Re: [PATCH v2 1/2] net/cnxk: fix lock for security session ops

Recheck-request: rebase=next-net-mrvl-for-main, loongarch-compilation

Re: [PATCH v2] net/iavf: fix VLAN offload strip flag

Hi Ciara Thanks for your effort in reproducing the issue and confirming that the patch works. However, I have taken care of the indentation in the commit message and sent out a v2 patch. Appreciate your review comments. *>>>Perhaps we should make the disabling unconditional or even better make it

[PATCH 0/2] Use consecutive Tx queues' memory

This patchset will move all the mlx5 Tx queues memory to a consecutive memory area. All the WQEBBs will be allocated based on the offset of this memory area. Bing Zhao (2): net/mlx5: add new devarg for Tx queue consecutive memory net/mlx5: use consecutive memory for all Tx queues drivers/com

[PATCH v2] net/iavf: fix VLAN offload strip flag

For i40e kernel drivers which support either vlan(v1) or vlan(v2) VIRTCHNL OP,it will set strip on when setting filter on. But dpdk side will not change strip flag. To be consistent with dpdk side, explicitly disable strip again. Bugzilla ID:1725 Cc: sta...@dpdk.org v2: - Fixed indentation in com

[PATCH v2 2/3] net/mlx5: add new devarg for Tx queue consecutive memory

With this commit, a new device argument is introduced to control the memory allocation for Tx queues. By default, 'txq_consec_mem' is 1 to let all the Tx queues use a consecutive memory area and a single MR. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.c | 14 ++ drivers/net/m

[PATCH v2 3/3] net/mlx5: use consecutive memory for all Tx queues

High cache miss rate may impact the software performance significantly. Usually, the cache misses are caused by the conflict and then some eviction may happen. Now in the mlx5 PMD, the Tx queues are created separately, that means the memory footprints may differ due to the different configurations

[PATCH v2 0/3] Use consecutive Tx queues' memory

This patchset will move all the mlx5 Tx queues memory to a consecutive memory area. All the WQEBBs will be allocated based on the offset of this memory area. --- v2: 1. add a new fix for legacy code of WQE calculation 2. fix the style --- Bing Zhao (3): net/mlx5: fix the WQE size calculation

[PATCH v2 1/3] net/mlx5: fix the WQE size calculation for Tx queue

The txq_calc_wqebb_cnt() should be aligned with the calculation in the function mlx5_txq_devx_obj_new(). Or when the input descriptor number is 512, the WQE size will be wrongly considered to be 30 when no max_inline_data is set. The total number of WQE will be considered as 256 and that is incorre

[PATCH 1/2] net/mlx5: add new devarg for Tx queue consecutive memory

With this commit, a new device argument is introduced to control the memory allocation for Tx queues. By default, 'txq_consec_mem' is 1 to let all the Tx queues use a consecutive memory area and a single MR. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.c | 14 ++ drivers/net/m

[PATCH 2/2] net/mlx5: use consecutive memory for all Tx queues

High cache miss rate may impact the software performance significantly. Usually, the cache misses are caused by the conflict and then some eviction may happen. Now in the mlx5 PMD, the Tx queues are created separately, that means the memory footprints may differ due to the different configurations

Re: [PATCH v5 1/3] eal: deprecate old coremask-based EAL parameters

On Mon, Jun 23, 2025 at 6:13 PM Bruce Richardson wrote: > > This patch will need some rebase. > > > > I see you fixed a few docs, but there are quite some misses in > > copy/pasted blocks: > > > I'll take a look and respin this. > > I'm think of separating it into two patches: first patch with the

CFP Deadline Extended - DPDK Bay Area Summit - September 2025

Dear DPDK Community, Our CFP deadline for the 2025 Bay Area Summit in Santa Clara, Sep. 17-18, 2025, has been formally extended by two weeks, through Sunday, July 6 at 11:59pm Pacific Time. You can reach the CFP page here . We look forward to re

Re: [PATCH v5 1/3] eal: deprecate old coremask-based EAL parameters

On Mon, Jun 23, 2025 at 06:01:00PM +0200, David Marchand wrote: > On Tue, May 27, 2025 at 5:29 PM Bruce Richardson > wrote: > > > > As the number of cores/cpus on platforms has increased over the years, > > the use of coremasks rather than core-lists for identifying DPDK cores > > has become more

Re: [PATCH v5 0/3] lcore options cleanup

On Sun, Jun 8, 2025 at 11:12 PM Thomas Monjalon wrote: > > 27/05/2025 17:29, Bruce Richardson: > > This patchset performs some basic cleanup of EAL lcore arguments before > > any more serious work is done on them (as discussed in previous patchset > > revisions). > > > > * mark the old coremask pa

Re: [PATCH v5 1/3] eal: deprecate old coremask-based EAL parameters

On Tue, May 27, 2025 at 5:29 PM Bruce Richardson wrote: > > As the number of cores/cpus on platforms has increased over the years, > the use of coremasks rather than core-lists for identifying DPDK cores > has become more and more unwieldy. At this point, let's deprecate the > coremask-based EAL p

RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Monday, 23 June 2025 14.08 > > On Mon, Jun 23, 2025 at 10:53 AM Marat Khalili > wrote: > > > > We cannot just remove __rte_cache_aligned from rte_graph_cluster_stats > without removing it from rte_graph_cluster_node_stats because o

Re: [PATCH v3 0/3] enable drivers to be compiled with MSVC

On Thu, Jun 12, 2025 at 4:17 PM Andre Muezerie wrote: > > This patchset solves the last issues preventing drivers from being > compiled with MSVC (array range initialization) and enables the > drivers to be built with it. > > Array range initialization is non-standard and is not provided by > all

Re: [PATCH v2 05/10] cmdline: fix port list parsing

On Mon, Jun 23, 2025 at 03:52:35PM +0200, David Marchand wrote: > Doing arithmetics with the NULL pointer is undefined. > > Caught by UBSan: > > ../lib/cmdline/cmdline_parse_portlist.c:40:19: runtime error: > applying non-zero offset 1 to null pointer > SUMMARY: UndefinedBehaviorSanitizer:

[PATCH v2 00/10] Run with UBSan in GHA

This series fixes a number of issues reported by UBSan and adds a simple job in GHA to avoid introducing undefined behavior in the core components. There is way more work/fixes to do if we want to run with a full set of components, but baby steps first. -- David Marchand Changes since v1: - sma

[PATCH v2 10/10] build: support Undefined Behavior Sanitizer

Enable UBSan in GHA. There are still a lot of issues so only run unit tests for a "mini" target. Building with debugoptimized forces -O2 and consumes too much memory with UBSan, prefer plain build (iow -O0) even though this hides a number of build issues. Signed-off-by: David Marchand --- .ci/l

[PATCH v2 09/10] stack: fix unaligned accesses on 128-bit

Caught by UBSan: ../lib/eal/x86/include/rte_atomic_64.h:206:21: runtime error: member access within misaligned address 0x7ffd9c67f228 for type 'const rte_int128_t', which requires 16 byte alignment 0x7ffd9c67f228: note: pointer points here 00 00 00 00 c0 5d 3e 00 01 00 00

[PATCH v2 08/10] hash: fix unaligned access in predictable RSS

Caught by UBSan: ../lib/hash/rte_thash.c:421:8: runtime error: load of misaligned address 0x0001816c2da3 for type 'uint32_t' (aka 'unsigned int'), which requires 4 byte alignment Fixes: 28ebff11c2dc ("hash: add predictable RSS") Cc: sta...@dpdk.org Signed-off-by: David Marchand

[PATCH v2 07/10] tailq: fix cast macro for null pointer

Doing arithmetics with the NULL pointer is undefined. Caught by UBSan: ../app/test/test_tailq.c:111:9: runtime error: member access within null pointer of type 'struct rte_tailq_head' Fixes: f6b4f6c9c123 ("tailq: use a single cast macro") Cc: sta...@dpdk.org Signed-off-by: David Marchan

[PATCH v2 06/10] cmdline: fix highest bit port list parsing

pl->map is a uint32_t. Caught by UBSan: ../lib/cmdline/cmdline_parse_portlist.c:27:17: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/cmdline/cmdline_parse_portlist.c:27:17 in Fixes: a

[PATCH v2 05/10] cmdline: fix port list parsing

Doing arithmetics with the NULL pointer is undefined. Caught by UBSan: ../lib/cmdline/cmdline_parse_portlist.c:40:19: runtime error: applying non-zero offset 1 to null pointer SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../lib/cmdline/cmdline_parse_portlist.c:40:19 in

[PATCH v2 04/10] eal: fix plugin dir walk

For '.' and '..' directories (or any short file name), a out of bound issue occurs. Caught by UBSan: EAL: Detected shared linkage of DPDK ../lib/eal/common/eal_common_options.c:420:15: runtime error: index -2 out of bounds for type 'char[256]' #0 0x7f867eedf206 in eal_plugindir_init

[PATCH v2 03/10] test/mempool: fix test without stack driver

In a minimal build, the mempool/stack driver is disabled. Separate the code specific to this external driver and rename unrelated variables. Signed-off-by: David Marchand Acked-by: Andrew Rybchenko --- app/test/test_mempool.c | 32 1 file changed, 20 insertions(

[PATCH v2 02/10] test/telemetry: fix test calling all commands

This test was doing nothing as it could not find the telemetry client script following the test suite rework. Caught while looking at UNH unit test logs: /root/workspace/Generic-Unit-Test-DPDK/dpdk/app/test/suites/test_telemetry.sh: 18: /root/workspace/Generic-Unit-Test-DPDK/dpdk/app/usertools/dp

[PATCH v2 01/10] ci: save ccache on failure

When troubleshooting unit test failures and repeating jobs in GHA, the absence of ccache makes the whole process way slower. Signed-off-by: David Marchand --- .github/workflows/build.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/bui

Re: [PATCH v2 2/2] common/cnxk: fix null pointer checks

Recheck-request: rebase=next-net-mrvl-for-main, loongarch-compilation

Re: [PATCH v2 2/2] common/cnxk: fix null pointer checks

Recheck-request: rebase=next-net-mrvl-for-main, loongarch-compilation

Re: [PATCH v2 2/2] common/cnxk: fix null pointer checks

Recheck-request: rebase=main, loongarch-compilation

RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

> -Original Message- > From: David Marchand > Sent: Monday 23 June 2025 13:08 > > Could you spend some time on reviewing patches on the topic? > Like for example: > https://patchwork.dpdk.org/project/dpdk/list/?series=35509 Sure, will look! > rte_malloc is not required. > I have a fix i

Re: [PATCH v7 0/4] Add TxPP Support for E830

On Tue, Jun 17, 2025 at 10:36:10PM +, Soumyadeep Hore wrote: > Added TxPP support for E830 adapters. > --- > v2: > - Fixed Compilation warnings > --- > v3: > - Fixed further Compilation warnings (uinitialised one) > --- > v4: > - Addressed Bruce's comments > --- > v5: > - Addressed Bruce's and

Re: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

On Mon, Jun 23, 2025 at 10:53 AM Marat Khalili wrote: > > Gently reminding about this issue, I still hope to see graph tests passing > under sanitizer. Thanks for trying to fix this, but without coverage on the topic, it is likely we will have new errors in the future. Now that the trace framew

Re: [PATCH v2 1/2] lib/graph: lib/graph: fix memset with NULL

On Tue, Jun 17, 2025 at 5:14 PM Marat Khalili wrote: > > This was flagged by undefined behaviour sanitizer: memset should not be > called with NULL first argument. (memset requires first argument to be > pointer to a memory object, so passing NULL may result in an undefined > behaviour including a

Re: [PATCH 06/10] cmdline: fix highest bit port list parsing

On Fri, Jun 20, 2025 at 11:22 AM Bruce Richardson wrote: > > On Thu, Jun 19, 2025 at 09:10:32AM +0200, David Marchand wrote: > > pl->map is a uint32_t. > > > > Caught by UBSan: > > > > ../lib/cmdline/cmdline_parse_portlist.c:27:17: runtime error: > > left shift of 1 by 31 places cannot be re

RE: [PATCH] net/iavf: fix VLAN offload strip flag

> Subject: [PATCH] net/iavf: fix VLAN offload strip flag > > For i40e kernel drivers which support either vlan(v1) or vlan(v2) > VIRTCHNL OP,it will set strip on when setting filter on. But dpdk > side will not change strip flag. To be consistent with dpdk side, > explicitly disable strip agai

Re: [PATCH 05/10] cmdline: fix port list parsing

On Mon, Jun 23, 2025 at 11:40:15AM +0200, David Marchand wrote: > On Fri, Jun 20, 2025 at 11:59 AM Bruce Richardson > wrote: > > > > On Thu, Jun 19, 2025 at 09:10:31AM +0200, David Marchand wrote: > > > Doing arithmetics with the NULL pointer is undefined. > > > > > > Caught by UBSan: > > > > > >

RE: [PATCH v2 2/2] lib/graph: default-align rte_graph_cluster_stats

Gently reminding about this issue, I still hope to see graph tests passing under sanitizer. We cannot just remove __rte_cache_aligned from rte_graph_cluster_stats without removing it from rte_graph_cluster_node_stats because of how C works. But we can perhaps use rte_malloc to align our allocat

Re: [PATCH 04/10] eal: fix plugin dir walk

On Fri, Jun 20, 2025 at 11:19 AM Bruce Richardson wrote: > > On Thu, Jun 19, 2025 at 09:10:30AM +0200, David Marchand wrote: > > For '.' and '..' directories (or any short file name), > > a out of bound issue occurs. > > > > Caught by UBSan: > > > > EAL: Detected shared linkage of DPDK > > ../lib/

Re: [PATCH 02/10] test/telemetry: fix test calling all commands

Hello Shai, On Thu, Jun 19, 2025 at 9:11 AM David Marchand wrote: > > This test was doing nothing as it could not find the telemetry client > script following the test suite rework. > > Caught while looking at UNH unit test logs: > > /root/workspace/Generic-Unit-Test-DPDK/dpdk/app/test/suites/tes

Re: [PATCH 05/10] cmdline: fix port list parsing

On Fri, Jun 20, 2025 at 11:59 AM Bruce Richardson wrote: > > On Thu, Jun 19, 2025 at 09:10:31AM +0200, David Marchand wrote: > > Doing arithmetics with the NULL pointer is undefined. > > > > Caught by UBSan: > > > > ../lib/cmdline/cmdline_parse_portlist.c:40:19: runtime error: > > applying n