Re: [dpdk-dev] [PATCH v2] drivers: fix build issues with redundant newline changes

2024-10-07 Thread David Marchand
On Mon, Oct 7, 2024 at 2:41 PM wrote: > > From: Jerin Jacob > > Certain section of the code in net/mvpp2 and ml/cnxk is enabled only > when all depended library dependences where meet. > Fixing those build errors. > > Fixes: f665790a5dba ("drivers: remove redundant newline from logs") > > Signed-

Re: [PATCH 2/2] ethdev: fix race on ports for telemetry commands

2024-10-07 Thread David Marchand
On Tue, Oct 8, 2024 at 4:09 AM lihuisong (C) wrote: > > > 在 2024/10/2 23:57, David Marchand 写道: > > While invoking telemetry commands (which may happen at any time, > > out of control of the application), an application thread may > > concurrently add/remove ports. > > The telemetry callbacks may

Re: [PATCH] raw/zxdh: introduce zxdh raw device driver

2024-10-07 Thread zhang.yong25
>> Hi thomas,>>>> I hope this message finds you well.>> I initially >> submitted the zxdh rawdev driver on June 12th, and the final version was >> submitted on August 12th. Since then, I have not received any feedback from >> the community.>> I would appreciate it if you could provide any su

RE: [PATCH v2 2/4] power: refactor uncore power management library

2024-10-07 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Lihuisong, > -Original Message- > From: lihuisong (C) > Sent: Tuesday, August 27, 2024 6:33 PM > To: Tummala, Sivaprasad > Cc: dev@dpdk.org; david.h...@intel.com; anatoly.bura...@intel.com; > radu.nico...@intel.com; jer...@marv

Re: [PATCH 1/5] config/riscv: add flag for using Zbc extension

2024-10-07 Thread Stanisław Kardach
On Mon, Oct 7, 2024 at 5:20 PM Stephen Hemminger wrote: > > On Mon, 7 Oct 2024 10:14:22 +0200 > Stanisław Kardach wrote: > > > > > > > > > > > Please do not add more config options via compile flags. > > > > > It makes it impossible for distros to ship one version. > > That is a problem with RISC

Re: [PATCH v9 0/6] Introduce event pre-scheduling

2024-10-07 Thread Jerin Jacob
On Tue, Oct 8, 2024 at 3:14 AM wrote: > > From: Pavan Nikhilesh > > Event pre-scheduling improves scheduling performance by assigning events > to event ports in advance when dequeues are issued. > This series introduces various types and levels of pre-scheduling to the > eventdev library. > > pre

[DPDK/ethdev Bug 1534] Transmit errors with iavf VF using SR-IOV on VM

2024-10-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1534 junya@anritsu.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: [PATCH 10/10] ethdev: require checking results of info_get functions

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 5:21 PM, Stephen Hemminger wrote: > With functions that return a data structure, the application must > check the return value since the data structure contents will > be undefined in case of error. > > Signed-off-by: Stephen Hemminger > Acked-by: Ferruh Yigit

Re: [PATCH 09/10] ethdev: check return value from rte_eth_dev_info_get

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 5:21 PM, Stephen Hemminger wrote: > The mac compare must check return value from rte_eth_dev_info_get > before using the dev_info information. > > Signed-off-by: Stephen Hemminger > Acked-by: Ferruh Yigit

Re: [PATCH 02/10] net/memif: check return value from rte_eth_dev_info_get

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 5:21 PM, Stephen Hemminger wrote: > Handle errors from rte_eth_dev_info_get in the same manner > as other places in this file. > > Signed-off-by: Stephen Hemminger > Acked-by: Ferruh Yigit

Re: [PATCH v2 1/3] net: add thread-safe crc api

2024-10-07 Thread Ferruh Yigit
On 10/1/2024 7:11 PM, Arkadiusz Kusztal wrote: > The current net CRC API is not thread-safe, this patch > solves this by adding another, thread-safe API functions. > This API is also safe to use across multiple processes, > yet with limitations on max-simd-bitwidth, which will be checked only by >

Re: [PATCH v2] doc: reword sample app guides

2024-10-07 Thread fengchengwen
Hi Nandini, For dma.rst, there are two minor comments, with that fixed, please add: Acked-by: Chengwen Feng Thanks On 2024/10/7 7:45, Nandini Persad wrote: > I have reviewed these sections for grammar/clarity > and made small modifications to the formatting of sections > to adhere to a template

答复: [PATCH v2] r8125: add r8125 ethernet poll mode driver

2024-10-07 Thread 王颢
Dear Stephen, I am currently in the process of merging r8125 (for 2.5G) and r8126 (for 5G). Ultimately, we will have r8169 supporting both 2.5G and 5G. As you may have already seen from some patches, r8169 has been split into several smaller patches. We are still working on adjusting the format

Re: [PATCH] raw/zxdh: introduce zxdh raw device driver

2024-10-07 Thread Stephen Hemminger
On Tue, 8 Oct 2024 09:18:44 +0800 Yong Zhang wrote: > Hi thomas, > > I hope this message finds you well. > I initially submitted the zxdh rawdev driver on June 12th, and the final > version was submitted on August 12th. Since then, I have not received any > feedback from the community. > I

Re: [PATCH v4 1/1] dmadev: support priority configuration

2024-10-07 Thread fengchengwen
Hi, Sorry to reply now, because I just got back from our National Day vacation. >From the commit it seem confused about the dmadev and HW channel, Current one >dmadev is corresponding a HW channel if its a hardware device. So I suggest try not to mention HW channel, but the dmadev or DMA device.

Re: [PATCH RESEND v7 0/5] app/testpmd: support multiple process attach and detach port

2024-10-07 Thread lihuisong (C)
Hi Thomas and Ferruh, We've discussed it on and off a few times, and we've reached some consensus. They've been going through more than 2 years😅 Can you have a look at this series again? If we really don't need it, I will drop it from my upstreaming list. /Huisong 在 2024/9/29 13:52, Huisong Li

Re: [dpdk-dev] [PATCH 10/10] net/bonding: fix configuration assignment overflow

2024-10-07 Thread lihuisong (C)
Hi Stephen, Thanks for your review this series again. 在 2024/10/4 0:03, Stephen Hemminger 写道: On Mon, 19 Apr 2021 21:34:49 +0800 "Min Hu (Connor)" wrote: From: Chengchang Tang The expression may cause an overflow. This patch fix the codeDEX static check warning "INTEGER_OVERFLOW". Fixes

Re: [PATCH 2/2] ethdev: fix race on ports for telemetry commands

2024-10-07 Thread lihuisong (C)
在 2024/10/2 23:57, David Marchand 写道: While invoking telemetry commands (which may happen at any time, out of control of the application), an application thread may concurrently add/remove ports. The telemetry callbacks may then access partially initialised/uninitialised ethdev data. Reuse the

[DPDK/ethdev Bug 1560] "net_txgbe" is unable to retrieve all statistical information correctly through telemetry.

2024-10-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1560 Bug ID: 1560 Summary: "net_txgbe" is unable to retrieve all statistical information correctly through telemetry. Product: DPDK Version: 24.07 Hardware: All OS: All

Re: [PATCH v2] app/testpmd: show output of commands read from file

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 5:56 AM, Ferruh Yigit wrote: > On 8/22/2024 11:41 AM, Bruce Richardson wrote: >> Testpmd supports the "--cmdline-file" parameter to read a set of initial >> commands from a file. However, the only indication that this has been >> done successfully on startup is a single-line message, n

Re:[PATCH] raw/zxdh: introduce zxdh raw device driver

2024-10-07 Thread Yong Zhang
Hi thomas, I hope this message finds you well. I initially submitted the zxdh rawdev driver on June 12th, and the final version was submitted on August 12th. Since then, I have not received any feedback from the community. I would appreciate it if you could provide any suggestions for modific

Re: [PATCH v2 0/3] app/testpmd: improve sse based macswap

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 6:08 AM, Ferruh Yigit wrote: > On 8/21/2024 3:38 PM, Vipin Varghese wrote: >> Goal of the patch series is to improve SSE macswap on x86_64 by >> reducing the stalls in backend engine. Original implementation of >> the SSE-mac-swap makes loop call to multiple load, shuffle & store. >> >

Re: [PATCH] net/gve: fix refill logic causing memory corruption

2024-10-07 Thread Ferruh Yigit
On 10/4/2024 2:05 AM, Joshua Washington wrote: > There is a seemingly mundane error in the RX refill path which can lead > to major issues and ultimately program crashing. > > This error occurs as part of an edge case where the exact number of > buffers the refill causes the ring to wrap around to

Re: [PATCH v2 0/3] make struct parameters constant in rte_tm APIs

2024-10-07 Thread Ferruh Yigit
On 10/7/2024 4:22 PM, Stephen Hemminger wrote: > On Mon, 7 Oct 2024 12:49:04 +0100 > Bruce Richardson wrote: > >> For functions for creating profiles, shapers and hierarchy nodes, make >> the parameter structure pointer a pointer to a const object. This >> guarantees to the user that the struct

Re: [RFC PATCH] app/test: allow passing a parameter string to autotests

2024-10-07 Thread Stephen Hemminger
On Fri, 15 Dec 2023 13:06:56 + Bruce Richardson wrote: > Sometimes it can be nice to have autotests which can take a parameter, > or can be tweaked in some ways, e.g. adjust the number of iterations, or > the burst size used in the test. Currently there is no way to do so - > all test paramet

Re: [RFC 0/4] ethdev: rework config restore

2024-10-07 Thread Ferruh Yigit
On 10/7/2024 10:27 AM, Konstantin Ananyev wrote: > > >>> External email: Use caution opening links or attachments >>> >>> >>> On 9/18/2024 10:21 AM, Dariusz Sosnowski wrote: Hi all, We have been working on optimizing the latency of calls to rte_eth_dev_start(), on ports spawne

Re: [PATCH v2] r8125: add r8125 ethernet poll mode driver

2024-10-07 Thread Stephen Hemminger
On Wed, 12 Jun 2024 17:51:45 +0800 Howard Wang wrote: > r8125 is for Realtek 2.5 Gigabit Ethernet NICs. > > Signed-off-by: Howard Wang > --- To echo what Ferruh mentioned. 1. Break the driver into more easily reviewed pieces. 2. Run checkpatch, there are lots of style problems still in both

Re: [PATCH] checkpatches: verify in-reply-to header when possible

2024-10-07 Thread Robin Jarry
Stephen Hemminger, Oct 07, 2024 at 22:41: + && echo "$subject" | grep -qi 'v[2-9].*\]' \ Your regex won't work for v10 etc. Good catch. I'll send a v2.

Re: [PATCH] checkpatches: verify in-reply-to header when possible

2024-10-07 Thread Stephen Hemminger
On Fri, 5 Jul 2024 17:35:33 +0200 Robin Jarry wrote: > When using checkpatches.sh locally, verify that there is an In-Reply-To > header when the patch is a respin (i.e. v2, v3, etc.). This is currently > only enforced by the upstream CI but cannot be verified locally. > > This cannot be verifie

Re: [PATCH v2] net/mlx5: fix incorrect rx/tx descriptor limitations in rte_eth_dev_info

2024-10-07 Thread Stephen Hemminger
On Wed, 19 Jun 2024 01:56:42 +0300 Igor Gutorov wrote: > Currently, `rte_eth_dev_info.rx_desc_lim.nb_max` as well as > `rte_eth_dev_info.tx_desc_lim.nb_max` shows 65535 as the limit, > which results in a few problems: > > * It is an incorrect value > * Allocating an RX queue and passing `rx_desc

Re: [PATCH v4 0/6] refine argparse library

2024-10-07 Thread Stephen Hemminger
On Mon, 18 Mar 2024 11:18:32 + Chengwen Feng wrote: > I found a couple of issues when I revisited the argparse_autotest > output, so got this patchset. > > Chengwen Feng (6): > argparse: refine error message > argparse: remove dead code > argparse: replace flag enum with marco > argp

Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-10-07 Thread Stephen Hemminger
On Tue, 2 Apr 2024 09:19:23 -0700 Tyler Retzlaff wrote: > On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote: > > The header was missing the extern "C" directive which causes name > > mangling of functions by C++ compilers, leading to linker errors > > complaining of undefined refe

Re: [RFC v1] raw/ntb: add support for 6th Gen Intel Xeon

2024-10-07 Thread Stephen Hemminger
On Fri, 8 Dec 2023 16:07:59 +0800 Junfeng Guo wrote: > Add support for the 6th Gen Intel Xeon Scalable processors. Note that NTB > devices within the 6th Gen Intel Xeon compliant to PCIe 5.0 spec. > > Signed-off-by: Junfeng Guo I would combine the 5th and 6th patches together in new version.

Re: [PATCH] examples/ipsec-secgw: fix cmp_sa_key bug

2024-10-07 Thread Stephen Hemminger
On Wed, 22 Nov 2023 15:58:40 +0800 supeng2087 wrote: > From: supeng > > Inbound direction, sad_lookup function will call cmp_sa_key to compare packet > outer ip info with local sa. Local sa src ip should equal packet dst ip, > Local sa dst ip should equal src ip. > --- > examples/ipsec-se

Re: [PATCH] app/flow-perf: replace RTE_BE32/16 with rte_cpu_to_be_32/16 for variables

2024-10-07 Thread Stephen Hemminger
On Tue, 18 Apr 2023 11:32:50 + Wisam Monther wrote: > Hi, > > > > > > > > -Original Message- > > > > From: Harold Huang > > > > Sent: Sunday, March 12, 2023 4:00 AM > > > > To: dev@dpdk.org > > > > Cc: Harold Huang ; Wisam Monther > > > > > > > > Subject: [PATCH] app/flow-perf: r

[PATCH v2 50/50] net/ntnic: add functions for retrieving and managing packets

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented functionality for retrieving received packets from virtual queues, supporting both SPLIT_RING and PACKED_RING types. Updated sg_ops structure to include the new packet retrieval functions. Signed-off-by: Danylo Vodopianov --- v2 * fix issue(Title underline t

[PATCH v2 49/50] net/ntnic: add functions for releasing virt queues

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented handler busy states and shutdowns of hardware queues. Added functionality for releasing RX and TX virtual queue resources, managed and releasing packets back into the availability ring. Updated sg_ops structure to include new queue management functions. Sign

[PATCH v2 48/50] net/ntnic: virtqueue setup managed packed-ring was added

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Structures were enhanced with PACKED virtqueue fields. Managed function was extended with packed ring configuration and initialization support. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 191 +- drivers/net/ntnic

[PATCH v2 47/50] net/ntnic: update FPGA registeris related to DBS

2024-10-07 Thread Serhii Iliushyk
DBS - DVIO Buffer System Signed-off-by: Serhii Iliushyk --- .../supported/nthw_fpga_9563_055_049_.c | 184 +- 1 file changed, 183 insertions(+), 1 deletion(-) diff --git a/drivers/net/ntnic/nthw/supported/nthw_fpga_9563_055_049_.c b/drivers/net/ntnic/nthw/supported/nt

[PATCH v2 46/50] net/ntnic: add descriptor reader data handling functions

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Added functions for setting and flushing RX and TX descriptor reader data. Implemented internal strcutres to update shadow structures with guest physical address, host ID, queue size, header, and packed status. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbs

[PATCH v2 44/50] net/ntnic: add functions for availability monitor management

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Implemented functions to configure and manage availability monitor data. Added functions to set and flush availability monitor data. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/dbsconfig/ntnic_dbsconfig.c | 61 +++- drivers/net/ntnic/include/ntnic_dbs.h

[PATCH v2 42/50] net/ntnic: add init for virt queues in the DBS

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov DBS (DVIO Buffer System) module controls the scatter-gather buffer system that let's the host CPU interact with packets. Macros and Definitions: Defined constants for queue management and polling speeds. Data Structures: Added structures and arrays for RX and TX queue ma

[PATCH v2 45/50] net/ntnic: used writer data handling functions

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Introduced functions to set and flush RX and TX used writer data. Added support for setting shadow data with functions for guest physical address, host ID, queue size, packed, interrupt enable, vector, and ISTK for RX and TX. Implemented set_rx_used_writer_data and set_t

[PATCH v2 43/50] net/ntnic: add split-queue support

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Split-queue support was added. Internal structures were enhanced with additional managmnet fields. Implement a managed virtual queue function based on the queue type and configuration parameters. DBS control registers were added. Signed-off-by: Danylo Vodopianov ---

[PATCH v2 38/50] net/ntnic: enhance Ethernet device configuration

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Added eth_dev_close function to handle closing of Ethernet devices. It releases managed RX/TX virtual queues. Initialized scatter-gather queue system. Defined constants and macros for hardware RX/TX descriptors and packet buffer sizes. Defined structures for RX and TX p

[PATCH v2 39/50] net/ntnic: add scatter-gather HW deallocation

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Deallocates memory for hardware Virtio queues and unmaps VFIO resources. Updated eth_tx_queue_release and eth_rx_queue_release. Released hardware Virtio queues for TX and RX. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntos_drv.h | 1 + drivers/net/

[PATCH v2 41/50] net/ntnic: add packet handler for virtio queues

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Added functionality to handles the copying of segmented queue data into a rte_mbuf and vice versa. Added functionality to manages packet transmission for a specified TX and RX queues. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntnic_virt_queue.h |

[PATCH v2 28/50] net/ntnic: add categorizer (CAT) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Categorizer module’s main purpose is to is select the behavior of other modules in the FPGA pipeline depending on a protocol check. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 205 drivers/net/ntnic/meson.build

[PATCH v2 40/50] net/ntnic: add queue setup operations

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Added TX and RX queue setup. Handles memory allocation and hardware Virtio queue setup. Allocates and configures memory for hardware Virtio queues, including handling IOMMU and VFIO mappings. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntnic_virt_que

[PATCH v2 34/50] net/ntnic: add packet descriptor builder (PDB) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 34 drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic

[PATCH v2 37/50] net/ntnic: add basic queue operations

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Adds support for queue configure, start, stop, release. The internal macro and functions of ntnic were also added and initialized. Signed-off-by: Danylo Vodopianov --- doc/guides/nics/features/ntnic.ini | 1 + drivers/net/ntnic/include/ntos_drv.h | 34 + driver

[PATCH v2 33/50] net/ntnic: add slicer (SLC LR) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mo

[PATCH v2 36/50] net/ntnic: add receive MAC converter (RMC) core module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The RX MAC Converter module is part of the control mechanism of the physical ports. Signed-off-by: Oleksandr Kolomeiets --- v2 * Fix Typo/Spelling * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 1 + drivers/net/ntnic/adapter/nt4ga_adapter

[PATCH v2 32/50] net/ntnic: add queue select (QSL) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 37 drivers/net/ntnic/meson.build

[PATCH v2 35/50] net/ntnic: add Tx Packet Editor (TPE) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 80 + drivers/net/ntn

[PATCH v2 31/50] net/ntnic: add hasher (HSH) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 36 drivers/net/ntnic/meson.build

[PATCH v2 30/50] net/ntnic: add flow matcher (FLM) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h|

[PATCH v2 29/50] net/ntnic: add key match (KM) FPGA module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h

[PATCH v2 24/50] net/ntnic: add replacer (Tx RPL) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Replacer module can replace a range of bytes in a packet. The replacing data is stored in a table in the module and will often contain tunnel data. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/

[PATCH v2 25/50] net/ntnic: add Tx Packet Editor (TPE) flow module

2024-10-07 Thread Serhii Iliushyk
The TX Packet Editor is a software abstraction module, that keeps track of the handful of FPGA modules that are used to edit packets in the TX pipeline. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/include/hw_mod_backend.h| 27 ++ drivers/net/ntnic/include/hw_mod_tpe_v3.h | 126

[PATCH v2 27/50] net/ntnic: add base init and deinit the NT flow backend

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add basic implementation of the NT flow backend API Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 3 + drivers/net/ntnic/include/flow_api_engine.h | 5 ++ drivers/net/ntnic/include/hw_mod_backend.h| 12 drivers/

[PATCH v2 26/50] net/ntnic: add base init and deinit of the NT flow API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add basic API for initialization resources required by flow filter API Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 82 ++ drivers/net/ntnic/include/flow_api_engine.h | 43 +++ drivers/net/ntnic/include/hw_mod_backen

[PATCH v2 22/50] net/ntnic: add checksum update (CSU) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Checksum Update module updates the checksums of packets that has been modified in any way. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 13 .../ntnic/nthw/flow_f

[PATCH v2 23/50] net/ntnic: add insert (Tx INS) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets he TX Inserter module injects zeros into an offset of a packet, effectively expanding the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 13 .../ntnic/nthw/flo

[PATCH v2 18/50] net/ntnic: add packet descriptor builder (PDB) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Packet Description Builder module creates packet meta-data for example virtio-net headers. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 16 ++ drivers/net/ntnic/include/hw_mod_pdb_v9.h | 42 drivers/net/ntnic/

[PATCH v2 12/50] net/ntnic: add key match (KM) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Key Matcher module checks the values of individual fields of a packet. It supports both exact match which is implemented with a CAM, and wildcards which is implemented with a TCAM. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h

[PATCH v2 21/50] net/ntnic: add copier (Tx CPY) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The TX Copy module writes data to packet fields based on the lookup performed by the FLM module. This is used for NAT and can support other actions based on the RTE action MODIFY_FIELD. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build

[PATCH v2 20/50] net/ntnic: add RPP local retransmit (RPP LR) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The RX Packet Process for Local Retransmit module can add bytes in the FPGA TX pipeline, which is needed when the packet increases in size. Note, this makes room for packet expansion, but the actual expansion is done by the modules. Signed-off-by: Oleksandr Kolomeiets

[PATCH v2 13/50] net/ntnic: add flow matcher (FLM) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Flow Matcher module is a high-performance stateful SDRAM lookup and programming engine which supported exact match lookup in line-rate of up to hundreds of millions of flows. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h|

[PATCH v2 19/50] net/ntnic: add header field update (HFU) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Header Field Update module updates protocol fields if the packets have been changed, for example length fields and next protocol fields. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/f

[PATCH v2 09/50] net/ntnic: add flow backend deinitialization API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the deinitialization of the backend. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/flow_api.h | 7 ++- drivers/net/ntnic/include/flow_filter.h | 1 + drivers/net/ntnic/include/hw_mod_backend.h

[PATCH v2 17/50] net/ntnic: add slicer (SLC LR) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Slicer for Local Retransmit module can cut of the head a packet before the packet leaves the FPGA RX pipeline. This is used when the TX pipeline is configured to add a new head in the packet. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mo

[PATCH v2 16/50] net/ntnic: add queue select (QSL) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Queue Selector module directs packets to a given destination which includes host queues, physical ports, exceptions paths, and discard. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 18 ++ drivers/net/ntnic/include/hw_mo

[PATCH v2 15/50] net/ntnic: add hasher (HSH) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Hasher module calculates a configurable hash value to be used internally by the FPGA. The module support both Toeplitz and NT-hash. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 16 ++ drivers/net/ntnic/include/hw_mod_hs

[PATCH v2 11/50] net/ntnic: add categorizer (CAT) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The Categorizer module’s main purpose is to select the behavior of other modules in the FPGA pipeline, depending on a protocol check. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 51 + drivers/net/ntnic/include/hw_mod_cat_v

[PATCH v2 14/50] net/ntnic: add IP fragmenter (IFR) flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The IP Fragmenter module can fragment outgoing packets based on a programmable MTU. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/meson.build | 1 + .../nthw/flow_api/flow_backend/flow_backend.c | 12 .../ntnic/nthw/flow_filter/flow_

[PATCH v2 10/50] net/ntnic: add INFO flow module

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets The info module keeps track of the hardcoded parameters of the FPGA and provides an abstraction that can support if parameter is unsupported for a given FPGA. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/include/hw_mod_backend.h| 57 +++ drivers/net

[PATCH v2 02/50] net/ntnic: fix coverity issues:

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov CI founc couple coverity problems which were fixed in this commit. CID 440550, 440551, 440545, 440553, 440552, 440547: Null pointer dereferences (REVERSE_INULL) These issues were fixed by reworking variable NULL checking and adding NULL checking before var using. CID 44

[PATCH v2 05/50] net/ntnic: extend and fix logging implementation

2024-10-07 Thread Serhii Iliushyk
From: Danylo Vodopianov Add suffixes logging Fix the issue with the configuration log level for a specific module Fix extended debug logging 3-letter abbreviation for log type Update documentation new log modules were added Log level in functions that initialize feature operations

[PATCH v2 08/50] net/ntnic: add flow backend initialization API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the initialization of the backend. Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 1 + drivers/net/ntnic/include/flow_api.h | 2 ++ drivers/net/ntnic/inclu

[PATCH v2 07/50] net/ntnic: add flow filter deinitialization API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the deinitialization of the flow filter. Signed-off-by: Oleksandr Kolomeiets --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 17 + drivers/net/ntnic/ntnic_mod_reg.h | 1 + 2 files changed, 18 insertions(+) diff

[PATCH v2 06/50] net/ntnic: add flow filter init API

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add high-level interfaces for the initialization of the flow filter. Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 1 + drivers/net/ntnic/adapter/nt4ga_adapter.c | 18 ++ drivers/net

[PATCH v2 04/50] net/ntnic: remove extra calling of the API for release port

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets During rte_eth_dev_close execution, eth_dev_close function exported by ntnic is called, followed by a call to rte_eth_dev_release_port. Since there is no possible returns between the calls, calling rte_eth_dev_release_port from eth_dev_close is redundant and error-pron

[PATCH v2 00/50] Provide: flow filter init API, Enable virtual queues, fix ntnic issues for release 24.07

2024-10-07 Thread Serhii Iliushyk
The list of updates provided by the patchset: * Update the supported version of the FPGA to 9563.55.49 * Fix Coverity issues * Fix issues related to release 24.07 * Extended and fixed the implementation of the logging * Added NT flow filter init API * Added NT flow backend initializatio

[PATCH v2 03/50] net/ntnic: update documentation

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Add forgotten feature to the documentation (ntnic.ini) Signed-off-by: Oleksandr Kolomeiets --- doc/guides/nics/features/ntnic.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/ntnic.ini b/doc/guides/nics/features/ntnic.ini index 0a7481

[PATCH v2 01/50] net/ntnic: update NT NiC PMD driver with FPGA version

2024-10-07 Thread Serhii Iliushyk
From: Oleksandr Kolomeiets Update base FPGA files to the new version(39->49) Fix code style problems Update documentation Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst| 3 ++ drivers/net/ntnic/meson.build

Re: [PATCH v6 1/1] eal/unix: allow creating thread with real-time priority

2024-10-07 Thread Stephen Hemminger
On Fri, 27 Oct 2023 10:08:52 +0200 Thomas Monjalon wrote: > When adding an API for creating threads, > the real-time priority has been forbidden on Unix. > > There is a known issue with ring behaviour, > but it should not be completely forbidden. > > Real-time thread can block some kernel threa

RE: [PATCH v2 1/4] power: refactor core power management library

2024-10-07 Thread Tummala, Sivaprasad
[AMD Official Use Only - AMD Internal Distribution Only] Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Monday, August 26, 2024 8:56 PM > To: Tummala, Sivaprasad > Cc: david.h...@intel.com; anatoly.bura...@intel.com; jer...@marvell.com; > radu.nico...@intel.com; gak.

Re: [PATCH] doc: remove confusing command to send patch

2024-10-07 Thread Stephen Hemminger
On Tue, 10 Oct 2023 18:26:35 +0200 Thomas Monjalon wrote: > In the contributor guide, it was said that no need to Cc maintainers > for new additions, probably for new directories not having a maintainer. > There is no harm, and it is a good habit, to always Cc maintainers. > > Remove this case a

Re: [PATCH v6] app/testpmd: enable cli for programmable action

2024-10-07 Thread Stephen Hemminger
On Thu, 18 Apr 2024 16:39:14 +0100 Ferruh Yigit wrote: > On 2/8/2024 1:10 AM, Ferruh Yigit wrote: > > On 10/11/2023 1:03 PM, Qi Zhang wrote: > >> Parsing command line for rte_flow_action_prog. > >> > >> Syntax: > >> > >> "prog name [arguments \ > >>... end]" > >> > >> Use parse_string0 t

Re: [PATCH] net/mlx5: support no host PF configuration

2024-10-07 Thread Stephen Hemminger
On Wed, 11 Oct 2023 09:41:53 +0300 Jiawei Wang wrote: > From: Xueming Li > > In BlueField, a new firmware configuration option NUM_OF_PF=0 disables > PF on the x86 host side, no HPF on the ARM side, and the only RDMA port > on the ARM side is the bonding device(PF0). A device probe with devargs

Re: [PATCH v2 0/4] power: refactor power management library

2024-10-07 Thread Stephen Hemminger
On Mon, 26 Aug 2024 13:06:45 + Sivaprasad Tummala wrote: > This patchset refactors the power management library, addressing both > core and uncore power management. The primary changes involve the > creation of dedicated directories for each driver within > 'drivers/power/core/*' and 'drivers

Re: [PATCH] bus/pci: don't open uio device in secondary process

2024-10-07 Thread Stephen Hemminger
On Wed, 28 Aug 2024 12:40:02 +0200 Konrad Sztyber wrote: > The uio_pci_generic driver clears the bus master bit when the device > file is closed. So, when the secondary process terminates after probing > a device, that device becomes unusable in the primary process. > > To avoid that, the devic

Re: [PATCH v2 1/2] net/sxe: add net driver sxe

2024-10-07 Thread Stephen Hemminger
On Fri, 6 Sep 2024 10:09:30 +0800 Jie Liu wrote: > diff --git a/drivers/net/sxe/Makefile b/drivers/net/sxe/Makefile > new file mode 100644 > index 00..5e2870fdc4 > --- /dev/null > +++ b/drivers/net/sxe/Makefile DPDK does not use make anymore, please remove this from next version.

RE: [PATCH] eal/x86: cache queried CPU flags

2024-10-07 Thread Wathsala Wathawana Vithanage
> > Hi Bruce, > > Why x86/rte_cpuflags.c is not using rte_getauxval() ? > > I don't see any such DPDK function, unless I'm missing something? I do see a > linux function which includes hw capability flags. I suspect the reasons we > don't use that are: > > 1. Lack of awareness of it (at least on

Re: [PATCH v5] devtools: add .clang-format file

2024-10-07 Thread Stephen Hemminger
On Thu, 16 May 2024 08:20:51 + Abdullah Ömer Yamaç wrote: > clang-format is a tool to format C/C++/Objective-C code. It can be used > to reformat code to match a given coding style, or to ensure that code > adheres to a specific coding style. It helps to maintain a consistent > coding style a

Re: [PATCH 00/16] remove use of VLAs for Windows built code

2024-10-07 Thread Stephen Hemminger
On Wed, 17 Apr 2024 16:41:43 -0700 Tyler Retzlaff wrote: > As per guidance technical board meeting 2024/04/17. This series > removes the use of VLAs from code built for Windows for all 3 > toolchains. If there are additional opportunities to convert VLAs > to regular C arrays please provide the d

Re: [PATCH 3/3] ethdev: import and export data variables for MSVC

2024-10-07 Thread Stephen Hemminger
On Tue, 12 Mar 2024 00:51:48 -0700 Tyler Retzlaff wrote: > diff --git a/lib/ethdev/rte_ethdev_export.h b/lib/ethdev/rte_ethdev_export.h > new file mode 100644 > index 000..7887bee > --- /dev/null > +++ b/lib/ethdev/rte_ethdev_export.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: BSD-3-Cl

Re: [PATCH] test: fix option block

2024-10-07 Thread Stephen Hemminger
On Thu, 14 Mar 2024 09:46:26 + Mingjin Ye wrote: > The options allow (-a) and block (-b) cannot be used at the same time. > Therefore, allow (-a) will not be added when block (-b) is present. > > Fixes: b3ce7891ad38 ("test: fix probing in secondary process") > Cc: sta...@dpdk.org > > Signed

[PATCH v2] crypto/ipsec_mb: bump minimum IPsec MB version

2024-10-07 Thread Brian Dooley
AESNI_MB SW PMDs increment Intel IPsec MB version to 1.4. A minimum IPsec Multi-buffer version of 1.4 or greater is now required for the 24.11 LTS release. Signed-off-by: Brian Dooley Acked-by: Kai Ji Acked-by: Pablo de Lara --- This patch relates to a deprecation notice sent in the 24.03 relea

  1   2   >