[GitHub] [incubator-doris] imay opened a new pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-25 Thread GitBox
imay opened a new pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-doris] morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-25 Thread GitBox
morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317423529 ## File path: be/src/util/arrow/row_block.h ## @@ -0,0 +1,65 @@ +// Licensed to t

[GitHub] [incubator-doris] morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-25 Thread GitBox
morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317423425 ## File path: be/src/util/arrow/utils.h ## @@ -0,0 +1,49 @@ +// Licensed to the A

[GitHub] [incubator-doris] morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-25 Thread GitBox
morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317424096 ## File path: be/src/util/arrow/row_block.cpp ## @@ -0,0 +1,323 @@ +// Licensed t

[GitHub] [incubator-doris] morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-25 Thread GitBox
morningman commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317424846 ## File path: be/src/util/arrow/row_batch.h ## @@ -0,0 +1,70 @@ +// Licensed to t

[GitHub] [incubator-doris] imay commented on issue #1698: refactor RowsetReaderContext

2019-08-25 Thread GitBox
imay commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524688567 @gaodayue I think `preaggregation` and `need_ordered_result ` are different things. When `preaggregation` is true, returning unordered data is OK.

[GitHub] [incubator-doris] imay commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-25 Thread GitBox
imay commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317432262 ## File path: be/src/olap/wrapper_field.cpp ## @@ -53,14 +53,17 @@ WrapperField* WrapperField::create(const TabletCo

[GitHub] [incubator-doris] gaodayue commented on issue #1698: refactor RowsetReaderContext

2019-08-25 Thread GitBox
gaodayue commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524696441 @imay > I think preaggregation and need_ordered_result are different things. When preaggregation is true, returning unordered data is OK.

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf

2019-08-25 Thread GitBox
kangkaisen commented on a change in pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610#discussion_r317437457 ## File path: be/src/olap/wrapper_field.cpp ## @@ -53,14 +53,17 @@ WrapperField* WrapperField::create(const T

[GitHub] [incubator-doris] imay commented on issue #1698: refactor RowsetReaderContext

2019-08-25 Thread GitBox
imay commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524712910 > @imay > > > I think preaggregation and need_ordered_result are different things. When preaggregation is true, returning unordered data is OK.

[GitHub] [incubator-doris] gaodayue commented on issue #1698: refactor RowsetReaderContext

2019-08-25 Thread GitBox
gaodayue commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524716865 > I see that in schema_chage.cpp you assign need_ordered_result to true here, which I think it should be false? This is to keep the behavior

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317456094 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -63,9 +63,9 @@ class Binary

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317458003 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -222,39 +194,26 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317453369 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317457866 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -222,39 +194,26 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317454379 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -147,37 +140,16 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317453726 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -222,39 +194,26 @@ class Bi

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317452834 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317452506 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on issue #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
gaodayue commented on issue #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#issuecomment-524725582 Please also update the PR description that this is to fix #1648 Thi

[GitHub] [incubator-doris] imay commented on issue #1698: refactor RowsetReaderContext

2019-08-25 Thread GitBox
imay commented on issue #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698#issuecomment-524728679 > > I see that in schema_chage.cpp you assign need_ordered_result to true here, which I think it should be false? > > This is to keep the behavi

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317461652 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317461632 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,19 @@ class Binary

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317461852 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -147,37 +140,16 @@ class Bina

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-25 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317461796 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -222,39 +194,26 @@ class Bina

[GitHub] [incubator-doris] imay merged pull request #1698: refactor RowsetReaderContext

2019-08-25 Thread GitBox
imay merged pull request #1698: refactor RowsetReaderContext URL: https://github.com/apache/incubator-doris/pull/1698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] imay merged pull request #1610: Add bitmap agg type and udaf

2019-08-25 Thread GitBox
imay merged pull request #1610: Add bitmap agg type and udaf URL: https://github.com/apache/incubator-doris/pull/1610 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1700: Partition pruning support Expr

2019-08-26 Thread GitBox
chenhao7253886 opened a new pull request #1700: Partition pruning support Expr URL: https://github.com/apache/incubator-doris/pull/1700 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-doris] morningman opened a new issue #1701: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
morningman opened a new issue #1701: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/issues/1701 Currently, Doris does not limit any disk usage, this may cause BE crash after running out of disk space. So we need to monitor the d

[GitHub] [incubator-doris] morningman opened a new pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
morningman opened a new pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702 Set high watermark and flood stage of disk used capacity. And forbid some operations if disk usage is too high. ISSUE: #1

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-26 Thread GitBox
kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r317556403 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -68,6 +73,14 @@ publ

[GitHub] [incubator-doris] gaodayue commented on issue #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-26 Thread GitBox
gaodayue commented on issue #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#issuecomment-524820964 @morningman , please take a look This is an automated message from t

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
chaoyli commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702#discussion_r317559888 ## File path: be/src/olap/data_dir.cpp ## @@ -1057,4 +1058,35 @@ void DataDir::_re

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
chaoyli commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702#discussion_r317561189 ## File path: be/src/olap/data_dir.cpp ## @@ -59,14 +59,14 @@ DataDir::DataDir(con

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
chaoyli commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702#discussion_r317560951 ## File path: be/src/olap/compaction.cpp ## @@ -186,4 +186,17 @@ OLAPStatus Compac

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
chaoyli commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702#discussion_r317562527 ## File path: be/src/olap/schema_change.cpp ## @@ -1889,10 +1889,16 @@ OLAPStatus

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-26 Thread GitBox
morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r317559537 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/SHOW TABLET.md ## @@ -

[GitHub] [incubator-doris] morningman commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-26 Thread GitBox
morningman commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r317563810 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -79,10 +131,106 @@ publ

[GitHub] [incubator-doris] imay commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-26 Thread GitBox
imay commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317575436 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,21 @@ class BinaryPl

[GitHub] [incubator-doris] morningman commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
morningman commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702#discussion_r317579278 ## File path: be/src/olap/data_dir.cpp ## @@ -59,14 +59,14 @@ DataDir::DataDir(

[GitHub] [incubator-doris] imay commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort

2019-08-26 Thread GitBox
imay commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r317559883 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java ## @@

[GitHub] [incubator-doris] imay commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort

2019-08-26 Thread GitBox
imay commented on a change in pull request #1471: Planner support push down predicates past agg, win and sort URL: https://github.com/apache/incubator-doris/pull/1471#discussion_r317559717 ## File path: fe/src/main/java/org/apache/doris/planner/SingleNodePlanner.java ## @@

[GitHub] [incubator-doris] imay opened a new issue #1703: Support Arrow format

2019-08-26 Thread GitBox
imay opened a new issue #1703: Support Arrow format URL: https://github.com/apache/incubator-doris/issues/1703 Now there are some undergoing work in Doris, such connecting with other system like Apache Spark. So there are many work that define data exchange interface. I think we can levera

[GitHub] [incubator-doris] morningman closed pull request #1686: Add a loaded rows in SHOW LOAD result

2019-08-26 Thread GitBox
morningman closed pull request #1686: Add a loaded rows in SHOW LOAD result URL: https://github.com/apache/incubator-doris/pull/1686 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] morningman opened a new pull request #1686: Add a loaded rows in SHOW LOAD result

2019-08-26 Thread GitBox
morningman opened a new pull request #1686: Add a loaded rows in SHOW LOAD result URL: https://github.com/apache/incubator-doris/pull/1686 Add a new column 'JobDetails' to show more info of a load job. Loaded rows will be updated periodically by query report. So that user can see tha

[GitHub] [incubator-doris] wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-26 Thread GitBox
wangbo commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317599205 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,21 @@ class Binary

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-26 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317603802 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,21 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-26 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317603892 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,21 @@ class Bina

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-26 Thread GitBox
gaodayue commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317603892 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,21 @@ class Bina

[GitHub] [incubator-doris] imay commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-26 Thread GitBox
imay commented on a change in pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694#discussion_r317607982 ## File path: be/src/olap/rowset/segment_v2/binary_plain_page.h ## @@ -81,24 +81,21 @@ class BinaryPl

[GitHub] [incubator-doris] imay merged pull request #1694: optimize V2 BinaryPlainPage format (#1648)

2019-08-26 Thread GitBox
imay merged pull request #1694: optimize V2 BinaryPlainPage format (#1648) URL: https://github.com/apache/incubator-doris/pull/1694 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-doris] imay commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-26 Thread GitBox
imay commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317626437 ## File path: be/src/util/arrow/utils.h ## @@ -0,0 +1,49 @@ +// Licensed to the Apache

[GitHub] [incubator-doris] imay commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-26 Thread GitBox
imay commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317626834 ## File path: be/src/util/arrow/row_batch.h ## @@ -0,0 +1,70 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] imay commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-26 Thread GitBox
imay commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317626704 ## File path: be/src/util/arrow/row_block.h ## @@ -0,0 +1,65 @@ +// Licensed to the Apa

[GitHub] [incubator-doris] imay commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-26 Thread GitBox
imay commented on a change in pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699#discussion_r317626754 ## File path: be/src/util/arrow/row_block.cpp ## @@ -0,0 +1,323 @@ +// Licensed to the

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-26 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r317675693 ## File path: fe/src/main/java/org/apache/doris/analysis/DateLiteral.java ## @@ -29,16 +31,58 @@ import org.

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-26 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r317677438 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -92,415 +89,67 @@ public static

[GitHub] [incubator-doris] imay commented on a change in pull request #1644: Refactor DateLiteral class in FE

2019-08-26 Thread GitBox
imay commented on a change in pull request #1644: Refactor DateLiteral class in FE URL: https://github.com/apache/incubator-doris/pull/1644#discussion_r317673067 ## File path: fe/src/main/java/org/apache/doris/rewrite/FEFunctions.java ## @@ -56,8 +49,13 @@ */ @F

[GitHub] [incubator-doris] morningman commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
morningman commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702#discussion_r317857248 ## File path: be/src/olap/data_dir.cpp ## @@ -1057,4 +1058,35 @@ void DataDir::

[GitHub] [incubator-doris] morningman commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity

2019-08-26 Thread GitBox
morningman commented on a change in pull request #1702: Limit the disk usage to avoid running out of disk capacity URL: https://github.com/apache/incubator-doris/pull/1702#discussion_r317857231 ## File path: be/src/olap/data_dir.cpp ## @@ -1057,4 +1058,35 @@ void DataDir::

[GitHub] [incubator-doris] gaodayue opened a new pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-26 Thread GitBox
gaodayue opened a new pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704 Main changes - support multiple key ranges in RowwiseIterator and StorageReadOptions - remove unused fields and

[GitHub] [incubator-doris] gaodayue commented on issue #1678: Add rowset id generator to FE and BE

2019-08-26 Thread GitBox
gaodayue commented on issue #1678: Add rowset id generator to FE and BE URL: https://github.com/apache/incubator-doris/pull/1678#issuecomment-525110566 Can anyone explain what's the purpose of this PR and give a brief description of what's changed? -

[GitHub] [incubator-doris] liutang123 opened a new pull request #1705: Limit V2 segment file row count (#1647)

2019-08-26 Thread GitBox
liutang123 opened a new pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705 Because many bitmap implementations usually only support 32 bits integer, so use INT_MAX to limit the row count of a segment file. ---

[GitHub] [incubator-doris] liutang123 commented on issue #1705: Limit V2 segment file row count (#1647)

2019-08-26 Thread GitBox
liutang123 commented on issue #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#issuecomment-525113963 @gaodayue This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] liutang123 edited a comment on issue #1705: Limit V2 segment file row count (#1647)

2019-08-26 Thread GitBox
liutang123 edited a comment on issue #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#issuecomment-525113963 cc @gaodayue This is an automated message from the Apache Gi

[GitHub] [incubator-doris] morningman opened a new issue #1706: BE cash when inserting data

2019-08-26 Thread GitBox
morningman opened a new issue #1706: BE cash when inserting data URL: https://github.com/apache/incubator-doris/issues/1706 **To Reproduce** ``` CREATE TABLE `largeint_s` ( `k1` tinyint(4) NOT NULL COMMENT "", `k2` smallint(6) NOT NULL COMMENT "", `k3` bigint(20) NOT NUL

[GitHub] [incubator-doris] imay merged pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow

2019-08-26 Thread GitBox
imay merged pull request #1699: Support converting RowBatch and RowBlockV2 to/from Arrow URL: https://github.com/apache/incubator-doris/pull/1699 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-26 Thread GitBox
kangpinghuang commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317891752 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ##

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-26 Thread GitBox
kangpinghuang commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317892116 ## File path: be/src/util/doris_metrics.h ## @@ -107,9 +107,14 @@

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-26 Thread GitBox
gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317893771 ## File path: be/src/util/doris_metrics.h ## @@ -107,9 +107,14 @@ clas

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-26 Thread GitBox
gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317894281 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.h ## @@ -

[GitHub] [incubator-doris] zhaidongbo opened a new issue #1707: Support new hint format /* */

2019-08-26 Thread GitBox
zhaidongbo opened a new issue #1707: Support new hint format /* */ URL: https://github.com/apache/incubator-doris/issues/1707 Doris now only support the hint format [ ]. When connecting Doris by Druid (connect pool), Druid report error about []. Mysql and Hive only support the hint fo

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1705: Limit V2 segment file row count (#1647)

2019-08-26 Thread GitBox
chaoyli commented on a change in pull request #1705: Limit V2 segment file row count (#1647) URL: https://github.com/apache/incubator-doris/pull/1705#discussion_r317904432 ## File path: be/src/olap/rowset/beta_rowset_writer.cpp ## @@ -84,6 +84,9 @@ OLAPStatus BetaRowsetWri

[GitHub] [incubator-doris] imay merged pull request #1686: Add a loaded rows in SHOW LOAD result

2019-08-26 Thread GitBox
imay merged pull request #1686: Add a loaded rows in SHOW LOAD result URL: https://github.com/apache/incubator-doris/pull/1686 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-doris] imay commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-26 Thread GitBox
imay commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317915271 ## File path: be/src/olap/iterators.h ## @@ -28,27 +28,63 @@ class RowBloc

[GitHub] [incubator-doris] imay commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-26 Thread GitBox
imay commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317913758 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@ -47

[GitHub] [incubator-doris] HawickMason commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23

2019-08-27 Thread GitBox
HawickMason commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23 URL: https://github.com/apache/incubator-doris/issues/1256#issuecomment-525167861 any idea why this hanppened @imay I got the same error with "failed to ini

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-27 Thread GitBox
gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317921343 ## File path: be/src/olap/iterators.h ## @@ -28,27 +28,63 @@ class Row

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-27 Thread GitBox
gaodayue commented on a change in pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317922042 ## File path: be/src/olap/rowset/segment_v2/segment_iterator.cpp ## @@

[GitHub] [incubator-doris] chaoyli commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23

2019-08-27 Thread GitBox
chaoyli commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23 URL: https://github.com/apache/incubator-doris/issues/1256#issuecomment-525168855 Query may lasts so long. During this period, compaction has done and remove com

[GitHub] [incubator-doris] chaoyli edited a comment on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23

2019-08-27 Thread GitBox
chaoyli edited a comment on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23 URL: https://github.com/apache/incubator-doris/issues/1256#issuecomment-525168855 Query may lasts so long. During this period, compaction has done and remo

[GitHub] [incubator-doris] imay opened a new pull request #1708: Add donating to ASF in README

2019-08-27 Thread GitBox
imay opened a new pull request #1708: Add donating to ASF in README URL: https://github.com/apache/incubator-doris/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-doris] chaoyli commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23

2019-08-27 Thread GitBox
chaoyli commented on issue #1256: failed to initialize storage reader. tablet=322844.1094272791, res=-214, backend=10.90.239.23 URL: https://github.com/apache/incubator-doris/issues/1256#issuecomment-525169788 You can compare the exec/olap_scanner.cpp, which call capture_rs_readers() in a

[GitHub] [incubator-doris] imay merged pull request #1708: Add donating to ASF in README

2019-08-27 Thread GitBox
imay merged pull request #1708: Add donating to ASF in README URL: https://github.com/apache/incubator-doris/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] morningman opened a new pull request #1709: Make the max recursion depth of distribution pruner configurable

2019-08-27 Thread GitBox
morningman opened a new pull request #1709: Make the max recursion depth of distribution pruner configurable URL: https://github.com/apache/incubator-doris/pull/1709 Add a new FE config 'max_distribution_pruner_recursion_depth'. -

[GitHub] [incubator-doris] imay commented on a change in pull request #1709: Make the max recursion depth of distribution pruner configurable

2019-08-27 Thread GitBox
imay commented on a change in pull request #1709: Make the max recursion depth of distribution pruner configurable URL: https://github.com/apache/incubator-doris/pull/1709#discussion_r317951999 ## File path: fe/src/main/java/org/apache/doris/planner/HashDistributionPruner.java ###

[GitHub] [incubator-doris] imay commented on a change in pull request #1709: Make the max recursion depth of distribution pruner configurable

2019-08-27 Thread GitBox
imay commented on a change in pull request #1709: Make the max recursion depth of distribution pruner configurable URL: https://github.com/apache/incubator-doris/pull/1709#discussion_r317951835 ## File path: fe/src/main/java/org/apache/doris/planner/HashDistributionPruner.java ###

[GitHub] [incubator-doris] kangpinghuang opened a new issue #1710: query will failed when where predicate has string field

2019-08-27 Thread GitBox
kangpinghuang opened a new issue #1710: query will failed when where predicate has string field URL: https://github.com/apache/incubator-doris/issues/1710 the result of sql select * from baseall where k6='true' order by k6; is different from query: select * from baseall order

[GitHub] [incubator-doris] kangpinghuang commented on issue #1710: query will failed when where predicate has string field

2019-08-27 Thread GitBox
kangpinghuang commented on issue #1710: query will failed when where predicate has string field URL: https://github.com/apache/incubator-doris/issues/1710#issuecomment-525221296 this is because there is a bug when wrapper_field.from_string(), which lead to string compare failed.

[GitHub] [incubator-doris] imay merged pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions

2019-08-27 Thread GitBox
imay merged pull request #1704: support multiple key ranges in RowwiseIterator and StorageReadOptions URL: https://github.com/apache/incubator-doris/pull/1704 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-doris] wuyunfeng opened a new pull request #1711: Add particular log info for doris on es

2019-08-27 Thread GitBox
wuyunfeng opened a new pull request #1711: Add particular log info for doris on es URL: https://github.com/apache/incubator-doris/pull/1711 It is necessary for logging the generated query DSL for Doris On ES This is an automa

[GitHub] [incubator-doris] imay opened a new pull request #1712: Make StringValue's memory layout same with Slice

2019-08-27 Thread GitBox
imay opened a new pull request #1712: Make StringValue's memory layout same with Slice URL: https://github.com/apache/incubator-doris/pull/1712 In our storage engine's code, we cast StringValue to Slice. Because their memory layout is not differenct, it may cause BE process crash.

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1713: fix from string bug(#1710)

2019-08-27 Thread GitBox
kangpinghuang opened a new pull request #1713: fix from string bug(#1710) URL: https://github.com/apache/incubator-doris/pull/1713 Fix WrapperField from_string bug for char type. This is an automated message from the Apache Gi

[GitHub] [incubator-doris] chaoyli merged pull request #1713: fix from string bug(#1710)

2019-08-27 Thread GitBox
chaoyli merged pull request #1713: fix from string bug(#1710) URL: https://github.com/apache/incubator-doris/pull/1713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318015491 ## File path: fe/src/main/java/org/apache/doris/analysis/ShowTabletStmt.java ## @@ -79,10 +131,106 @@ p

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547)

2019-08-27 Thread GitBox
kangpinghuang commented on a change in pull request #1687: add limit to show tablet(#1547) URL: https://github.com/apache/incubator-doris/pull/1687#discussion_r318015451 ## File path: docs/documentation/cn/sql-reference/sql-statements/Data Manipulation/SHOW TABLET.md ## @

[GitHub] [incubator-doris] kangkaisen commented on issue #1712: Make StringValue's memory layout same with Slice

2019-08-27 Thread GitBox
kangkaisen commented on issue #1712: Make StringValue's memory layout same with Slice URL: https://github.com/apache/incubator-doris/pull/1712#issuecomment-525252535 Fix https://github.com/apache/incubator-doris/issues/1706 +1 LGTM ---

[GitHub] [incubator-doris] morningman merged pull request #1712: Make StringValue's memory layout same with Slice

2019-08-27 Thread GitBox
morningman merged pull request #1712: Make StringValue's memory layout same with Slice URL: https://github.com/apache/incubator-doris/pull/1712 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-doris] morningman merged pull request #1711: Add particular log info for doris on es

2019-08-27 Thread GitBox
morningman merged pull request #1711: Add particular log info for doris on es URL: https://github.com/apache/incubator-doris/pull/1711 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-doris] morningman merged pull request #1709: Make the max recursion depth of distribution pruner configurable

2019-08-27 Thread GitBox
morningman merged pull request #1709: Make the max recursion depth of distribution pruner configurable URL: https://github.com/apache/incubator-doris/pull/1709 This is an automated message from the Apache Git Service. To res

<    25   26   27   28   29   30   31   32   33   34   >