gaodayue commented on a change in pull request #1704: support multiple key 
ranges in RowwiseIterator and StorageReadOptions
URL: https://github.com/apache/incubator-doris/pull/1704#discussion_r317921343
 
 

 ##########
 File path: be/src/olap/iterators.h
 ##########
 @@ -28,27 +28,63 @@ class RowBlockV2;
 class Schema;
 class Conditions;
 
-struct StorageReadOptions {
-    // lower_bound defines the smallest key at which iterator will
-    // return data.
-    // If lower_bound is null, won't return
-    std::shared_ptr<RowCursor> lower_bound;
-
-    // If include_lower_bound is true, data equal with lower_bound will
-    // be read
-    bool include_lower_bound = false;
-
-    // upper_bound defines the extend upto which the iterator can return
-    // data.
-    std::shared_ptr<RowCursor> upper_bound;
-
-    // If include_upper_bound is true, data equal with upper_bound will
-    // be read
-    bool include_upper_bound = false;
-
-    // reader's column predicates
-    // used by zone map/bloom filter/secondary index to prune data
-    std::shared_ptr<Conditions> conditions;
+class StorageReadOptions {
 
 Review comment:
   ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to