[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1646: Support page compression in BetaRowset

2019-08-16 Thread GitBox
chaoyli commented on a change in pull request #1646: Support page compression in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314931824 ## File path: be/src/olap/rowset/segment_v2/column_reader.cpp ## @@ -106,30 +111,47 @@ Status ColumnRe

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1646: Support page compression in BetaRowset

2019-08-16 Thread GitBox
gaodayue commented on a change in pull request #1646: Support page compression in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314790770 ## File path: be/src/olap/rowset/segment_v2/page_compression.h ## @@ -0,0 +1,98 @@ +// Licensed to th

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1646: Support page compression in BetaRowset

2019-08-16 Thread GitBox
gaodayue commented on a change in pull request #1646: Support page compression in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314805202 ## File path: be/src/olap/rowset/segment_v2/column_writer.cpp ## @@ -222,23 +224,34 @@ Status ColumnW

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1646: Support page compression in BetaRowset

2019-08-16 Thread GitBox
gaodayue commented on a change in pull request #1646: Support page compression in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314794911 ## File path: be/src/olap/rowset/segment_v2/page_compression.h ## @@ -0,0 +1,98 @@ +// Licensed to th

[GitHub] [incubator-doris] gaodayue commented on a change in pull request #1646: Support page compression in BetaRowset

2019-08-16 Thread GitBox
gaodayue commented on a change in pull request #1646: Support page compression in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314798918 ## File path: be/src/olap/rowset/segment_v2/page_compression.cpp ## @@ -0,0 +1,96 @@ +// Licensed to

[GitHub] [incubator-doris] imay commented on a change in pull request #1646: Support page compression in BetaRowset

2019-08-16 Thread GitBox
imay commented on a change in pull request #1646: Support page compression in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314739992 ## File path: be/src/olap/rowset/segment_v2/page_compression.h ## @@ -86,9 +87,8 @@ class PageCompressor

[GitHub] [incubator-doris] imay commented on a change in pull request #1646: Support page compression in BetaRowset

2019-08-16 Thread GitBox
imay commented on a change in pull request #1646: Support page compression in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314739417 ## File path: be/src/olap/rowset/segment_v2/column_writer.h ## @@ -38,6 +39,7 @@ struct ColumnWriterOptio

[GitHub] [incubator-doris] imay closed pull request #1660: modify Doc file

2019-08-16 Thread GitBox
imay closed pull request #1660: modify Doc file URL: https://github.com/apache/incubator-doris/pull/1660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-doris] imay merged pull request #1597: Support checking error data row when doing INSERT

2019-08-16 Thread GitBox
imay merged pull request #1597: Support checking error data row when doing INSERT URL: https://github.com/apache/incubator-doris/pull/1597 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] imay commented on a change in pull request #1597: Support checking error data row when doing INSERT

2019-08-16 Thread GitBox
imay commented on a change in pull request #1597: Support checking error data row when doing INSERT URL: https://github.com/apache/incubator-doris/pull/1597#discussion_r314669650 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -612,35 +616,36 @@

[GitHub] [incubator-doris] imay merged pull request #1658: FROM_UNIXTIME should only convert timestamp from 0 to 253402271999

2019-08-16 Thread GitBox
imay merged pull request #1658: FROM_UNIXTIME should only convert timestamp from 0 to 253402271999 URL: https://github.com/apache/incubator-doris/pull/1658 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-doris] morningman merged pull request #1661: Print logs when parse scroll result failed

2019-08-16 Thread GitBox
morningman merged pull request #1661: Print logs when parse scroll result failed URL: https://github.com/apache/incubator-doris/pull/1661 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-doris] yiguolei opened a new pull request #1661: Print logs when parse scroll result failed

2019-08-16 Thread GitBox
yiguolei opened a new pull request #1661: Print logs when parse scroll result failed URL: https://github.com/apache/incubator-doris/pull/1661 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1646: Support page compression in BetaRowset

2019-08-16 Thread GitBox
chaoyli commented on a change in pull request #1646: Support page compression in BetaRowset URL: https://github.com/apache/incubator-doris/pull/1646#discussion_r314556042 ## File path: be/src/olap/rowset/segment_v2/page_compression.h ## @@ -86,9 +87,8 @@ class PageCompress

[GitHub] [incubator-doris] imay commented on a change in pull request #1597: Support checking error data row when doing INSERT

2019-08-16 Thread GitBox
imay commented on a change in pull request #1597: Support checking error data row when doing INSERT URL: https://github.com/apache/incubator-doris/pull/1597#discussion_r314630388 ## File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java ## @@ -612,36 +616,31 @@

[GitHub] [incubator-doris] morningman closed pull request #1597: Support checking error data row when doing INSERT

2019-08-16 Thread GitBox
morningman closed pull request #1597: Support checking error data row when doing INSERT URL: https://github.com/apache/incubator-doris/pull/1597 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [incubator-doris] morningman opened a new pull request #1597: Support checking error data row when doing INSERT

2019-08-16 Thread GitBox
morningman opened a new pull request #1597: Support checking error data row when doing INSERT URL: https://github.com/apache/incubator-doris/pull/1597 If strict mode is true, and at least one row is filtered, the insert operation will fail and a url will be given to get the error rows.

[GitHub] [incubator-doris] manannan2017 opened a new pull request #1660: modify Doc file

2019-08-16 Thread GitBox
manannan2017 opened a new pull request #1660: modify Doc file URL: https://github.com/apache/incubator-doris/pull/1660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] yuanlihan commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-16 Thread GitBox
yuanlihan commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314612151 ## File path: be/src/exec/base_scanner.cpp ## @@ -179,4 +179,21 @@ bool BaseS

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-16 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314604233 ## File path: be/src/exec/parquet_scanner.cpp ## @@ -70,6 +70,9 @@ Status ParquetS

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-16 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314606951 ## File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroup.java ## @@ -3

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-16 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314609191 ## File path: be/src/exec/base_scanner.cpp ## @@ -179,4 +179,21 @@ bool BaseScanne

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-16 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314604083 ## File path: be/src/exec/parquet_reader.cpp ## @@ -122,16 +122,18 @@ inline void

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-16 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314608503 ## File path: fe/src/main/java/org/apache/doris/load/Load.java ## @@ -651,11 +651,

[GitHub] [incubator-doris] imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582)

2019-08-16 Thread GitBox
imay commented on a change in pull request #1635: Enable parsing columns from file path for Broker Load (#1582) URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314609114 ## File path: fe/src/test/java/org/apache/doris/common/util/BrokerUtilTest.java ##