imay commented on a change in pull request #1635: Enable parsing columns from 
file path for Broker Load (#1582)
URL: https://github.com/apache/incubator-doris/pull/1635#discussion_r314606951
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/load/BrokerFileGroup.java
 ##########
 @@ -326,17 +352,33 @@ public void readFields(DataInput in) throws IOException {
                 fileFormat = Text.readString(in);
             }
         }
+        // columnsFromPath
+        if (Catalog.getCurrentCatalogJournalVersion() >= 
FeMetaVersion.VERSION_59) {
 
 Review comment:
   I think there is no need to persist `columnsFromPath`. Because Load have 
already persist all Load statement, and will generate DataDescriptor when 
restart.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org
For additional commands, e-mail: dev-h...@doris.apache.org

Reply via email to