[GitHub] [incubator-doris] imay opened a new issue #1548: Unify Storage Field and ColumnSchema

2019-07-24 Thread GitBox
imay opened a new issue #1548: Unify Storage Field and ColumnSchema URL: https://github.com/apache/incubator-doris/issues/1548 Currently, Field and ColumnSchema has most the same function. For make our code clean and easy to master. I want to unify these two classes into one class. ---

[GitHub] [incubator-doris] kangpinghuang opened a new issue #1547: add limit to show tablet from table

2019-07-24 Thread GitBox
kangpinghuang opened a new issue #1547: add limit to show tablet from table URL: https://github.com/apache/incubator-doris/issues/1547 Now show tablet from table will list all tablets of the table. If the tablets is to many, it will print too many contents to flush the screen, which will w

[GitHub] [incubator-doris] imay commented on a change in pull request #1546: Fix bugs of Broker load

2019-07-24 Thread GitBox
imay commented on a change in pull request #1546: Fix bugs of Broker load URL: https://github.com/apache/incubator-doris/pull/1546#discussion_r307112319 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java ## @@ -682,7 +697,7 @@ public void afterAborted(

[GitHub] [incubator-doris] imay commented on a change in pull request #1546: Fix bugs of Broker load

2019-07-24 Thread GitBox
imay commented on a change in pull request #1546: Fix bugs of Broker load URL: https://github.com/apache/incubator-doris/pull/1546#discussion_r307111281 ## File path: be/src/exec/tablet_sink.h ## @@ -263,6 +266,8 @@ class OlapTableSink : public DataSink { // BE id ->

[GitHub] [incubator-doris] imay commented on a change in pull request #1546: Fix bugs of Broker load

2019-07-24 Thread GitBox
imay commented on a change in pull request #1546: Fix bugs of Broker load URL: https://github.com/apache/incubator-doris/pull/1546#discussion_r307111651 ## File path: be/src/runtime/tablet_writer_mgr.cpp ## @@ -309,7 +312,9 @@ Status TabletWriterMgr::add_batch(

[GitHub] [incubator-doris] imay commented on a change in pull request #1546: Fix bugs of Broker load

2019-07-24 Thread GitBox
imay commented on a change in pull request #1546: Fix bugs of Broker load URL: https://github.com/apache/incubator-doris/pull/1546#discussion_r307112713 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadingTaskPlanner.java ## @@ -201,4 +200,17 @@ private Stri

[GitHub] [incubator-doris] morningman opened a new pull request #1546: Fix bugs of Broker load

2019-07-24 Thread GitBox
morningman opened a new pull request #1546: Fix bugs of Broker load URL: https://github.com/apache/incubator-doris/pull/1546 1. Use same UUID as query ID and load ID of a load execution plan. Each load execution plan has a load ID, and as a plan, there is also a query ID. We can use s

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-24 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r307096251 ## File path: be/src/runtime/memory_scratch_sink.cpp ## @@ -0,0 +1,258 @@ +// Licensed to the Apache Soft

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-24 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r307094042 ## File path: fe/src/main/java/org/apache/doris/http/rest/TableRowCountAction.java ## @@ -0,0 +1,137 @@ +

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-24 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r307092897 ## File path: be/src/runtime/exec_env.cpp ## @@ -18,7 +18,8 @@ #include "runtime/exec_env.h" #include

[GitHub] [incubator-doris] imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability

2019-07-24 Thread GitBox
imay commented on a change in pull request #1527: Expose data pruned-filter-scan ability URL: https://github.com/apache/incubator-doris/pull/1527#discussion_r307096178 ## File path: be/src/service/backend_service.h ## @@ -148,11 +166,32 @@ class BackendService : public Bac

[GitHub] [incubator-doris] imay merged pull request #1545: Unify ColumnSchemaV2 and ColumnSchema to one

2019-07-24 Thread GitBox
imay merged pull request #1545: Unify ColumnSchemaV2 and ColumnSchema to one URL: https://github.com/apache/incubator-doris/pull/1545 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] imay opened a new pull request #1545: Unify ColumnSchemaV2 and ColumnSchema to one

2019-07-24 Thread GitBox
imay opened a new pull request #1545: Unify ColumnSchemaV2 and ColumnSchema to one URL: https://github.com/apache/incubator-doris/pull/1545 Currently, we have two versions of ColumnSchema, in this patch, we unify these two classes to one class. --

[GitHub] [incubator-doris] chaoyli merged pull request #1541: Fix miss delete predicate when clone

2019-07-24 Thread GitBox
chaoyli merged pull request #1541: Fix miss delete predicate when clone URL: https://github.com/apache/incubator-doris/pull/1541 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1541: Fix miss delete predicate when clone

2019-07-24 Thread GitBox
kangpinghuang commented on a change in pull request #1541: Fix miss delete predicate when clone URL: https://github.com/apache/incubator-doris/pull/1541#discussion_r307077860 ## File path: be/src/olap/rowset/alpha_rowset_writer.cpp ## @@ -116,6 +114,10 @@ OLAPStatus AlphaR

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1541: Fix miss delete predicate when clone

2019-07-24 Thread GitBox
kangpinghuang commented on a change in pull request #1541: Fix miss delete predicate when clone URL: https://github.com/apache/incubator-doris/pull/1541#discussion_r307077860 ## File path: be/src/olap/rowset/alpha_rowset_writer.cpp ## @@ -116,6 +114,10 @@ OLAPStatus AlphaR

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1541: Fix miss delete predicate when clone

2019-07-24 Thread GitBox
kangpinghuang commented on a change in pull request #1541: Fix miss delete predicate when clone URL: https://github.com/apache/incubator-doris/pull/1541#discussion_r307077574 ## File path: be/src/olap/rowset/alpha_rowset_writer.cpp ## @@ -116,6 +114,10 @@ OLAPStatus AlphaR

[GitHub] [incubator-doris] imay commented on a change in pull request #1544: Fix bug that getting compatible type for TIME with other types fails

2019-07-24 Thread GitBox
imay commented on a change in pull request #1544: Fix bug that getting compatible type for TIME with other types fails URL: https://github.com/apache/incubator-doris/pull/1544#discussion_r306838777 ## File path: fe/src/main/java/org/apache/doris/catalog/Type.java ## @@ -82

[GitHub] [incubator-doris] imay merged pull request #1543: Fix the null pointer exception when ReplayOnAborted of txn in broker load

2019-07-24 Thread GitBox
imay merged pull request #1543: Fix the null pointer exception when ReplayOnAborted of txn in broker load URL: https://github.com/apache/incubator-doris/pull/1543 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] chenhao7253886 opened a new pull request #1544: Fix bug that getting compatible type for TIME with other types fails

2019-07-24 Thread GitBox
chenhao7253886 opened a new pull request #1544: Fix bug that getting compatible type for TIME with other types fails URL: https://github.com/apache/incubator-doris/pull/1544 This is an automated message from the Apache Git S

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #1543: Fix the null pointer exception when ReplayOnAborted of txn in broker load

2019-07-24 Thread GitBox
EmmyMiao87 opened a new pull request #1543: Fix the null pointer exception when ReplayOnAborted of txn in broker load URL: https://github.com/apache/incubator-doris/pull/1543 The txn attachment maybe null when broker load has been cancelled without attachment. The end log of broker load

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #1541: Fix miss delete predicate when clone

2019-07-24 Thread GitBox
chaoyli commented on a change in pull request #1541: Fix miss delete predicate when clone URL: https://github.com/apache/incubator-doris/pull/1541#discussion_r306766377 ## File path: be/src/olap/rowset/alpha_rowset_writer.cpp ## @@ -116,6 +114,10 @@ OLAPStatus AlphaRowsetW

[GitHub] [incubator-doris] imay merged pull request #1540: Remove unused FieldInfo

2019-07-24 Thread GitBox
imay merged pull request #1540: Remove unused FieldInfo URL: https://github.com/apache/incubator-doris/pull/1540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-doris] zhangy5 opened a new issue #1542: Session variable enable_insert_strict doesn't work in fe follower

2019-07-24 Thread GitBox
zhangy5 opened a new issue #1542: Session variable enable_insert_strict doesn't work in fe follower URL: https://github.com/apache/incubator-doris/issues/1542 **Describe the bug** When I connect to fe master, set enable_insert_strict and the result is like ![master](https://user-ima

[GitHub] [incubator-doris] kangpinghuang opened a new pull request #1541: Fix miss delete predicate when clone

2019-07-24 Thread GitBox
kangpinghuang opened a new pull request #1541: Fix miss delete predicate when clone URL: https://github.com/apache/incubator-doris/pull/1541 related issue #1539 This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-doris] imay opened a new pull request #1540: Remove unused FieldInfo

2019-07-24 Thread GitBox
imay opened a new pull request #1540: Remove unused FieldInfo URL: https://github.com/apache/incubator-doris/pull/1540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-doris] kangpinghuang opened a new issue #1539: delete predicate property is missed when clone from remote

2019-07-24 Thread GitBox
kangpinghuang opened a new issue #1539: delete predicate property is missed when clone from remote URL: https://github.com/apache/incubator-doris/issues/1539 Now, when Tablet clone from remote be, the delete predicate property is missed when create new rowset in local. The reason is AlphaR

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #1409: Add dict page

2019-07-24 Thread GitBox
kangpinghuang commented on a change in pull request #1409: Add dict page URL: https://github.com/apache/incubator-doris/pull/1409#discussion_r306682489 ## File path: be/src/olap/rowset/segment_v2/encoding_info.h ## @@ -22,18 +22,16 @@ #include "common/status.h" #include "

[GitHub] [incubator-doris] imay merged pull request #1538: FixBug: Load fail when we don't specify format type.

2019-07-24 Thread GitBox
imay merged pull request #1538: FixBug: Load fail when we don't specify format type. URL: https://github.com/apache/incubator-doris/pull/1538 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-doris] imay closed pull request #1474: Add segment iterator

2019-07-24 Thread GitBox
imay closed pull request #1474: Add segment iterator URL: https://github.com/apache/incubator-doris/pull/1474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us