kangpinghuang commented on a change in pull request #1541: Fix miss delete predicate when clone URL: https://github.com/apache/incubator-doris/pull/1541#discussion_r307077574
########## File path: be/src/olap/rowset/alpha_rowset_writer.cpp ########## @@ -116,6 +114,10 @@ OLAPStatus AlphaRowsetWriter::add_rowset(RowsetSharedPtr rowset) { RETURN_NOT_OK(flush()); _num_rows_written += segment_group->num_rows(); } + // process delete predicate + if (rowset->rowset_meta()->has_delete_predicate()) { + _current_rowset_meta->set_delete_predicate(rowset->rowset_meta()->delete_predicate()); Review comment: delete predicate is not a list or a array. I think set is better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org