On 2/18/15 7:43 AM, Thomas Neidhart wrote:
> Sorry it was my mistake, I did not test the change with Java 8.
>
> The pom.xml is now fixed, I used the same override for jacoco as was used
> for commons-math 3.4
Thanks!
Phil
>
> Thomas
>
> On Wed, Feb 18, 2015 at 3:24 PM, Thomas Neidhart
> wrote:
Sorry it was my mistake, I did not test the change with Java 8.
The pom.xml is now fixed, I used the same override for jacoco as was used
for commons-math 3.4
Thomas
On Wed, Feb 18, 2015 at 3:24 PM, Thomas Neidhart
wrote:
> I enabled jacoco a while a go, but if you would prefer cobertura we ca
I enabled jacoco a while a go, but if you would prefer cobertura we can
easily change to it.
Thomas
On Wed, Feb 18, 2015 at 2:54 PM, Phil Steitz wrote:
> On 2/18/15 6:52 AM, Emmanuel Bourg wrote:
> > Le 18/02/2015 14:48, Phil Steitz a écrit :
> >
> >> That is not good. What JDK and OS?
> > Tha
Le 18/02/2015 14:47, Phil Steitz a écrit :
> Good point. If you or others feel strongly that this is too ugly, I
> can change and re-roll.
>
> Any other opinions on this?
>
> Thanks for the review!
On the same line I wonder if the isFastFailValidation() method would be
better named isFailFastV
Due to problems with JDK 8 build...
On 2/16/15 9:04 PM, Phil Steitz wrote:
> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added. It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbc
On 2/18/15 6:52 AM, Emmanuel Bourg wrote:
> Le 18/02/2015 14:48, Phil Steitz a écrit :
>
>> That is not good. What JDK and OS?
> That was with OpenJDK 8u40b22 on Debian Jessie.
Thanks. I was just able to replicate. I need to get rid of the
jacoco nonsense somehow. Will fix and reroll.
Phil
>
Le 18/02/2015 14:48, Phil Steitz a écrit :
> That is not good. What JDK and OS?
That was with OpenJDK 8u40b22 on Debian Jessie.
Emmanuel Bourg
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional comman
On 2/18/15 5:05 AM, Emmanuel Bourg wrote:
> Le 17/02/2015 16:50, Phil Steitz a écrit :
>
>> That is just the site build, which is not essential to the release,
>> IMO, so again not a blocker.
> Not only the site build, I got the same error with a simple 'mvn test'.
That is not good. What JDK and
On 2/18/15 6:30 AM, Emmanuel Bourg wrote:
>> [X] +1 Release these artifacts
> Tested with OpenJDK 7 on Debian.
>
> The name of the isLogExpiredConnections() method in BasicDataSource and
> BasicDataSourceMXBean looks a bit inconsistent with the other methods
> returning a boolean. I would have pick
On 2/18/15 3:08 AM, Thomas Neidhart wrote:
> hmm, I do not know what I have seen yesterday, but the references to dbcp
> 2.x and pool 2.3 are already correct.
Thanks. That was driving me crazy. Could be some funny svn mirror
lag or something if you were hitting them from the web page instead
of l
> [X] +1 Release these artifacts
Tested with OpenJDK 7 on Debian.
The name of the isLogExpiredConnections() method in BasicDataSource and
BasicDataSourceMXBean looks a bit inconsistent with the other methods
returning a boolean. I would have picked getLogExpiredConnections
(similar to the getRemo
Le 17/02/2015 16:50, Phil Steitz a écrit :
> That is just the site build, which is not essential to the release,
> IMO, so again not a blocker.
Not only the site build, I got the same error with a simple 'mvn test'.
Emmanuel Bourg
---
hmm, I do not know what I have seen yesterday, but the references to dbcp
2.x and pool 2.3 are already correct.
I have updated the other 2 examples to use an h2 database as already
outlined in the PoolingDataSourceExample.
Thomas
On Wed, Feb 18, 2015 at 1:13 AM, Phil Steitz wrote:
> On 2/17/15
On 2/17/15 2:29 PM, Thomas Neidhart wrote:
> On 02/17/2015 05:04 AM, Phil Steitz wrote:
>> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
>> features have been added. It is time for a 2.1 release.
>>
>> The release is available for review here:
>> https://dist.apache.org/repos/dis
On 02/17/2015 05:04 AM, Phil Steitz wrote:
> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added. It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>
> The release was b
On 2/17/15 1:59 PM, Oliver Heger wrote:
> Build (both Maven and ant) was successful on Windows 8.1 with JDK 1.7.
> Artifacts and site look good.
>
> So here is my +1.
>
> Minor nit: On the site there is currently no entry for the Javadocs of
> the new release. I guess it will be added after the rel
Build (both Maven and ant) was successful on Windows 8.1 with JDK 1.7.
Artifacts and site look good.
So here is my +1.
Minor nit: On the site there is currently no entry for the Javadocs of
the new release. I guess it will be added after the release?
Oliver
My exact configuration:
$ mvn -versio
the release,
IMO, so again not a blocker.
Thanks for reviewing!
Phil
>
> From: Phil Steitz
> To: Commons Developers List
> Sent: Tuesday, February 17, 2015 2:04 AM
> Subject: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1
>
> Quite a few bugs have been fixed
Here is my +1
Phil
On 2/16/15 9:04 PM, Phil Steitz wrote:
> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
> features have been added. It is time for a 2.1 release.
>
> The release is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
>
> Th
t binding
Bruno
[1]
http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/c228a234a3f3/src/share/classes/java/sql/Connection.java[2]
http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/9b8c96f96a0f/src/share/classes/java/sql/Connection.java
From: Phil Steitz
To: Commons Developers List
Sent: Tues
For completeness, here are the main Nexus hashes:
/org/apache/commons/commons-dbcp2/2.1/commons-dbcp2-2.1-tests.jar
(SHA1: f4463d624c494746aa01f009f0886012f9601710)
/org/apache/commons/commons-dbcp2/2.1/commons-dbcp2-2.1-sources.jar
(SHA1: 305da0aa5f560ab4c8e3bee855582829c51fb744)
/org/apache/comm
Quite a few bugs have been fixed since DBCP 2.0.1 and a few new
features have been added. It is time for a 2.1 release.
The release is available for review here:
https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031)
The release was built from this tag:
http://svn.apache.org/viewvc/commons/
22 matches
Mail list logo
