Hi Phil, Builds fine with Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T15:37:52-03:00)Maven home: /opt/apache-maven-3.2.1Java version: 1.7.0_65, vendor: Oracle CorporationJava home: /opt/jdk1.7.0_65/jreDefault locale: en_US, platform encoding: UTF-8OS name: "linux", version: "3.16.0-30-generic", arch: "amd64", family: "unix" All tests passed. Comparing with http://commons.apache.org/proper/commons-dbcp/findbugs.html, looks like there is a new FindBugs bug: > org.apache.commons.dbcp2.DelegatingConnection.prepareStatement(String) may > return null, but is declared @NonNull
I had a look at the JDK source code at [1] and [2] but couldn't find a @NotNull annotation anywhere. Do you think it would be an issue? BTW, I couldn't build the project with JDK8 kinow@chuva:~/Desktop/dbcp/source/commons-dbcp2-2.1-src$ mvn clean site -e -XApache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T15:37:52-03:00)Maven home: /opt/apache-maven-3.2.1Java version: 1.8.0_05, vendor: Oracle CorporationJava home: /opt/jdk1.8.0_05/jreDefault locale: en_US, platform encoding: UTF-8OS name: "linux", version: "3.16.0-30-generic", arch: "i386", family: "unix" I think it fails during the JaCoCo report generation https://gist.github.com/kinow/98851033c3c006154b92, but I haven't investigated the issue and I believe it's not a blocker. +1 not binding Bruno [1] http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/c228a234a3f3/src/share/classes/java/sql/Connection.java[2] http://hg.openjdk.java.net/jdk7/jdk7/jdk/file/9b8c96f96a0f/src/share/classes/java/sql/Connection.java From: Phil Steitz <phil.ste...@gmail.com> To: Commons Developers List <dev@commons.apache.org> Sent: Tuesday, February 17, 2015 2:04 AM Subject: [VOTE] Release Apache Commons DBCP 2.1 RC1 as 2.1 Quite a few bugs have been fixed since DBCP 2.0.1 and a few new features have been added. It is time for a 2.1 release. The release is available for review here: https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031) The release was built from this tag: http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1 (r1660242) Release notes: https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt Maven artifacts: https://repository.apache.org/content/repositories/orgapachecommons-1082 Site: http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/ KEYS: http://www.apache.org/dist/commons/KEYS Votes, please. This vote will close no sooner than 72 hours from now. [ ] +1 Release these artifacts [ ] +0 OK, but... [ ] -0 OK, but really should fix... [ ] -1 I oppose this release because... Thanks! Phil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
