Thanks, for the reminder. I was just about to tag the release when I saw
your mail. I've applied those fixes as well.
2015-01-01 17:01 GMT+01:00 sebb :
> Hold on - there were two other check digit patches mentioned earlier
> in the thread:
>
> https://issues.apache.org/jira/browse/VALIDATOR-345 -
Hold on - there were two other check digit patches mentioned earlier
in the thread:
https://issues.apache.org/jira/browse/VALIDATOR-345 - ISIN
https://issues.apache.org/jira/browse/VALIDATOR-346 - SEDOL
Once these are done, AbstractCheckDigitTestCase can be updated to use
a wider range of invalid
I have applied the fix with slight changes (an additional test and some
variable renaming in the test). I'm going to cut RC2 now.
2014-12-31 18:07 GMT+01:00 Benedikt Ritter :
> Oh sorry, I tought you already committed the fix. I'll review and commit
> it tomorrow.
>
> Benedikt
>
> Send from my mo
Oh sorry, I tought you already committed the fix. I'll review and commit it
tomorrow.
Benedikt
Send from my mobile device
> Am 31.12.2014 um 16:17 schrieb sebb :
>
>> On 31 December 2014 at 15:09, Benedikt Ritter wrote:
>> Hi,
>>
>> thanks for the fix Sebb! I'm going to cut RC2 tomorrow.
>
On 31 December 2014 at 15:09, Benedikt Ritter wrote:
> Hi,
>
> thanks for the fix Sebb! I'm going to cut RC2 tomorrow.
Fine, but please can we apply the check digit fixes first?
I had a look through the other outstanding issues, and I think any
others will take a bit of effort to solve.
None of
Hi,
thanks for the fix Sebb! I'm going to cut RC2 tomorrow.
Regards,
Benedikt
2014-12-31 15:45 GMT+01:00 sebb :
> The fixes I made for the CheckDigit validation errors are pretty
> simple, and I could just add them.
> However it would be nice if someone could review them:
>
> https://issues.apa
The fixes I made for the CheckDigit validation errors are pretty
simple, and I could just add them.
However it would be nice if someone could review them:
https://issues.apache.org/jira/browse/VALIDATOR-336 - CUSIP
https://issues.apache.org/jira/browse/VALIDATOR-345 - ISIN
https://issues.apache.or
I'm not sure when the RM plans to cut another release but this seems like a
good idea to me. It looks like you've already fixed that up too!
Gary
On Tue, Dec 30, 2014 at 8:13 AM, sebb wrote:
> I started working on a fix for
> https://issues.apache.org/jira/browse/VALIDATOR-336
>
> CUSIPCheckDig
I started working on a fix for
https://issues.apache.org/jira/browse/VALIDATOR-336
CUSIPCheckDigit Thinks Invalid CUSIP is Valid
I think the code fix is quite simple, however it has not been so easy
to fix the tests, as they don't really allow for two kinds of validity
(syntax error and invalid c
