Hi, thanks for the fix Sebb! I'm going to cut RC2 tomorrow.
Regards, Benedikt 2014-12-31 15:45 GMT+01:00 sebb <seb...@gmail.com>: > The fixes I made for the CheckDigit validation errors are pretty > simple, and I could just add them. > However it would be nice if someone could review them: > > https://issues.apache.org/jira/browse/VALIDATOR-336 - CUSIP > https://issues.apache.org/jira/browse/VALIDATOR-345 - ISIN > https://issues.apache.org/jira/browse/VALIDATOR-346 - SEDOL > > Once these are done, AbstractCheckDigitTestCase can be updated to use > a wider range of invalid check digits > > > On 31 December 2014 at 14:31, Gary Gregory <garydgreg...@gmail.com> wrote: > > I'm not sure when the RM plans to cut another release but this seems > like a > > good idea to me. It looks like you've already fixed that up too! > > > > Gary > > > > On Tue, Dec 30, 2014 at 8:13 AM, sebb <seb...@gmail.com> wrote: > > > >> I started working on a fix for > >> https://issues.apache.org/jira/browse/VALIDATOR-336 > >> > >> CUSIPCheckDigit Thinks Invalid CUSIP is Valid > >> > >> I think the code fix is quite simple, however it has not been so easy > >> to fix the tests, as they don't really allow for two kinds of validity > >> (syntax error and invalid check digit) > >> > >> I hope this can go into the next release? > >> > >> I will attach my current patches to the issue shortly > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > > -- > > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > > Java Persistence with Hibernate, Second Edition > > <http://www.manning.com/bauer3/> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > > Spring Batch in Action <http://www.manning.com/templier/> > > Blog: http://garygregory.wordpress.com > > Home: http://garygregory.com/ > > Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
