Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

> Am 06.06.2017 um 14:00 schrieb Rob Tompkins : > > > >> On Jun 6, 2017, at 7:48 AM, Benedikt Ritter wrote: >> >> Hi Rob, >> >>> Am 05.06.2017 um 15:50 schrieb Rob Tompkins : >>> >>> On Jun 5, 2017, at 4:34 AM, Benedikt Ritter wrote: Hi, > Am 03.06.2017 um 18:54

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

> On Jun 6, 2017, at 7:48 AM, Benedikt Ritter wrote: > > Hi Rob, > >> Am 05.06.2017 um 15:50 schrieb Rob Tompkins : >> >> >>> On Jun 5, 2017, at 4:34 AM, Benedikt Ritter wrote: >>> >>> Hi, >>> Am 03.06.2017 um 18:54 schrieb Rob Tompkins >>> >: Th

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Hi Rob, > Am 05.06.2017 um 15:50 schrieb Rob Tompkins : > > >> On Jun 5, 2017, at 4:34 AM, Benedikt Ritter wrote: >> >> Hi, >> >>> Am 03.06.2017 um 18:54 schrieb Rob Tompkins >> >: >>> >>> This should be done now with the entries being “commons.module.name” >> >>

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

> On Jun 5, 2017, at 4:34 AM, Benedikt Ritter wrote: > > Hi, > >> Am 03.06.2017 um 18:54 schrieb Rob Tompkins > >: >> >> This should be done now with the entries being “commons.module.name” > > I’d recommend using dashes in the second part of the name, since my > u

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

On 5 June 2017 at 09:35, Benedikt Ritter wrote: > Is there some documentation on how to check validity? I'm sure there is info in various places, but I've not seen a checklist. Off the top of my head: - all packages under a single super-package that is the module name - jdeps shows no use of int

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Hello Stephen, > Am 24.05.2017 um 17:11 schrieb Stephen Colebourne : > > On 24 May 2017 at 15:55, Rob Tompkins wrote: >> We should simply add that entry, "commons.automatic-module-name," to every >> component pom’s properties section now, and then when the next parent >> migration happens, the

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Hi, > Am 03.06.2017 um 18:54 schrieb Rob Tompkins : > > This should be done now with the entries being “commons.module.name” I’d recommend using dashes in the second part of the name, since my understanding of points is to declare name spaces. So I’d suggest to use commons.automatic-module-nam

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

This should be done now with the entries being “commons.module.name” Cheers, -Rob > On May 24, 2017, at 11:31 AM, Rob Tompkins wrote: > > >> On May 24, 2017, at 11:11 AM, Stephen Colebourne >> wrote: >> >> On 24 May 2017 at 15:55, Rob Tompkins wrote: >>> We should simply add that entry, "c

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

> On May 24, 2017, at 11:11 AM, Stephen Colebourne wrote: > > On 24 May 2017 at 15:55, Rob Tompkins wrote: >> We should simply add that entry, "commons.automatic-module-name," to every >> component pom’s properties section now, and then when the next parent >> migration happens, the changes w

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

On 24 May 2017 at 15:55, Rob Tompkins wrote: > We should simply add that entry, "commons.automatic-module-name," to every > component pom’s properties section now, and then when the next parent > migration happens, the changes will express naturally. It might be worth > adding a comment on the

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

> On May 23, 2017, at 7:26 PM, Benedikt Ritter wrote: > > Hi, > >> Am 22.05.2017 um 09:19 schrieb sebb : >> >> On 22 May 2017 at 13:14, Rob Tompkins > > wrote: >>> On May 22, 2017, at 8:10 AM, Stephen Colebourne wrote: On 22 May 2017 at 12:51,

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Le 24/05/2017 à 01:26, Benedikt Ritter a écrit : > Please no more profile activation based on files being present. This is just > confusing and a dirty hack IMHO. Or maybe a profile activated by the presence of module-info.java? Emmanuel Bourg -

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Hi, > Am 22.05.2017 um 09:19 schrieb sebb : > > On 22 May 2017 at 13:14, Rob Tompkins > wrote: >> >>> On May 22, 2017, at 8:10 AM, Stephen Colebourne >>> wrote: >>> >>> On 22 May 2017 at 12:51, Rob Tompkins wrote: You could, in the parent, declare in the prop

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

On 22 May 2017 at 13:14, Rob Tompkins wrote: > >> On May 22, 2017, at 8:10 AM, Stephen Colebourne wrote: >> >> On 22 May 2017 at 12:51, Rob Tompkins wrote: >>> You could, in the parent, declare in the properties section beside the >>> declaration of “commons.osgi.symbolicName”, another property

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

> On May 22, 2017, at 8:10 AM, Stephen Colebourne wrote: > > On 22 May 2017 at 12:51, Rob Tompkins wrote: >> You could, in the parent, declare in the properties section beside the >> declaration of “commons.osgi.symbolicName”, another property pointing to >> that as >> >> ${commons.osgi.symb

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

On 22 May 2017 at 12:51, Rob Tompkins wrote: > You could, in the parent, declare in the properties section beside the > declaration of “commons.osgi.symbolicName”, another property pointing to that > as > > ${commons.osgi.symbolicName} > > and then allow people to override that in their local po

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

> On May 21, 2017, at 7:32 PM, Benedikt Ritter wrote: > > Hello again, > >> Am 21.05.2017 um 10:50 schrieb Benedikt Ritter : >> >> Hello Stephen, >> >>> Am 19.05.2017 um 04:52 schrieb Stephen Colebourne >> >: >>> >>> Is reusing ${commons.osgi.symbolicName} a good

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

On 22 May 2017 at 00:32, Benedikt Ritter wrote: > This is not as straight forward as I thought. Simply adding > > ${commons.automatic-module-name} > > Does not work, since this will add an empty entry to the resulting manifest > file, if a component does not specify the commons.automatic-module-n

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Hello again, > Am 21.05.2017 um 10:50 schrieb Benedikt Ritter : > > Hello Stephen, > >> Am 19.05.2017 um 04:52 schrieb Stephen Colebourne > >: >> >> Is reusing ${commons.osgi.symbolicName} a good idea? > > I thought it is, because this way we will automatically hav

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Hello Stephen, > Am 19.05.2017 um 04:52 schrieb Stephen Colebourne : > > Is reusing ${commons.osgi.symbolicName} a good idea? I thought it is, because this way we will automatically have the additional entry after we update a component to the new parent pom version. :o) > It seems to me that e

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Is reusing ${commons.osgi.symbolicName} a good idea? It seems to me that each project should have to opt-in to this attribute, so I'd add a new ${commons.automatic.moduile.name} variable. One reason is that the attribute should only be added if the project is suitable for use as a module (eg. no p

Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

On May 18, 2017 12:09 PM, "Benedikt Ritter" wrote: Hi, here is my proposal on how to get the Automatic-Module-Name entry into our MANIFEST files. This change has to be made only in commons parent. This is the change: Index: pom.xml ===

[PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry

Hi, here is my proposal on how to get the Automatic-Module-Name entry into our MANIFEST files. This change has to be made only in commons parent. This is the change: Index: pom.xml === --- pom.xml (revision 1795551) +++ pom.xml