Re: [compress] Importance of retaining exact compatibility for ZipArchiveOutputStream ?

2015-01-02 Thread Stefan Bodewig
On 2015-01-02, Kristian Rosenvold wrote: > All fixed :) Thanks a lot! Stefan - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r1648704 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ test/java/org/apache/commons/compress/archivers/zip/

2015-01-02 Thread Stefan Bodewig
On 2015-01-02, Kristian Rosenvold wrote: > 2015-01-02 16:22 GMT+01:00 Stefan Bodewig : >> On 2014-12-31, wrote: > ... all else fixed in r1649128.. I thought you'd need a way to override the ScatterGatherBackingStoreSupplier from Plexus, maybe I was wrong. I'll need to look at your Plexus chan

Re: [CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread sebb
I've made quite a bit of progress. However the IANA text file merges all the TLDs into one file - there is no indication of whether the TLD is a country code or not. This does not matter for ASCII codes, because they are easy to recognise. Unfortunately it looks as though the only way to distingui

Re: Committing Code, JIRA Gardening

2015-01-02 Thread Carl Hall
Thanks, Benedikt and Mark. I have made my first commit (woo!) and will start working through JIRA to clear out the easy stuff. Is there any rule (by writ or general practice) for closing tickets that haven't seen any action in some time? Seems like old tickets that haven't moved in a while (e.g.

Re: Committing Code, JIRA Gardening

2015-01-02 Thread Carl Hall
Thanks, Benedikt and Mark. I have made my first commit (woo!) and will start working through JIRA to clear out the easy stuff. Is there any rule (by writ or general practice) for closing tickets that haven't seen any action in some time? Seems like old tickets that haven't moved in a while (e.g.

Re: [compress] Importance of retaining exact compatibility for ZipArchiveOutputStream ?

2015-01-02 Thread Kristian Rosenvold
All fixed :) I also gave up on the ParallelScatterZipCreator#createDeferred and followed your suggestion. Kristian 2015-01-02 16:17 GMT+01:00 Stefan Bodewig : > Re backwards compatibility: ZipArchiveOutputStream's deflate method has > been protected and now has gone. > > On 2014-12-31, Kristian

[math][dbcp][pool] Apachecon NA (Austin)

2015-01-02 Thread Phil Steitz
I am thinking about submitting a proposal or two for Austin. I could update / extend the pool/dbcp talk I did last year or try a [math] talk. I would love to have company developing and / or presenting either of these. Is anyone else interested in working on a talk on either of these? Any sugge

Re: svn commit: r1648704 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ test/java/org/apache/commons/compress/archivers/zip/

2015-01-02 Thread Kristian Rosenvold
2015-01-02 16:22 GMT+01:00 Stefan Bodewig : > On 2014-12-31, wrote: > ... all else fixed in r1649128.. >>static ScatterZipOutputStream >> createDeferred(ScatterGatherBackingStoreSupplier >> scatterGatherBackingStoreSupplier) > > would then be an instance method. Do you need it to be publi

Re: [imaging] Snapshot versions > commons-imaging-1.0-20141227.232306-24 cause compilation error

2015-01-02 Thread Benedikt Ritter
Hello Jordan, The reason you got the compilation errors in the first place was, because I've renamed the IImageMetadata and IImageMetadataItem to ImageMetadata and ImageMetadataItem (I dropped the "I" prefix). It seems that your project now references the latest snapshot which has this changes. Bu

RE: [imaging] Snapshot versions > commons-imaging-1.0-20141227.232306-24 cause compilation error

2015-01-02 Thread Black, Jordan
I pulled the latest from git (https://github.com/apache/commons-imaging), built it, and that works. Is there a process or any plans to create a process for determining when a snapshot gets deployed to the apache repo? Or should I plan to build it locally and deploy to my local shared repositor

Re: [digester] Should popping the last object off the stack update the root?

2015-01-02 Thread Benedikt Ritter
2015-01-02 21:29 GMT+01:00 Barney : > Thanks Benedikt, I'll put a patch together and submit a JIRA. > > The main reason I didn't do that the first time was I wasn't sure if this > idea had already been considered and rejected for some reason, so I thought > I'd just check here first. TBH there h

[ALL] Copy Paste error in the src assembly descriptor of some (all?) projects

2015-01-02 Thread Benedikt Ritter
Hi all, I've just noticed that there is an error in some of our src assembly descriptors, which seems to have found it's way into several of our components. I have only checked compress, lang, imaging and io but they all have the same error. Take for example [lang]. In src/main/assembly/src.xml we

Re: [digester] Should popping the last object off the stack update the root?

2015-01-02 Thread Barney
Thanks Benedikt, I'll put a patch together and submit a JIRA. The main reason I didn't do that the first time was I wasn't sure if this idea had already been considered and rejected for some reason, so I thought I'd just check here first. Cheers,

Re: [digester] Should popping the last object off the stack update the root?

2015-01-02 Thread Benedikt Ritter
Hello Barney, thanks for the report. The normal way for contributing code is by attaching a patch to jira [1]. Don't forget to include some unit tests ;-) TIA! Benedikt [1] https://issues.apache.org/jira 2015-01-02 12:26 GMT+01:00 Barney : > Hi, > > There seems to me to be a bit of a discrepan

Re: svn commit: r1648982 - in /commons/proper/commons-build-plugin/trunk: ./ src/changes/ src/main/resources/commons-xdoc-templates/ src/main/scripts/

2015-01-02 Thread Benedikt Ritter
Done, thanks for the suggestion. 2015-01-02 12:45 GMT+01:00 sebb : > On 2 January 2015 at 09:18, wrote: > > Author: britter > > Date: Fri Jan 2 09:18:37 2015 > > New Revision: 1648982 > > > > URL: http://svn.apache.org/r1648982 > > Log: > > COMMONSSITE-81: commons-build-plugin README/CONTRIBUT

Re: Release Plugin (was Re: [All] Moving to git)

2015-01-02 Thread Torsten Curdt
On Wed, Dec 31, 2014 at 11:34 AM, Stefan Bodewig wrote: > On 2014-12-31, Jochen Wiedmann wrote: > > > On Mon, Dec 29, 2014 at 3:16 PM, Stefan Bodewig > wrote: > > >> Just as a "letter of intent" - I'd prefer to cut Compress 1.10 while > >> we're still in svn (as I know how to do it, I'm in the "

Re: [imaging] Snapshot versions > commons-imaging-1.0-20141227.232306-24 cause compilation error

2015-01-02 Thread Gary Gregory
I would use the latest code from SVN and built it locally to get the latest and greatest. SNAPSHOTs might be published more or less randomly. Gary On Fri, Jan 2, 2015 at 12:25 PM, Black, Jordan wrote: > Hello, > > My project's compilation is now failing after a new snapshot of > commons-imaging

[imaging] Snapshot versions > commons-imaging-1.0-20141227.232306-24 cause compilation error

2015-01-02 Thread Black, Jordan
Hello, My project's compilation is now failing after a new snapshot of commons-imaging was published. On December 28, it succeeded using http://repository.apache.org/snapshots/org/apache/commons/commons-imaging/1.0-SNAPSHOT/commons-imaging-1.0-20141227.232306-24.jar and on December 29, it fail

[imaging] Snapshot versions > commons-imaging-1.0-20141227.232306-24 cause compilation error

2015-01-02 Thread Black, Jordan
Hello, My project's compilation is now failing after a new snapshot of commons-imaging was published. On December 28, it succeeded using http://repository.apache.org/snapshots/org/apache/commons/commons-imaging/1.0-SNAPSHOT/commons-imaging-1.0-20141227.232306-24.jar and on December 29, it fail

Re: svn commit: r1649038 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java

2015-01-02 Thread sebb
On 2 January 2015 at 15:07, Adrian Crum wrote: > Thank you for fixing that. I had my IDE set for Java 1.4 but somehow it let > me use that method anyway. That setting only applies to the source and binary format. It will complain about generics etc. but not library additions. In order to check f

Re: svn commit: r1648704 - in /commons/proper/compress/trunk/src: main/java/org/apache/commons/compress/archivers/zip/ test/java/org/apache/commons/compress/archivers/zip/

2015-01-02 Thread Stefan Bodewig
On 2014-12-31, wrote: >static ScatterGatherBackingStoreSupplier defaultSupplier = new > DefaultSupplier(); This one could be instance variable (and made final when set in the constructor). I think this would be a cleaner approach to overriding the supplier that setting a static variable.

Re: [compress] Importance of retaining exact compatibility for ZipArchiveOutputStream ?

2015-01-02 Thread Stefan Bodewig
Re backwards compatibility: ZipArchiveOutputStream's deflate method has been protected and now has gone. On 2014-12-31, Kristian Rosenvold wrote: > On a related note, I just added the *last* substantial change I intend > to do. I will do a tweak or two, and I'm sure that last class will > trigger

Re: svn commit: r1649038 - /commons/proper/validator/trunk/src/main/java/org/apache/commons/validator/routines/InetAddressValidator.java

2015-01-02 Thread Adrian Crum
Thank you for fixing that. I had my IDE set for Java 1.4 but somehow it let me use that method anyway. Adrian Crum Sandglass Software www.sandglass-software.com On 1/2/2015 6:17 AM, s...@apache.org wrote: Author: sebb Date: Fri Jan 2 14:17:48 2015 New Revision: 1649038 URL: http://svn.apache

[CANCEL][VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread Benedikt Ritter
Hi, this vote in canceled to fix the problems discovered by sebb. I will waint until the XN-- entries are added before I roll out a new RC. Thanks! Benedikt 2015-01-01 19:02 GMT+01:00 Benedikt Ritter : > Hi all, > > we have fixed the issues which where found in RC1 so I'd like to call a > new v

Re: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Test if can build / test with Java 1.4)

2015-01-02 Thread sebb
Probably Java 1.4 is not installed or the symbol is not set up. So Maven cannot find the compiler. On 2 January 2015 at 14:03, Gary Gregory wrote: > The build page says "Compilation failure" in the console output but not > what the failure is! Uh? > > Gary > > -- Forwarded message ---

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread sebb
-1 Definitely need to respin the release. I've just discovered that InetAddressValidator.isValidInet4Address calls String.isEmpty() which is Java 1.6+ Need to do more checks on Java 1.4 compatibility; there may be other such issues. Note: I am looking at adding XN-- entries to the TLD list sho

Fwd: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Test if can build / test with Java 1.4)

2015-01-02 Thread Gary Gregory
The build page says "Compilation failure" in the console output but not what the failure is! Uh? Gary -- Forwarded message -- From: Apache Continuum Date: Fri, Jan 2, 2015 at 8:59 AM Subject: [continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Test if can build

[continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Test if can build / test with Java 1.5)

2015-01-02 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=39080&projectId=106 Build statistics: State: Failed Previous State: Failed Started at: Fri 2 Jan 2015 14:01:07 + Finished at: Fri 2 Jan 2015 14:01:18 + Total time: 11s Build Trigger: Forced

[continuum] BUILD FAILURE: Apache Commons Validator - Apache Commons (Test if can build / test with Java 1.4)

2015-01-02 Thread Apache Continuum
Online report : https://continuum-ci.apache.org/continuum/buildResult.action?buildId=39079&projectId=106 Build statistics: State: Failed Previous Build: No previous build. Started at: Fri 2 Jan 2015 13:59:27 + Finished at: Fri 2 Jan 2015 13:59:36 + Total time: 8s Build Trigger

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread Gary Gregory
IMO we should fix this now for 1.4.1, isn't the fix already in trunk? We can then update to Java 5 for a 1.5 release. Gary On Fri, Jan 2, 2015 at 3:44 AM, Benedikt Ritter wrote: > Hm, not sure how serious this is. Let's see what others think. My feeling > is that we can fix that in 1.4.2 or 1.5

Re: svn commit: r1648982 - in /commons/proper/commons-build-plugin/trunk: ./ src/changes/ src/main/resources/commons-xdoc-templates/ src/main/scripts/

2015-01-02 Thread sebb
On 2 January 2015 at 09:18, wrote: > Author: britter > Date: Fri Jan 2 09:18:37 2015 > New Revision: 1648982 > > URL: http://svn.apache.org/r1648982 > Log: > COMMONSSITE-81: commons-build-plugin README/CONTRIBUTING.md handle > multi-modules. Fix implemented by Bernd Eckenfels. > > Modified: >

[digester] Should popping the last object off the stack update the root?

2015-01-02 Thread Barney
Hi, There seems to me to be a bit of a discrepancy between the way push() and pop() interact with the root object when stack actions are used to change the object. * If a stack action changes the root object when being pushed onto the stack then the root reference is set to the changed objec

Re: Committing Code, JIRA Gardening

2015-01-02 Thread Mark Thomas
On 02/01/2015 08:50, Benedikt Ritter wrote: > ... so the current process is to request the karma > just like you did. I think Mark Thomas or sebb can grant you the karma. > Shouldn't take long. Done. Mark - To unsubscribe,

Re: [site][build-plugin] Keys link link on download page

2015-01-02 Thread Benedikt Ritter
Hello Bernd 2015-01-02 10:04 GMT+01:00 Benedikt Ritter : > Hello Bernd, > > 2014-12-31 19:00 GMT+01:00 Bernd Eckenfels : > >> Hello Benedikt, >> >> I have pushed an updated download page text (a bit shorter than your >> proposal). >> >> I also made changes to CONTRIBUTING/README.md goals which wi

Re: [site][build-plugin] Keys link link on download page

2015-01-02 Thread Benedikt Ritter
Hello Bernd, 2014-12-31 19:00 GMT+01:00 Bernd Eckenfels : > Hello Benedikt, > > I have pushed an updated download page text (a bit shorter than your > proposal). > > I also made changes to CONTRIBUTING/README.md goals which will work for > VFS (more or less, some manual work is required for javad

Re: Committing Code, JIRA Gardening

2015-01-02 Thread Benedikt Ritter
Hello Carl, 2015-01-02 7:15 GMT+01:00 Carl Hall : > Hi all, > > Per the recent announcement granting commit access to all ASF committers, > I'd like to take you up on that. > Nice to hear that, welcome to Commons. > > Can I work directly with the Git repo or should I commit to svn? > Where

Re: [VOTE] Release Apache Commons Validator 1.4.1 based on RC2

2015-01-02 Thread Benedikt Ritter
Hm, not sure how serious this is. Let's see what others think. My feeling is that we can fix that in 1.4.2 or 1.5 Benedikt 2015-01-02 3:06 GMT+01:00 sebb : > Sorry, the mistake is mine entirely. > The code to download the file was wrong - it was not checking the > length of the buffer when writi