On 2014-12-31, <krosenv...@apache.org> wrote:
> static ScatterGatherBackingStoreSupplier defaultSupplier = new
> DefaultSupplier();
This one could be instance variable (and made final when set in the
constructor). I think this would be a cleaner approach to overriding
the supplier that setting a static variable. Could be private as well.
> static class DefaultSupplier implements ScatterGatherBackingStoreSupplier {
If you made the changes I suggest, then this class should probably be
protected.
> static ScatterZipOutputStream
> createDeferred(ScatterGatherBackingStoreSupplier
> scatterGatherBackingStoreSupplier)
would then be an instance method. Do you need it to be public?
>+ ThreadLocal<ScatterZipOutputStream> tlScatterStreams = new
>ThreadLocal<ScatterZipOutputStream>() {
why is this package private?
Cheers
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org
