here
>
> https://issues.apache.org/jira/browse/CASSANDRA-18047
> https://issues.apache.org/jira/browse/CASSANDRA-18048
>
>
> From: Mick Semb Wever
> Sent: Monday, November 14, 2022 23:28
> To: dev@cassandra.apache.org
> Subject: Re: Some
18048
From: Mick Semb Wever
Sent: Monday, November 14, 2022 23:28
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their
name
NetApp Security WARNING: This is an external email. Do not
click links or open attach
___
>>> From: Mick Semb Wever
>>> Sent: Monday, November 14, 2022 23:28
>>> To: dev@cassandra.apache.org
>>> Subject: Re: Some tests are never executed in CI due to their name
>>>
>>> NetApp Security
rg/jira/browse/CASSANDRA-18047
>> https://issues.apache.org/jira/browse/CASSANDRA-18048
>>
>>
>> From: Mick Semb Wever
>> Sent: Monday, November 14, 2022 23:28
>> To: dev@cassandra.apache.org
>> Subject: Re: Some tests are
se/CASSANDRA-18048
>
>
> From: Mick Semb Wever
> Sent: Monday, November 14, 2022 23:28
> To: dev@cassandra.apache.org
> Subject: Re: Some tests are never executed in CI due to their name
>
> NetApp Security WARNING: This is an external email. Do not click links or
&
tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
in CASSANDRA-18029, two flaky tests were committed by mistake due to my
misunderstanding. We
> in CASSANDRA-18029, two flaky tests were committed by mistake due to my
> misunderstanding. We agreed on this thread that we should not commit flaky
> tests right before rc. So now the rc is technically blocked by them. To
> unblock it, what is needed is to have a waiver on them. If there is not
in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
+1 to treating as new unvetted tests.
Kind Regards,
Brandon
On Thu, Nov 10, 2022 at 5:41 AM Mick Semb Wever wrote
+1 to treating as new unvetted tests.
Kind Regards,
Brandon
On Thu, Nov 10, 2022 at 5:41 AM Mick Semb Wever wrote:
>
>
>
> On Thu, 10 Nov 2022 at 10:18, Miklosovic, Stefan
> wrote:
>>
>> I want to ask if people are comfortable with merging CASSANDRA-17964 before
>> 4.1 is out. We clean a lot
On Thu, 10 Nov 2022 at 10:18, Miklosovic, Stefan <
stefan.mikloso...@netapp.com> wrote:
> I want to ask if people are comfortable with merging CASSANDRA-17964
> before 4.1 is out. We clean a lot of things and rename tests which we
> should take care of. (like PaxosRepairTest2).
>
> We might still
but I personally do not see any reason for this.
Thoughts?
From: Miklosovic, Stefan
Sent: Monday, November 7, 2022 23:23
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
Hi,
A while ago we came up with a
2022 9:47
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
Re '@Test' without '
Re '@Test' without 'abstract': There's a corner case of a base abstract
class with all test cases. Then 2 or 3 inheriting classes with no
'@Test' annotations bc they just run the base class with different
configs, setups, envs, parametrized runs, etc I've seen some of those.
On 1/11/22 22:54,
Aha wait a minute I got it :D Yeah. This is not what you invented, it is
> already in, sorry.
>
> So, you are saying we should just modify this to cover @Test / abstract.
>
> I dont know ... interesting.
>
> Lets wait for others to answer.
>
This thread is rather painful to digest because of the
: Monday, October 31, 2022 20:36
To: dev
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
I just feel we need to plumb this
oration, I would like to see it all playing
together, that is all.
From: Josh McKenzie
Sent: Monday, October 31, 2022 20:36
To: dev
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do
sually easily recognizable (what is test and what not) in IDE or similar.
>
> Also, I would like to hear opinions of others when it comes to this second
> idea.
>
> ____
> From: Josh McKenzie
> Sent: Monday, October 31, 2022 19:25
> To: dev
> Subject: Re: Some tests are never exec
o hear opinions of others when it comes to this second idea.
From: Josh McKenzie
Sent: Monday, October 31, 2022 19:25
To: dev
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments u
the checkstyle fails.
>
> ____________________
> From: Josh McKenzie
> Sent: Monday, October 31, 2022 17:16
> To: dev
> Subject: Re: Some tests are never executed in CI due to their name
>
> NetApp Security WARNING: This is an external email. Do not
2022 17:16
To: dev
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
I do not think that having a test class called "
is "TestThing" or "ThingTest" or "WeTestThing". The ordering of names on
those files adds very little IMO.
> I do not think we are actually winning anything with that approach.
Well, the name of this thread is "Some tests are never executed in CI due to
inning anything with that approach.
Regards
From: Josh McKenzie
Sent: Monday, October 31, 2022 12:49
To: dev
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
I do not think there is any module in checkstyle which would do what you want.
From: Josh McKenzie
Sent: Monday, October 31, 2022 12:49
To: dev
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an
tyle to 4.1 and trunk as
> discussed, so I expect we fix all 5 branches at once.
>
> Regards
>
> Stefan
>
>
> From: Berenguer Blasi
> Sent: Friday, October 28, 2022 9:43
> To: dev@cassandra.apache.org
> Subject: Re: Some
checkstyle to 4.1 and trunk as discussed,
so I expect we fix all 5 branches at once.
Regards
Stefan
From: Berenguer Blasi
Sent: Friday, October 28, 2022 9:43
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp
t. I just do not find it necessary to do that.
From: Berenguer Blasi
Sent: Tuesday, October 25, 2022 11:08
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an e
Blasi
Sent: Tuesday, October 25, 2022 11:08
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click
links or open attachments unless you recognize the sender and know
th
om happening again when there are tests ending on "Tests" or starting on
> "Test". The only case it will not cover is "SplitN" issue we plan to cover
> with relaxed test.name property.
> >
> > It seems like what you wrote means that we will fix it and tests
xed test.name property.
>
> It seems like what you wrote means that we will fix it and tests will leak
> again. That is not true.
>
> ____
> From: Berenguer Blasi
> Sent: Tuesday, October 25, 2022 7:26
> To: dev@cassandra.apache.org
>
do include @Test methods but I think they are
abstract as they are meant to be extended as the real test is just wrapping
that. This might happen when there are slight variations across test classes.
This is fine as well.
____________
From: Derek Chen-Becker
Sent:
like what you wrote means that we will fix it and tests will leak
again. That is not true.
From: Berenguer Blasi
Sent: Tuesday, October 25, 2022 7:26
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetAp
I think that was already communicated and understood.
From: Berenguer Blasi
Sent: Tuesday, October 25, 2022 7:26
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external
___
From: Derek Chen-Becker
Sent: Monday, October 24, 2022 19:18
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and kno
ek Chen-Becker
Sent: Monday, October 24, 2022 19:18
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is
; which is no-no. I agree that "TestBaseImpl" is rather
> unfortunate name. Currently, TestBaseImpl itself extends
> "DistributedTestBase" so in the end we would have "DistributedTestBaseImpl
> -> TestBaseImpl -> DistributedTestBase". Please keep in mind that
> "D
do not
think that is possible under circumstances we have where (checkstyle module).
From: Derek Chen-Becker
Sent: Monday, October 24, 2022 15:53
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Securit
Becker
Sent: Monday, October 24, 2022 15:53
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
NetApp Security WARNING: This is an external email. Do not click links or open
attachments unless you recognize the sender and know the content is safe.
dTestBaseImpl
> -> TestBaseImpl -> DistributedTestBase". Please keep in mind that
> "DistributedTestBase" is located in dtest jar (separate project) and that
> is rather inconvenient to rename.
>
> Regards
>
>
> From: Derek
ber 24, 2022 15:26
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to their name
Hi Derek,
yes, the regexp is ^(?!(?:Test))(?!.*?(?:Tests)).*$
What we are trying to achieve by that is to have a test which ends on "Test"
and nothing else and it may contai
e" is located in dtest jar
(separate project) and that is rather inconvenient to rename.
Regards
From: Derek Chen-Becker
Sent: Monday, October 24, 2022 15:09
To: dev@cassandra.apache.org
Subject: Re: Some tests are never executed in CI due to thei
For clarity, what is the final regex you've landed on for the first
approach? Is it "^(?!(?:Test))(?!.*?(?:Tests)).*$" ? Are we just trying to
reject anything that *starts* with "Test" or contains "Tests" somewhere in
the name? It might be more clear to state what we think a valid test name
should
Hi list,
it was reported that some tests are not executed as part of CI because of their
name (1). There is (2) and (3) so right now it runs only "*Test.java" files.
Except of us renaming the affected classes, we should fix this in a more robust
way - via checkstyle - so we enforce how test fil
42 matches
Mail list logo
