Hi list, in CASSANDRA-18029, two flaky tests were committed by mistake due to my misunderstanding. We agreed on this thread that we should not commit flaky tests right before rc. So now the rc is technically blocked by them. To unblock it, what is needed is to have a waiver on them. If there is not a waiver, I need to go back to that test and remove the two test methods which are flaky. (In practice they will be probably just @Ignore-ed with comment about flakiness so we can fix them later).
Flaky tests are org.apache.cassandra.distributed.test.PaxosRepair2Test.paxosRepairHistoryIsntUpdatedInForcedRepair org.apache.cassandra.distributed.test.PaxosRepair2Test.legacyPurgeRepairLoop I sincerely apologize for messing things up and being drifted away by the ticket and forgetting about the ML thread which has the ultimate precedence in this matter. This should have been ideally requested before the commit and it was just an oversight about keeping both ticket and ML communication in sync. Regards ________________________________________ From: Brandon Williams <dri...@gmail.com> Sent: Thursday, November 10, 2022 13:20 To: dev@cassandra.apache.org Subject: Re: Some tests are never executed in CI due to their name NetApp Security WARNING: This is an external email. Do not click links or open attachments unless you recognize the sender and know the content is safe. +1 to treating as new unvetted tests. Kind Regards, Brandon On Thu, Nov 10, 2022 at 5:41 AM Mick Semb Wever <m...@apache.org> wrote: > > > > On Thu, 10 Nov 2022 at 10:18, Miklosovic, Stefan > <stefan.mikloso...@netapp.com> wrote: >> >> I want to ask if people are comfortable with merging CASSANDRA-17964 before >> 4.1 is out. We clean a lot of things and rename tests which we should take >> care of. (like PaxosRepairTest2). >> >> We might still fix it without merging 17964 as we know what should be fixed >> and we can wait until 4.1 is out but I personally do not see any reason for >> this. > > > > Unless these are runtime failures that will hurt users running 4.1, let's > treat them as new incomplete tests. So please let's not add new broken tests > right before the rc.
