On 12/18/18 5:58 PM, Ben Elliston wrote:
>
> Sometimes it is true that things are the way they are for a reason,
> but some of those reasons are now 25 years old. I really don't mind
> the idea that the next version of DejaGnu might not run on Ultrix. :)
The original spec in those days was it ha
On Tue, Dec 18, 2018 at 06:52:58PM -0600, Jacob Bachmeyer wrote:
> That is what makes it "fun" -- I am not entirely certain what is in
> POSIX sh and what is a Bash-specific extension, so I tend to "follow
> suit" on this codebase and presume that the existing code is the way
> it is for a reason
Ben Elliston wrote:
On Tue, Dec 18, 2018 at 06:13:53PM -0600, Jacob Bachmeyer wrote:
Why not test $verbose -gt 0?
The existing "runtest" script uses expr for those tests. I decided to
follow suit on the assumption that that choice was made for a reason,
presumably portability, althou
Ben Elliston wrote:
The patch is missing the changes to Makefile.am.
? ...
So it is... it seems that the patch was exported with the wrong range of
commits, somehow omitting the last commit on the branch. (I suspect the
mouse was subtly off when I selected "Make patch" in gitk and I did n
On Tue, Dec 18, 2018 at 06:13:53PM -0600, Jacob Bachmeyer wrote:
> > Why not test $verbose -gt 0?
>
> The existing "runtest" script uses expr for those tests. I decided to
> follow suit on the assumption that that choice was made for a reason,
> presumably portability, although the Autoconf port
Andreas Schwab wrote:
On Dez 18 2018, Jacob Bachmeyer wrote:
+if expr "$verbose" \> 0 > /dev/null ; then
Why not test $verbose -gt 0?
The existing "runtest" script uses expr for those tests. I decided to
follow suit on the assumption that that choice was made for a reason,
pres
On Dez 18 2018, Jacob Bachmeyer wrote:
> +if expr "$verbose" \> 0 > /dev/null ; then
Why not test $verbose -gt 0?
Andreas.
--
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
_
Hi Jacob
The patch is missing the changes to Makefile.am.
Also, my version of shellcheck (0.5.0) reports:
In dejagnu line 130:
$(grep '^set frame_version' "${datadir}/runtest.exp" \
^-- SC2046: Quote this to prevent word splitting.
Cheers,
Ben
signature.asc
Description: PGP si
