Ben Elliston wrote:
On Tue, Dec 18, 2018 at 06:13:53PM -0600, Jacob Bachmeyer wrote:
Why not test $verbose -gt 0?
The existing "runtest" script uses expr for those tests. I decided to
follow suit on the assumption that that choice was made for a reason,
presumably portability, although the Autoconf portable shell guidelines do
not mention that concern with "test".
Unless there is a good reason, I am happy to accept anything in the
shell scripts that is in POSIX sh.
That is what makes it "fun" -- I am not entirely certain what is in
POSIX sh and what is a Bash-specific extension, so I tend to "follow
suit" on this codebase and presume that the existing code is the way it
is for a reason not known to me.
This "following suit" is the reason that dejagnu(1) uses "expr" instead
of "test" to control verbose messages. I am not particularly adverse to
changing that, if I were to be given a good reason to make the change.
(A good reason to change "dejagnu" this way would probably also be a
good reason to update "runtest" similarly.)
-- Jacob
_______________________________________________
DejaGnu mailing list
DejaGnu@gnu.org
https://lists.gnu.org/mailman/listinfo/dejagnu
