Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-15 Thread Bastian Blank
On Thu, Mar 06, 2025 at 05:23:00PM +0100, NoisyCoil wrote: > oss4-dev is fine (unless diversions of files in linux-libc-dev are > forbidden): oss4-dev is correctly diverting the header, as a consequence it > needs not Break or Conflict with linux-libc-dev. linux-libc-dev defines the interface the

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-13 Thread Otto Kekäläinen
Hi, Would Matthias or anyone else active in this discussion be willing to be the reviewer for https://salsa.debian.org/debian/devscripts/-/merge_requests/478? It has been pending for almost two weeks with zero reviews. I don't feel it would be prudent of me to merge it with no additional eyeballs

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-11 Thread Bastian Blank
On Thu, Mar 06, 2025 at 06:21:10PM +0100, Matthias Urlichs wrote: > However, I'm reasonably certain that there are other cases where diversions > are intentional and perfectly valid. Unless 'missing-breaks' learns to > handle them it will report CI failures for *all* of them, at which point we > mi

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread Matthias Urlichs
On 06.03.25 23:01, Chris Hofstaedtler wrote: This doesn't give a huge list of packages using diversions, but very high profile packages are in there. Keep in mind that many of those are there to support usrmerge; these probably should be filtered out. On the other hand, on my system lots of

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread Chris Hofstaedtler
* Otto Kekäläinen [250306 19:57]: > Salsa CI has had for many years the job 'missing-breaks' that > complements piuparts by checking that the files a package introduce > don't clash with files shipped by any other package in the > distribution without having proper Breaks/Replaces in the > `debi

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread Matthias Urlichs
On 06.03.25 19:42, Bastian Blank wrote: On Thu, Mar 06, 2025 at 06:21:10PM +0100, Matthias Urlichs wrote: However, I'm reasonably certain that there are other cases where diversions are intentional and perfectly valid. Do you have an example? Does perldoc diverting the stub perldoc so that it

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread Otto Kekäläinen
Hi! > > Salsa CI has had for many years the job 'missing-breaks' that > > complements piuparts by checking that the files a package introduce > > don't clash with files shipped by any other package in the > > distribution without having proper Breaks/Replaces in the > > `debian/control` file. This

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread Matthias Urlichs
On 06.03.25 17:51, Bastian Blank wrote: Because diverts are kind of sledgehammers. Without coordination they break stuff. OK, so in *this* case the diversion is in error (in your opinion anyway; not having looked at the contents of these headers, I have no opinion here). However, I'm reason

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread NoisyCoil
On 06/03/25 17:09, Bastian Blank wrote: Open an serious bug report against oss4-dev. No need to wait, it needs to go. oss4-dev is fine (unless diversions of files in linux-libc-dev are forbidden): oss4-dev is correctly diverting the header, as a consequence it needs not Break or Conflict wit

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread Bastian Blank
On Thu, Mar 06, 2025 at 03:52:54PM +0100, NoisyCoil wrote: > Another instance of diversions not being detected is in linux's pipeline > [1,2]: linux-libc-dev and oss4-dev both install > /usr/include/linux/soundcard.h, oss4-dev diverts it, missing-break fails. If > my understanding is correct, this

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread NoisyCoil
On 06/03/25 14:25, Lorenzo wrote: Hello Otto, [please keep me in CC, I'm not subscribed] Salsa CI has had for many years the job 'missing-breaks' that complements piuparts by checking that the files a package introduce don't clash with files shipped by any other package in the distribution wit

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-03-06 Thread Lorenzo
Hello Otto, [please keep me in CC, I'm not subscribed] > Salsa CI has had for many years the job 'missing-breaks' that > complements piuparts by checking that the files a package introduce > don't clash with files shipped by any other package in the > distribution without having proper Breaks/Rep

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-02-26 Thread Otto Kekäläinen
Thanks for the feedback! Ideally the script https://salsa.debian.org/salsa-ci-team/pipeline/-/blob/master/images/scripts/check_for_missing_breaks_replaces.py would live in the devscripts package and be extended to have the features suggested in this thread. However, even in its current form it ha

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-02-25 Thread Arnaud Rebillout
On 26/02/2025 00:10, Guillem Jover wrote: > On Tue, 2025-02-25 at 08:14:52 -0800, Otto Kekäläinen wrote: >> $ check_for_missing_breaks_replaces.py -o >> ${WORKING_DIR}/missing_breaks.xml --changes-file >> ${WORKING_DIR}/*.changes >> [ERROR] Missing Breaks/Replaces found >> [ERROR] foo conflicts wit

Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-02-25 Thread Simon Richter
Hi, can this be fixed to suggest Conflicts instead of Breaks/Replaces if the file in the other package is still shipped in the current version? Breaks/Replaces implies that ownership should be transferred from the other package to this one. This is most often correct, but care needs to be taken

Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-02-25 Thread Guillem Jover
Hi! On Tue, 2025-02-25 at 08:14:52 -0800, Otto Kekäläinen wrote: > Salsa CI has had for many years the job 'missing-breaks' that > complements piuparts by checking that the files a package introduce > don't clash with files shipped by any other package in the > distribution without having proper B

Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

2025-02-25 Thread Otto Kekäläinen
Hi all package maintainers who use Salsa CI, Salsa CI has had for many years the job 'missing-breaks' that complements piuparts by checking that the files a package introduce don't clash with files shipped by any other package in the distribution without having proper Breaks/Replaces in the `debia