Jim Meyering <[EMAIL PROTECTED]> writes:
> Bruno Haible <[EMAIL PROTECTED]> wrote:
>
>> Jim Meyering wrote:
>>> Thanks for the suggestion. It looks like a good one.
>>
>> The suggestion also applies to the 'md5' module, after which the 'sha1'
>> module
>> is modeled.
>
> Yep. md2 and md4 too.
>
Jim Meyering <[EMAIL PROTECTED]> writes:
> Bruno Haible <[EMAIL PROTECTED]> wrote:
>
>> Jim Meyering wrote:
>>> Thanks for the suggestion. It looks like a good one.
>>
>> The suggestion also applies to the 'md5' module, after which the 'sha1'
>> module
>> is modeled.
>
> Yep. md2 and md4 too.
>
Jim Meyering <[EMAIL PROTECTED]> wrote:
> David Shaw <[EMAIL PROTECTED]> wrote:
>> Peter Palfrader reported a bug against the sha1 code in paperkey, but
>> that code actually comes from gnulib, so I'm referring it to you.
>>
>> The issue comes up (as noted in the comment) if resbuf is not 32-bit
>>
Bruno Haible <[EMAIL PROTECTED]> wrote:
> Jim Meyering wrote:
>> Thanks for the suggestion. It looks like a good one.
>
> The suggestion also applies to the 'md5' module, after which the 'sha1' module
> is modeled.
Yep. md2 and md4 too.
For now, I've pushed the sha1 changes.
> But if you apply
Jim Meyering wrote:
> Thanks for the suggestion. It looks like a good one.
The suggestion also applies to the 'md5' module, after which the 'sha1' module
is modeled.
But if you apply the suggestion to both the sha1 and md5 modules, we get
an additional difference to glibc code.
OTOH, Simon hims
Bruno Haible <[EMAIL PROTECTED]> writes:
> Jim Meyering wrote:
>> Thanks for the suggestion. It looks like a good one.
>
> The suggestion also applies to the 'md5' module, after which the 'sha1' module
> is modeled.
>
> But if you apply the suggestion to both the sha1 and md5 modules, we get
> an
Jim Meyering <[EMAIL PROTECTED]> wrote:
...
> Thanks for the suggestion. It looks like a good one.
> However, I don't want to change the type of the resbuf parameter.
> Here's the change I'm considering:
And of course, coreutils/lib/sha*.c would get the same change.
--
To UNSUBSCRIBE, email
David Shaw <[EMAIL PROTECTED]> wrote:
> Peter Palfrader reported a bug against the sha1 code in paperkey, but
> that code actually comes from gnulib, so I'm referring it to you.
>
> The issue comes up (as noted in the comment) if resbuf is not 32-bit
> aligned. Rather than requiring all programs t
Hello,
Peter Palfrader reported a bug against the sha1 code in paperkey, but
that code actually comes from gnulib, so I'm referring it to you.
The issue comes up (as noted in the comment) if resbuf is not 32-bit
aligned. Rather than requiring all programs that use the gnulib sha1
code to align t
9 matches
Mail list logo
