Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-10-31 Thread Boris Pek
> Can you share the error message? Error message was quite useless: $ eiskaltdcpp-cli-jsonrpc Can't call method "version" on an undefined value at /usr/bin/eiskaltdcpp-cli-jsonrpc line 100. eval method written in that way did not work as expected in case when JSON::RPC::Client is unavailable an

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-10-31 Thread Boris Pek
Hi again, > Unfortunately, eiskaltdcpp-cli is completely broken now. Your code does not > work as expected. But my variant (comparing of versions) works fine. > > Could you check the problem and propose better solution? Solution had been found: https://github.com/eiskaltdcpp/eiskaltdcpp/commit/1d

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-10-31 Thread Damyan Ivanov
-=| Boris Pek, 31.10.2013 22:03:06 +0200 |=- > Hi Damyan, > > 2013-08-08, 02:18 +04:00, "Boris Pek" wrote: > >>> Hmm, I have just pushed very similar patch: > >>> https://github.com/eiskaltdcpp/eiskaltdcpp/commit/767538d > >>> > >>> I do not know perl at all. So could you compare which variant is

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-10-31 Thread Boris Pek
Hi Damyan, 2013-08-08, 02:18 +04:00, "Boris Pek" wrote: >>> Hmm, I have just pushed very similar patch: >>> https://github.com/eiskaltdcpp/eiskaltdcpp/commit/767538d >>> >>> I do not know perl at all. So could you compare which variant is better >>> (your or mine)? >> >> Yours depends on version

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-08-14 Thread Boris Pek
Hi, > I have uploaded the new libjson-rpc-perl to unstable and bumped this > bug's severity to serious to avoid releasing with it. > > Please close it with your next upload. Yes, sure. We are going to make a bugfix release of EiskaltDC++ soon. If it does not happen this week, I will upload the

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-08-11 Thread Damyan Ivanov
Control: severity -1 serious -=| Boris Pek, 08.08.2013 02:18:54 +0400 |=- > >> Hmm, I have just pushed very similar patch: > >> https://github.com/eiskaltdcpp/eiskaltdcpp/commit/767538d > >> > >> I do not know perl at all. So could you compare which variant is better > >> (your or mine)? > > > >

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-08-07 Thread Boris Pek
>> Hmm, I have just pushed very similar patch: >> https://github.com/eiskaltdcpp/eiskaltdcpp/commit/767538d >> >> I do not know perl at all. So could you compare which variant is better >> (your or mine)? > > Yours depends on version numbers, mine depends on module existence. > Since the version

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-08-07 Thread Damyan Ivanov
-=| Boris Pek, 08.08.2013 01:15:01 +0400 |=- > >> Is it possible to check which version is available and to load module > >> depending > >> on the result? > > > > Alright. Please find attached a patch that would work with either old > > or new RPC-JSON at the expense of some code bloat. > > Hmm

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-08-07 Thread Boris Pek
>> Is it possible to check which version is available and to load module >> depending >> on the result? > > Alright. Please find attached a patch that would work with either old > or new RPC-JSON at the expense of some code bloat. Hmm, I have just pushed very similar patch: https://github.com/e

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-08-07 Thread Damyan Ivanov
-=| Boris Pek, 07.08.2013 23:35:41 +0400 |=- > > Please find attached a patch that adapts eiskaltdcpp-cli to > > libjson-rpc-perl 1.03 (just uploaded to experimental). > > > > JSON-RPC's upstream has changed (some two years ago), and that change led > > to > > some reorganisation, resulting in

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-08-07 Thread Boris Pek
Hi, Thanks for the bug report. > Please find attached a patch that adapts eiskaltdcpp-cli to libjson-rpc-perl > 1.03 (just uploaded to experimental). > > JSON-RPC's upstream has changed (some two years ago), and that change led to > some reorganisation, resulting in JSON::RPC::Client being ren

Bug#719016: eiskaltdcpp-cli: needs adaptation to libjson-rpc-perl 1.03

2013-08-07 Thread Damyan Ivanov
Package: eiskaltdcpp-cli Version: 2.2.8-1 Severity: important Tags: patch Please find attached a patch that adapts eiskaltdcpp-cli to libjson-rpc-perl 1.03 (just uploaded to experimental). JSON-RPC's upstream has changed (some two years ago), and that change led to some reorganisation, resultin