Hi Damyan, 2013-08-08, 02:18 +04:00, "Boris Pek" wrote: >>> Hmm, I have just pushed very similar patch: >>> https://github.com/eiskaltdcpp/eiskaltdcpp/commit/767538d >>> >>> I do not know perl at all. So could you compare which variant is better >>> (your or mine)? >> >> Yours depends on version numbers, mine depends on module existence. >> Since the version number is artificial, I'd say that checking for >> module availability is better. For example, according to upstream >> change log, the incompatible changes are made in CPAN release >> versioned '1.00_01', which is an awful thing to compare to. > > Ok, I will change it to your variant.
Unfortunately, eiskaltdcpp-cli is completely broken now. Your code does not work as expected. But my variant (comparing of versions) works fine. Could you check the problem and propose better solution? Best regards, Boris -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
