Bug#690851: Code review

2012-11-30 Thread Örjan Persson
Mike Gabriel (mike.gabr...@das-netzwerkteam.de) wrote: > I currently have not time to fix that patch. I still recommend > switching to gevent 1.0~b1, though I am aware of the release team > not accepting new upstream releases in packages at this state of the > freeze. I don't think that would be t

Bug#690851: Code review

2012-11-28 Thread Mike Gabriel
Hi all, On Di 27 Nov 2012 02:33:00 CET Michael Gilbert wrote: If Mike fixes the flaw in his patch, he has the right to fight for its inclusion since it fixes a part of the package that's quite broken now. Note: I am not upstream of python-gevent, I am not sure, if that is clear to everyone.

Bug#690851: Code review

2012-11-26 Thread Michael Gilbert
control: severity -1 important On Mon, Nov 26, 2012 at 8:25 AM, Dominik George wrote: >> So, if you can fix up that issue in the patch, we can do another >> upload and ask for an unblock. > > I still do not think this should be done. This would be a Debian-specific > patch for something that is re

Bug#690851: Code review

2012-11-26 Thread Dominik George
severity 690851 normal kthxbye Michael, first of all, you are replying to a post I made. *Please* do not remove me from Cc, then! Now, back on topic: > So, if you can fix up that issue in the patch, we can do another > upload and ask for an unblock. I still do not think this should be done. T

Bug#690851: Code review

2012-11-25 Thread Michael Gilbert
On Sun, Nov 25, 2012 at 2:53 PM, Mike Gabriel wrote: >> if ipv4_res is not None: >> for res in ipv4_res: >> >> (et al), this looks the same as what was there before, but it is a bug. >> The ipv4_res could be False, which is also not iterable. >> >> if ipv4_res: >> >>

Bug#690851: Code review

2012-11-25 Thread Mike Gabriel
Hi Nik, On So 25 Nov 2012 15:43:01 CET Dominik George wrote: in the ocurse of the BSP Essen I took a close look at this report and the proposed patch. First of all, I am downgrading the severity of the bug to important to remove it from the RC list. The background is that the changes are most

Bug#690851: Code review

2012-11-25 Thread Dominik George
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 severity 690851 important kthxbye Hi, in the ocurse of the BSP Essen I took a close look at this report and the proposed patch. First of all, I am downgrading the severity of the bug to important to remove it from the RC list. The background is th