Bug#645166: links2: grave error in patch for ipv6

2011-11-04 Thread Axel Beckert
Hi Mats, Mats Erik Andersson wrote: > There are further mistakes [...] Thanks! The original patch author posted an updated patch to the upstream mailing list today which is said to fix many errors of/in the old patch. I'll check if your findings still apply and will upload a package with the up

Bug#645166: links2: grave error in patch for ipv6

2011-11-04 Thread Mats Erik Andersson
torsdag den 3 november 2011 klockan 12:51 skrev Axel Beckert detta: > Mats Erik Andersson wrote: > > I did a quick review of the IPv6 patch as presented by PTS. > > There is a grave misconception in the modification of > > "links2/default.c": > > Well, I looked for such an issue several times and

Bug#645166: links2: grave error in patch for ipv6

2011-11-03 Thread Axel Beckert
Hi Mats! Mats Erik Andersson wrote: > I did a quick review of the IPv6 patch as presented by PTS. > There is a grave misconception in the modification of > "links2/default.c": > > A single character variable is allocated, yet it is > used in storing and printing strings: > > char addr; >

Bug#645166: links2: grave error in patch for ipv6

2011-11-03 Thread Mats Erik Andersson
I did a quick review of the IPv6 patch as presented by PTS. There is a grave misconception in the modification of "links2/default.c": A single character variable is allocated, yet it is used in storing and printing strings: char addr; unsigned char *p = (...) &addr; do_real_look