torsdag den 3 november 2011 klockan 12:51 skrev Axel Beckert detta:
> Mats Erik Andersson wrote:
> > I did a quick review of the IPv6 patch as presented by PTS.
> > There is a grave misconception in the modification of
> > "links2/default.c":
>
> Well, I looked for such an issue several times and did not see it.
There are further mistakes in "dns.c". The functions find_host()
and end_dns_lookup() are "once+twice" using code written as
&dnsentry->addr
which must be
dnsentry->addr
since this latter is already the intended character array,
and is also of correct size. (Many NI_MAXSIZE ought to be
written as "sizeof(varname)".)
There are several other issues of portability relevance,
which convince me that we really should review this patch
properly before claiming its functionality to be known.
As an example
#ifdef AI_ADDRCONFIG
hints.ai_flags |= AI_ADDRCONFIG;
#endif
This is always a solid counter measure for differing setups,
and is best implemented conditionally since OpenBSD lacks
this particular macro.
Best regards,
Mats E A
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
