Bug#610381: git-import-dsc: lies about commit date

2011-01-22 Thread Jonathan Nieder
Guido Günther wrote: > I think we should be safe with the defaults and the > --author-is-committer and --author-date-is-committer-date options give > folks just enough rope. Thanks, looks good to me. diff --git a/docs/manpages/git-import-dsc.sgml b/docs/manpages/git-import-dsc.sgml index 3291b3

Bug#610381: git-import-dsc: lies about commit date

2011-01-22 Thread Guido Günther
Hi Jonathan, On Thu, Jan 20, 2011 at 03:06:07AM -0600, Jonathan Nieder wrote: [..snip..] > git assumes each commit has an equal or later timestamp to each of its > parents and uses that assumption to optimize commands like "git log > .." and "git name-rev ".[1] I think we should be safe with the

Bug#610381: git-import-dsc: lies about commit date

2011-01-20 Thread Jonathan Nieder
Guido Günther wrote: > On Wed, Jan 19, 2011 at 09:18:33PM -0600, Rob Browning wrote: >> For what it's worth, I believe having current committer dates also >> alters the way gitk sorts its display. Makes sense. Not too relevant here, but have you tried "gitk --topo-order"? > So I think having th

Bug#610381: git-import-dsc: lies about commit date

2011-01-20 Thread Guido Günther
On Wed, Jan 19, 2011 at 09:18:33PM -0600, Rob Browning wrote: > Guido Günther writes: > > > I think that's the point. I'm not a friend of these new options either > > (that's why I changed the default) but when introduced we could make > > git-import-dscs pass them to git-import-dsc by default wh

Bug#610381: git-import-dsc: lies about commit date

2011-01-19 Thread Rob Browning
Guido Günther writes: > I think that's the point. I'm not a friend of these new options either > (that's why I changed the default) but when introduced we could make > git-import-dscs pass them to git-import-dsc by default when doing mass > imports. For what it's worth, I believe having current

Bug#610381: git-import-dsc: lies about commit date

2011-01-19 Thread Guido Günther
On Wed, Jan 19, 2011 at 06:54:11AM -0600, Jonathan Nieder wrote: > Hi Guido and Rob, > > Guido Günther wrote: > > > I tend to agree here. I introduced the change recently since Rob (cc:) > > had good arguments for it: > > > > # However, the committer date does appear to affect things like the > >

Bug#610381: git-import-dsc: lies about commit date

2011-01-19 Thread Jonathan Nieder
Hi Guido and Rob, Guido Günther wrote: > I tend to agree here. I introduced the change recently since Rob (cc:) > had good arguments for it: > > # However, the committer date does appear to affect things like the > # --since and --until arguments, and if you're trying to import old > # history, I

Bug#610381: git-import-dsc: lies about commit date

2011-01-18 Thread Guido Günther
On Mon, Jan 17, 2011 at 10:27:10PM -0600, Jonathan Nieder wrote: > Package: git-buildpackage > Version: 0.5.17 > Tags: patch > > Hi again, > > Currently git import-dsc sets the committer date on commits it writes > to equal the author date. That means it is very easy to get > out-of-order commit

Bug#610381: git-import-dsc: lies about commit date

2011-01-17 Thread Jonathan Nieder
Package: git-buildpackage Version: 0.5.17 Tags: patch Hi again, Currently git import-dsc sets the committer date on commits it writes to equal the author date. That means it is very easy to get out-of-order commit timestamps, which are a bad thing™. [1] But more important to me is the following