Bug#431364: apt-listchanges: Does not handle setlocale failure gracefully

2007-07-03 Thread Colin Watson
On Mon, Jul 02, 2007 at 10:47:43PM +0200, Pierre Habouzit wrote: > dAniel hAhler wrote: > > Pierre Habouzit wrote: > > > And reading the bug, it's due to a breakage of Ubuntu that loses > > > locales. > > > > Sure. The locale setup is broken. But that is likely a temporary > > problem and no reaso

Bug#431364: apt-listchanges: Does not handle setlocale failure gracefully

2007-07-02 Thread dAniel hAhler
> It looks wrong because it's silent. Hmm. dpkg and apt are also silent. And I would say that apt-listchanges should stick to apt's behaviour, shouldn't it? > Perl behaviour is better in that regard. I find it too verbose, but I'm OK in general with printing a short warning - if you prefe

Bug#431364: apt-listchanges: Does not handle setlocale failure gracefully

2007-07-02 Thread Pierre Habouzit
On Mon, Jul 02, 2007 at 09:08:12PM +0200, dAniel hAhler wrote: > > The patch looks wrong. > > Can you please tell me what looks wrong? > > As far as I can see it mimics the behaviour of the setlocale() call in C, > where a failure also just gets ignored (e.g. in dselect/main.cc from the dpkg >

Bug#431364: apt-listchanges: Does not handle setlocale failure gracefully

2007-07-02 Thread dAniel hAhler
> The patch looks wrong. Can you please tell me what looks wrong? As far as I can see it mimics the behaviour of the setlocale() call in C, where a failure also just gets ignored (e.g. in dselect/main.cc from the dpkg package). I've tested both "apt" and "dpkg" with "LANG=foo" and both do not

Bug#431364: apt-listchanges: Does not handle setlocale failure gracefully

2007-07-02 Thread Pierre Habouzit
On Mon, Jul 02, 2007 at 12:31:56AM +0200, dAniel hAhler wrote: > Package: apt-listchanges > Version: 2.74 > Severity: normal > Tags: patch > > If the locale settings are broken (which can happen e.g. in the process of > upgrading), apt-listchanges fails with the following backtrace: > Traceback

Bug#431364: apt-listchanges: Does not handle setlocale failure gracefully

2007-07-01 Thread dAniel hAhler
Package: apt-listchanges Version: 2.74 Severity: normal Tags: patch If the locale settings are broken (which can happen e.g. in the process of upgrading), apt-listchanges fails with the following backtrace: Traceback (most recent call last): File "/usr/bin/apt-listchanges", line 37, in