On Mon, Jul 02, 2007 at 09:08:12PM +0200, dAniel hAhler wrote: > > The patch looks wrong. > > Can you please tell me what looks wrong? > > As far as I can see it mimics the behaviour of the setlocale() call in C, > where a failure also just gets ignored (e.g. in dselect/main.cc from the dpkg > package). > > I've tested both "apt" and "dpkg" with "LANG=foo" and both do not fail, nor > issue a warning. > > As another example, perl issues a (huge) warning, but also does not fail. > I've > seen this happen also during upgrade - and it would be really bad, if it > would fail. > > Do you see a better approach to avoid this crash?
It looks wrong because it's silent. Perl behaviour is better in that regard. > > And reading the bug, it's due to a breakage of Ubuntu that loses locales. > > Sure. The locale setup is broken. But that is likely a temporary problem and > no reason for apt-listchanges to fail. Sure, but OTOH apt-listchanges is suposed to be launched at times when the system is fully configured and in a coherent state. perl is used in debconf, hence during (e.g.) the locales upgrade. It's bound to fail somehow wrt locales updates. apt-listchanges is called *before* anything happens. -- ·O· Pierre Habouzit ··O [EMAIL PROTECTED] OOO http://www.madism.org
pgpibXRsK7COh.pgp
Description: PGP signature
