Bug#254243: netstat IPv6 address truncation patch

2005-09-30 Thread Ian Jackson
Here is an updated version of my patch which fixes the "tcp" vs. "udp" string in the protocol lookup bit of the unified tcpudp_one_end. Ian. diff -Nru /tmp/BEfybKtWqd/net-tools-1.60/debian/changelog /tmp/BQGUuO9HrM/net-tools-1.60/debian/changelog --- /tmp/BEfybKtWqd/net-tools-1.60/debian/changel

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Olaf van der Spek
On 9/29/05, Ian Jackson <[EMAIL PROTECTED]> wrote: > Olaf van der Spek writes ("Re: netstat IPv6 address truncation patch"): > > On 9/29/05, Ian Jackson <[EMAIL PROTECTED]> wrote: > > > Without -n, addresses are turned into domain names, which are often > > > truncated by the narrow field width. >

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Ian Jackson
Olaf van der Spek writes ("Re: netstat IPv6 address truncation patch"): > On 9/29/05, Ian Jackson <[EMAIL PROTECTED]> wrote: > > Without -n, addresses are turned into domain names, which are often > > truncated by the narrow field width. > > But I think that's not desired by users. I agree that i

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Olaf van der Spek
On 9/29/05, Ian Jackson <[EMAIL PROTECTED]> wrote: > Olaf van der Spek writes ("Re: netstat IPv6 address truncation patch"): > > On 9/29/05, Ian Jackson <[EMAIL PROTECTED]> wrote: > > > Yes, but only if -n is used. Otherwise people are presumably already > > > used to truncation. > > > > I'm not s

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Ian Jackson
Olaf van der Spek writes ("Re: netstat IPv6 address truncation patch"): > On 9/29/05, Ian Jackson <[EMAIL PROTECTED]> wrote: > > Yes, but only if -n is used. Otherwise people are presumably already > > used to truncation. > > I'm not sure about that. Without -n, addresses are turned into domain

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Olaf van der Spek
On 9/29/05, Ian Jackson <[EMAIL PROTECTED]> wrote: > > > at it it seems to just add a new command-line flag for not truncating > > > the address. That's wrong, IMO. > > > > --wide is enabled by default on interactive terminals > > Bernd prefered that way to avoid breaking any scripts. > > ? > > My

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Ian Jackson
Olaf van der Spek writes ("Re: netstat IPv6 address truncation patch"): > There are two patches. The second version is in another format. Ah, yes. > > at it it seems to just add a new command-line flag for not truncating > > the address. That's wrong, IMO. > > --wide is enabled by default on in

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Olaf van der Spek
On 9/29/05, Ian Jackson <[EMAIL PROTECTED]> wrote: > Olaf van der Spek writes ("Re: netstat IPv6 address truncation patch"): > > Did you see my related patch at > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=222324 > > > > It should also solve the truncation issue but I think it's more genera

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Ian Jackson
Olaf van der Spek writes ("Re: netstat IPv6 address truncation patch"): > Did you see my related patch at > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=222324 > > It should also solve the truncation issue but I think it's more general. The thing you sent to the Debian BTS is an ed-format dif

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Ian Jackson
Olaf van der Spek writes ("Re: netstat IPv6 address truncation patch"): > > +static void tcpudp_one_end(char *result_buf, size_t result_buf_size, > > + struct aftype *ap, int end_port, > > + struct sockaddr *endaddr) > > +{ > > +char buffer[8192]; > > +

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Olaf van der Spek
> +static void tcpudp_one_end(char *result_buf, size_t result_buf_size, > +struct aftype *ap, int end_port, > +struct sockaddr *endaddr) > +{ > +char buffer[8192]; > + > +snprintf(buffer, sizeof(buffer), "%s", > + get_sname(htons(end_

Bug#254243: netstat IPv6 address truncation patch

2005-09-29 Thread Olaf van der Spek
Hi Ian, Did you see my related patch at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=222324 It should also solve the truncation issue but I think it's more general.

Bug#254243: netstat IPv6 address truncation patch

2005-09-20 Thread Bernd Eckenfels
Hello Ian, On Tue, Sep 20, 2005 at 04:05:45PM +0100, Ian Jackson wrote: > Looking at the code it looks like some serious overhaul is required. > Unfortunately I don't think that I have time to do this now, > especially at this point in Ubuntu's release cycle. yes I agree, and you might want to jo

Bug#254243: netstat IPv6 address truncation patch

2005-09-20 Thread Ian Jackson
I am about to apply the attached patch to Ubuntu's version of net-tools. Here is the debian/changelog entry: net-tools (1.60-15ubuntu1) breezy; urgency=low * Do not truncate numeric IPv6 addresses in netstat TCP and UDP. The new output format is not parseable with the same algorithms as