Re: fnmatch improvements

2023-07-28 Thread Bill Stewart via Cygwin
On Fri, Jul 28, 2023 at 5:12 AM Corinna Vinschen wrote: I'm puzzled because I'm an idiot. > That's one thing you certainly are not. Bill -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:https://cygwin.com/docs.html Un

Re: fnmatch improvements

2023-07-28 Thread Bruno Haible via Cygwin
Corinna Vinschen wrote: > > 1. cd testdir-fnmatch-posix > > ./configure > > grep REPLACE_FNMATCH config.status > > (Expected: REPLACE_FNMATCH is 0) > > $ grep REPLACE_FNMATCH config.status > S["REPLACE_FNMATCH"]="0" > > > make > > make check > > (Expected: No t

Re: fnmatch improvements

2023-07-28 Thread Corinna Vinschen via Cygwin
On Jul 28 12:56, Bruno Haible via Cygwin wrote: > It's sometimes hard to make incremental changes to generated files of the > GNU Build System plus Gnulib. I've therefore recreated a new tarball for you, > at https://haible.de/bruno/gnu/testdir-fnmatch.tar.gz . > > The expected result is: > 1. c

Re: fnmatch improvements

2023-07-28 Thread Bruno Haible via Cygwin
Corinna Vinschen wrote: > I'm puzzled because I'm an idiot. I forgot autoreconf. Things like that happen to me as well. There are so many generation phases (collect *.m4 files; autoconf; configure; make) that it's easy to forget one when making incremental changes. It's more reliable to regenerat

Re: fnmatch improvements

2023-07-28 Thread Corinna Vinschen via Cygwin
On Jul 28 12:56, Bruno Haible via Cygwin wrote: > Corinna Vinschen wrote: > > After the above fail, I tried from scratch with your below patch, > > and I still get > > > > $ grep REPLACE_FNMATCH ./config.status > > S["REPLACE_FNMATCH"]="1" > > > > Even though > > > > $ grep fnmatch log1 >

Re: fnmatch improvements

2023-07-28 Thread Corinna Vinschen via Cygwin
On Jul 28 10:53, Corinna Vinschen via Cygwin wrote: > On Jul 27 23:40, Bruno Haible via Cygwin wrote: > > Corinna Vinschen wrote: > > > S["REPLACE_FNMATCH"]="1" > > > > > > Looks like the reason is that we don't have a uchar.h file? Seems > > > like this is of interest for AIX, but why should

Re: fnmatch improvements

2023-07-28 Thread Bruno Haible via Cygwin
Corinna Vinschen wrote: > After the above fail, I tried from scratch with your below patch, > and I still get > > $ grep REPLACE_FNMATCH ./config.status > S["REPLACE_FNMATCH"]="1" > > Even though > > $ grep fnmatch log1 > checking for fnmatch.h... yes > checking for fnmatch... yes >

Re: fnmatch improvements

2023-07-28 Thread Corinna Vinschen via Cygwin
On Jul 28 11:00, Corinna Vinschen via Cygwin wrote: > If we do that, I think the functions > should actually be renamed accordingly and the globbing code should use > uchar32_t rather than wint_t. s/uchar32_t/char32_t/ -- Problem reports: https://cygwin.com/problems.html FAQ:

Re: fnmatch improvements

2023-07-28 Thread Corinna Vinschen via Cygwin
On Jul 27 16:17, Brian Inglis via Cygwin wrote: > On 2023-07-27 15:22, Bruno Haible wrote: > > Brian Inglis wrote: > > > It was added in C99 TR19769, integrated in C/++11 > > > > Yes. > > > > > available in libicu-devel: > > > > > > https://cplusplus.com/reference/cuchar/ > > > > > > https:

Re: fnmatch improvements

2023-07-28 Thread Corinna Vinschen via Cygwin
On Jul 27 23:40, Bruno Haible via Cygwin wrote: > Corinna Vinschen wrote: > > > > 4. cd testdir-fnmatch-posix > > > > ./configure 2>&1 | tee log1 > > > > make > > > > make check > > > > I fixed the above problem and the POSIX check now works fine: > > Glad that the test suite was

Re: fnmatch improvements

2023-07-27 Thread Brian Inglis via Cygwin
On 2023-07-27 15:22, Bruno Haible wrote: Brian Inglis wrote: It was added in C99 TR19769, integrated in C/++11 Yes. available in libicu-devel: https://cplusplus.com/reference/cuchar/ https://open-std.org/jtc1/sc22/open/n3579.pdf https://open-std.org/jtc1/sc22/wg14/

Re: fnmatch improvements

2023-07-27 Thread Bruno Haible via Cygwin
Corinna Vinschen wrote: > > > 4. cd testdir-fnmatch-posix > > > ./configure 2>&1 | tee log1 > > > make > > > make check > > I fixed the above problem and the POSIX check now works fine: Glad that the test suite was helpful (and that you fixed it before 3.5.0 — so, no additional c

Re: fnmatch improvements

2023-07-27 Thread Bruno Haible via Cygwin
Brian Inglis wrote: > It was added in C99 TR19769, integrated in C/++11 Yes. > available in libicu-devel: > > https://cplusplus.com/reference/cuchar/ > > https://open-std.org/jtc1/sc22/open/n3579.pdf > > https://open-std.org/jtc1/sc22/wg14/www/docs/n1326.pdf > > https:

Re: fnmatch improvements

2023-07-27 Thread Brian Inglis via Cygwin
On 2023-07-27 13:05, Corinna Vinschen via Cygwin wrote: On Jul 27 20:24, Corinna Vinschen via Cygwin wrote: On Jul 27 12:15, Bruno Haible via Cygwin wrote: I'm looking into that. First thing, your testsuite uncovered a bug in the latest fnmatch in the C locale. Comparing pointers instead of com

Re: fnmatch improvements

2023-07-27 Thread Corinna Vinschen via Cygwin
On Jul 27 20:24, Corinna Vinschen via Cygwin wrote: > On Jul 27 12:15, Bruno Haible via Cygwin wrote: > I'm looking into that. First thing, your testsuite uncovered a bug in > the latest fnmatch in the C locale. Comparing pointers instead of > comparing characters was never a good idea for pattern

Re: fnmatch improvements

2023-07-27 Thread Corinna Vinschen via Cygwin
Hi Bruno, On Jul 27 12:15, Bruno Haible via Cygwin wrote: > Hi, > > Gnulib has, for the first time, an fnmatch() implementation that supports > characters outside the Unicode Basic Multilingual Plane (BMP), even on Cygwin > with its 16-bits wchar_t type. That is, in an UTF-8 locale, e.g. > fnma