Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-08 Thread Ian Lynagh
On Thu, Nov 08, 2012 at 10:04:44PM +0100, Karel Gardas wrote: > Note that PRIdPTR is considered as linux-ism so it's not available on > platforms > like Solaris, although some other free Unix(-like) OSes apparently supports > it too. Applied, thanks. Thanks Ian ___

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-08 Thread Karel Gardas
Hi Ian, I'm resending the patch changed in a way you prefer (as I hope) with comparison of void_p and int sizes. Generally speaking I like the idea you have described in previous patch email thread to better support cross-compiling, but I would still prefer if the patch may be merged in (eve

[PATCH] define own version of PRIdPTR on platform where its not available

2012-11-08 Thread Karel Gardas
Note that PRIdPTR is considered as linux-ism so it's not available on platforms like Solaris, although some other free Unix(-like) OSes apparently supports it too. --- includes/mkDerivedConstants.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/includes/mkDerivedConstants.c b/in

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-05 Thread Ian Lynagh
On Mon, Nov 05, 2012 at 11:52:43AM +0100, Gabor Greif wrote: > > I have a solution on the cross-compiler-alienless branch which does exactly > what you propose: feed the relevant headers into the cross-gcc, obtain > the offsets/sizes back > by 'nm', and massage stuff to obtain all as macros then f

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-05 Thread Ian Lynagh
On Mon, Nov 05, 2012 at 10:02:08AM +, Simon Marlow wrote: > On 03/11/2012 00:16, Ian Lynagh wrote: > > > >However, I'm hoping to replace mkDerivedConstants.c with probably a > >configure script soon, so that it can produce the right results when > >cross-compiling. > > Yes we need to replace m

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-05 Thread Gabor Greif
Of course I use 'offsetof' in the first part of the tool pipeline. The problem is, though getting the result of it out of the cross-gcc. Here we cannot simply say > printf("offsXYZ = %zu", offsetof(XY, Z)); because there is no way to run the cross-gcc output. Instead I do: > char offsXYZ[offseto

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-05 Thread Erik de Castro Lopo
Gabor Greif wrote: > +1. A configure script will run (almost) till the heat death of the universe. > > I have a solution on the cross-compiler-alienless branch which does exactly > what you propose: feed the relevant headers into the cross-gcc, obtain > the offsets/sizes back > by 'nm', and massa

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-05 Thread Gabor Greif
On 11/5/12, Simon Marlow wrote: > On 03/11/2012 00:16, Ian Lynagh wrote: >> >> Hi Karel, >> >> On Fri, Nov 02, 2012 at 07:39:45PM +0100, Karel Gardas wrote: >>> >>> I'm curious if this patch is kind of controversial so you are >>> reluctant to merge it. If you find any issue with it please let me

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-05 Thread Simon Marlow
On 03/11/2012 00:16, Ian Lynagh wrote: Hi Karel, On Fri, Nov 02, 2012 at 07:39:45PM +0100, Karel Gardas wrote: I'm curious if this patch is kind of controversial so you are reluctant to merge it. If you find any issue with it please let me know so I can change it as per your suggestion. I've

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-02 Thread Erik de Castro Lopo
Ian Lynagh wrote: > If we're going to go this route, then I think we should do it by > comparing SIZEOF_VOID_P to SIZEOF_INT etc, rather than assuming that > either 'ld' or 'd' is right based on _LP64. +1 Erik -- -- Erik de Cas

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-02 Thread Ian Lynagh
Hi Karel, On Fri, Nov 02, 2012 at 07:39:45PM +0100, Karel Gardas wrote: > > I'm curious if this patch is kind of controversial so you are > reluctant to merge it. If you find any issue with it please let me > know so I can change it as per your suggestion. I've done this patch > to un-break GHC

Re: [PATCH] define own version of PRIdPTR on platform where its not available

2012-11-02 Thread Karel Gardas
Hello Team, I'm curious if this patch is kind of controversial so you are reluctant to merge it. If you find any issue with it please let me know so I can change it as per your suggestion. I've done this patch to un-break GHC HEAD build failure on my solaris 11 box. Thanks! Karel On 10/30/

[PATCH] define own version of PRIdPTR on platform where its not available

2012-10-30 Thread Karel Gardas
Note that PRIdPTR is considered as linux-ism so it's not available on platforms like Solaris, although some other free Unix(-like) OSes apparently supports it too. --- includes/mkDerivedConstants.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/includes/mkDeriv