Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to the
test descriptor
-
Commit messages:
- Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to
test desc. It fixes the following error:
Changes: https://git.openjdk.org/jdk/pull/19436
On Tue, 28 May 2024 20:13:24 GMT, Alexey Semenyuk wrote:
> Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to
> the test descriptor
@sashamatveev please review
-
PR Comment: https://git.openjdk.org/jdk/pull/19436#issuecomment-2136094953
On Tue, 28 May 2024 20:13:24 GMT, Alexey Semenyuk wrote:
> Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to
> the test descriptor
This pull request has now been integrated.
Changeset: 91ab088d
Author: Alexey Semenyuk
URL:
https://git
On Fri, 24 May 2024 01:08:03 GMT, Alexander Matveev
wrote:
> This issue is reproducible with and without `--mac-sign`. jpackage will
> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
> using pseudo-identity "_-_". This is why jpackage tries to sign added files
> and t
On Thu, 30 May 2024 20:10:05 GMT, Alexey Semenyuk wrote:
> - Get rid of DottedVersion#greedy field.
> - Add support to save the unrecognizable remainder of the version string
> (required to handle Wix4 version string).
> - Implement DottedVersion#equals().
> - ad
- Get rid of DottedVersion#greedy field.
- Add support to save the unrecognizable remainder of the version string
(required to handle Wix4 version string).
- Implement DottedVersion#equals().
- add DottedVersion#compareComponents(DottedVersion, DottedVersion) that
compares recognized component
Change jpackage tests output from:
[19:16:29.586] Create: SimplePackageTest.test
[19:16:29.587] [ RUN ] SimplePackageTest.test
[19:16:29.663] TRACE: Bundler rpm supported
[19:16:29.674] TRACE: Actions: [[initialize], [create], [unpack],
[verify-install], [finalize]]
to:
[19:16:29.586] Create
On Thu, 30 May 2024 20:26:02 GMT, Alexey Semenyuk wrote:
> Change jpackage tests output from:
>
>
> [19:16:29.586] Create: SimplePackageTest.test
> [19:16:29.587] [ RUN ] SimplePackageTest.test
> [19:16:29.663] TRACE: Bundler rpm supported
> [19:16:29.674] TRACE:
On Thu, 30 May 2024 20:26:02 GMT, Alexey Semenyuk wrote:
> Change jpackage tests output from:
>
>
> [19:16:29.586] Create: SimplePackageTest.test
> [19:16:29.587] [ RUN ] SimplePackageTest.test
> [19:16:29.663] TRACE: Bundler rpm supported
> [19:16:29.674] TRACE:
On Thu, 30 May 2024 22:54:12 GMT, Alexander Matveev
wrote:
>> This issue is reproducible with and without `--mac-sign`. jpackage will
>> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
>> using pseudo-identity "_-_". This is why jpackage tries to sign added files
>> a
On Thu, 30 May 2024 20:10:05 GMT, Alexey Semenyuk wrote:
> - Get rid of DottedVersion#greedy field.
> - Add support to save the unrecognizable remainder of the version string
> (required to handle Wix4 version string).
> - Implement DottedVersion#equals().
> - ad
On Fri, 31 May 2024 14:05:07 GMT, Alexey Semenyuk wrote:
> Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app
> launcher instead of raw Executor. This makes MainClassTest test run app
> launchers with retries. This change addresses the primary issue.
Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app
launcher instead of raw Executor. This makes MainClassTest test run app
launchers with retries. This change addresses the primary issue.
Fix inconsistencies in HelloApp.AppOutputVerifier class. It used to provide API
all
On Fri, 31 May 2024 14:05:07 GMT, Alexey Semenyuk wrote:
> Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app
> launcher instead of raw Executor. This makes MainClassTest test run app
> launchers with retries. This change addresses the primary issue.
On Mon, 3 Jun 2024 08:37:50 GMT, David Holmes wrote:
>> Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app
>> launcher instead of raw Executor. This makes MainClassTest test run app
>> launchers with retries. This change addresses the primary issue.
>>
>> Fix inconsiste
8333452: Make logging in jdk.jpackage.internal.OverridableResource class
configurable
-
Commit messages:
- 8333452: Make logging in jdk.jpackage.internal.OverridableResource class
configurable
Changes: https://git.openjdk.org/jdk/pull/19532/files
Webrev: https://webrevs.openjdk.
On Mon, 3 Jun 2024 20:29:47 GMT, Alexey Semenyuk wrote:
> 8333452: Make logging in jdk.jpackage.internal.OverridableResource class
> configurable
@sashamatveev, please review
-
PR Comment: https://git.openjdk.org/jdk/pull/19532#issuecomment-2146097131
On Mon, 3 Jun 2024 20:29:47 GMT, Alexey Semenyuk wrote:
> 8333452: Make logging in jdk.jpackage.internal.OverridableResource class
> configurable
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/19532
On Mon, 3 Jun 2024 21:53:06 GMT, Alexander Matveev wrote:
> This added functionality is not used. It is completely unclear from PR and/or
> issue description why we need this and how it will be used in the future?
It was supposed to be used in [WiX4
project](https://bugs.openjdk.org/browse/JDK
On Tue, 4 Jun 2024 01:24:15 GMT, Alexander Matveev wrote:
> Is there plan to add support for WiX 5?
This patch supports WiX5 as well. There is not much difference between WiX4 and
WiX5 from jpackage perspective. I'll update the description
-
PR Comment: https://git.openjdk.org/jdk
On Tue, 4 Jun 2024 02:38:51 GMT, Alexander Matveev wrote:
> I assume WiX5 will just work if installed instead of WiX4?
Correct.
> Do you think it will make sense to introduce Wix5 ToolsetType in case if we
> need to do something different between 4 and 5?
They claim WiX5 is backward compatibl
On Fri, 31 May 2024 14:05:07 GMT, Alexey Semenyuk wrote:
> Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app
> launcher instead of raw Executor. This makes MainClassTest test run app
> launchers with retries. This change addresses the primary issue.
On Tue, 4 Jun 2024 06:43:12 GMT, Alan Bateman wrote:
> If I read JDK-8269403 correctly then there is an issue somewhere that hasn't
> been diagnosed.
Correct.
> A workaround has been put in to "re-run" when there is a crash, thus hiding
> the issue.
Correct.
> Are there follow-up issues cre
On Tue, 4 Jun 2024 01:07:15 GMT, Alexander Matveev wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> EOLs restored
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resour
On Wed, 5 Jun 2024 04:20:17 GMT, Alexander Matveev wrote:
>> Alexey Semenyuk has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - WixSourceConverter#applyTo should do what
>> OverridableResource#saveToFile()
On Tue, 4 Jun 2024 01:20:15 GMT, Alexander Matveev wrote:
> Do we need to handle default case for unknown wix type? In same cases you
> have default -> throw new IllegalArgumentException(); and in some you do not
> have.
Good catch. I'll update the code to make `switch(wixVersion) ...` expres
On Wed, 5 Jun 2024 03:54:46 GMT, Alexander Matveev wrote:
>> Alexey Semenyuk has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - WixSourceConverter#applyTo should do what
>> OverridableResource#saveToFile()
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Tue, 4 Jun 2024 07:13:15 GMT, Vanitha B P wrote:
> Created jtreg test case for
> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>
> The JpackageTest created tests that the child process started from the app
> launched by jpackage launcher is not automatically terminated w
On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Tue, 9 Jul 2024 10:49:06 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Tue, 9 Jul 2024 16:12:58 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically termina
On Wed, 24 Jul 2024 12:20:05 GMT, Vanitha B P wrote:
> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
> fixed the issue and changes are tested.
Changes requested by asemenyuk (Reviewer).
@sashamatveev please review
test/jdk/tools/jpackage/apps/ChildProcessAppLaunc
On Thu, 25 Jul 2024 08:40:44 GMT, Vanitha B P wrote:
>> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
>> fixed the issue and changes are tested.
>
> Vanitha B P has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
Hi Bernd,
The issue with the infinite directory tree you observe looks like a
duplicate of [1].
You can add "--verbose" option to jpackage command line to get more
details on what is going on with jpackage.
There is no way to configure the list of directories where native
launcher is looki
On Wed, 28 Sep 2022 09:40:56 GMT, KIRIYAMA Takuya wrote:
> It is difficult to add all the encodings, so I will fix for Japanese and
> would like people who need other languages to do the same.
It would be good to have a comment in the source code describing that this
works only for Japanese en
On Thu, 29 Sep 2022 08:04:07 GMT, KIRIYAMA Takuya wrote:
>> test/jdk/tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java line
>> 55:
>>
>>> 53: String encoding = System.getProperty("native.encoding");
>>> 54: switch (encoding) {
>>> 55: default:
>>
>> What I me
On Thu, 29 Sep 2022 18:17:18 GMT, Naoto Sato wrote:
>> I agree skipping the test is not the best solution. Leaving a hint in the
>> comments on how to fix the issue looks better alternative.
>
> Well, what concerns me with the current fix is that it is simply patching
> only the case for the Ja
On Wed, 28 Sep 2022 09:45:32 GMT, KIRIYAMA Takuya wrote:
>> Could you please review the JDK-8293579 bug fixes?
>>
>> tools/jpackage/share/jdk/jpackage/tests/UnicodeArgsTest.java attempts to
>> give
>> the launcher the character which is encoded by Windows API
>> WideCharToMultiByte()
>> from
On Mon, 3 Oct 2022 09:39:08 GMT, KIRIYAMA Takuya wrote:
>> I don't think it will be many practical setups where this test fails. This
>> test has been around for more than 2 years and this is the first accident.
>
> At least, the results in different encodings are the same as before the fix.
> H
On Mon, 17 Oct 2022 14:41:06 GMT, Julian Waters wrote:
>> Some external libraries required by native code are linked via linker
>> comments embedded in pragmas. Searching for which libraries are linked can
>> then become frustrating and confusing since they may be included in an
>> obscure pla
On Mon, 17 Oct 2022 17:37:11 GMT, Erik Joelsson wrote:
> I believe this is part of the effort for
> https://bugs.openjdk.org/browse/JDK-8288293.
Agree. I'd prefer to have a different description of the bug though to make it
clear that this is necessary for decoupling a compiler and an OS.
---
On Fri, 4 Nov 2022 23:26:00 GMT, Alexander Matveev wrote:
> Changed names of symbolic links for drag and drop location in DMG image. See
> attached images in JBS.
> "/Applications" -> "Applications" for app DMG image.
> "/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime DMG
On Sat, 5 Nov 2022 01:08:11 GMT, Alexander Matveev wrote:
>> Changed names of symbolic links for drag and drop location in DMG image. See
>> attached images in JBS.
>> "/Applications" -> "Applications" for app DMG image.
>> "/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime
On Wed, 9 Nov 2022 20:02:05 GMT, Alexander Matveev wrote:
> Additional DMG content will be arranged in raws with 3 items per raw. DMG
> windows will be resized to show one or two raws without any scrolling
> required. To see any additional content after two raws (7 or more items) user
> will n
Simply increase timeout limit to make test pass on slower/loaded hosts
-
Commit messages:
- 8296489: tools/jpackage/windows/WinL10nTest.java fails with timeout
Changes: https://git.openjdk.org/jdk/pull/11522/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11522&range=00
Is
- throw an exception if icon swap fails with the corresponding l10n message;
- add retries to the jpackage test routine that extracts an icon from a launcher
-
Commit messages:
- 8293453: tools/jpackage/share/AddLShortcutTest.java "Failed: Check the
number of mismatched pixels [1024
On Mon, 5 Dec 2022 22:14:50 GMT, Alexey Semenyuk wrote:
> - throw an exception if icon swap fails with the corresponding l10n message;
> - add retries to the jpackage test routine that extracts an icon from a
> launcher
This pull request has now been integrated.
Changeset: 884b9a
On Mon, 5 Dec 2022 22:20:19 GMT, Alexey Semenyuk wrote:
> Simply increase timeout limit to make test pass on slower/loaded hosts
This pull request has now been integrated.
Changeset: 8d8a28ff
Author: Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/com
On Mon, 12 Dec 2022 21:23:50 GMT, Alexander Matveev
wrote:
> This issue is similar to JDK-8277493. Looks like macOS 13 cannot execute
> unsigned code and code should be at least ad hoc signed. Same as for macOS
> aarch64. Fixed by enabling ad hoc signing for macOS platform for both x64 and
>
8299278: tools/jpackage/share/AddLauncherTest.java#id1 failed
AddLauncherTest.bug8230933
-
Commit messages:
- Comment fixed
- 8299278: tools/jpackage/share/AddLauncherTest.java#id1 failed
AddLauncherTest.bug8230933
Changes: https://git.openjdk.org/jdk/pull/11868/files
Webrev: ht
Hi David,
The request to adjust osx linker command lines looks reasonable. Please
go ahead with a pull request.
- Alexey
On 1/9/2023 1:21 AM, David Holmes wrote:
On 8/01/2023 8:39 pm, David Schumann wrote:
Hello,
I'm not 100% sure if this list is the correct one for this topic,
feel free
Increase failed test timeouts.
Simple tests got an x1.5 increase and parametrized tests got an x2 increase
-
Commit messages:
- 8298735: Some tools/jpackage/windows/* tests fails with jtreg test timeout
Changes: https://git.openjdk.org/jdk/pull/11914/files
Webrev: https://webrevs.o
On Mon, 9 Jan 2023 22:53:18 GMT, Alexey Semenyuk wrote:
> Increase failed test timeouts.
> Simple tests got an x1.5 increase and parametrized tests got an x2 increase
This pull request has now been integrated.
Changeset: 3c99e786
Author:Alexey Semenyuk
URL:
https://git.openj
On Thu, 5 Jan 2023 20:10:45 GMT, Alexey Semenyuk wrote:
> 8299278: tools/jpackage/share/AddLauncherTest.java#id1 failed
> AddLauncherTest.bug8230933
This pull request has now been integrated.
Changeset: c595f965
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 22:33:24 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Tue, 24 Jan 2023 23:56:23 GMT, Damon Nguyen wrote:
>> Open l10n drop. Files have been updated with translated versions. Whitespace
>> tool has been ran on files.
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revisi
On Mon, 27 Feb 2023 08:19:53 GMT, Julian Waters wrote:
> JniObjWithEnv is a struct that is commonly managed by std::unique_ptr.
> Although it can support managing objects that are not raw pointers, any such
> objects have to be
> [NullablePointers](https://en.cppreference.com/w/cpp/named_req/N
On Tue, 7 Mar 2023 00:56:02 GMT, Alexander Matveev wrote:
> - Fixed by increasing test timeout. Fix verified on host which reproduced
> issue.
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12896
On Tue, 7 Mar 2023 00:56:02 GMT, Alexander Matveev wrote:
> - Fixed by increasing test timeout. Fix verified on host which reproduced
> issue.
Marked as reviewed by asemenyuk (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/12896
On Wed, 15 Mar 2023 11:46:22 GMT, Matthias Baesken wrote:
> The test fails on Alpine Linux 3.17, when checking the environment variable
> LD_LIBRARY_PATH; looks like the actual env variable is much longer than the
> test expects. It turned out that at least on Linux (probably also on other OS
On Thu, 16 Mar 2023 09:08:08 GMT, Matthias Baesken wrote:
>> The test fails on Alpine Linux 3.17, when checking the environment variable
>> LD_LIBRARY_PATH; looks like the actual env variable is much longer than the
>> test expects. It turned out that at least on Linux (probably also on other
On Thu, 16 Mar 2023 09:03:36 GMT, Matthias Baesken wrote:
>> test/jdk/tools/jpackage/share/AppLauncherEnvTest.java line 93:
>>
>>> 91: } else {
>>> 92: TKit.assertEquals(expectedEnvVarValue, actualEnvVarValue,
>>> msg);
>>> 93: }
>>
>> I'd keep the check as a single
On Mon, 13 Mar 2023 16:50:51 GMT, Alexander Matveev
wrote:
> This is similar to many other issues we had with `hdiutil` failures. Fixed in
> similar way by repeating `hdiutil` command. Cannot confirm that it will
> resolve this issue, but similar issues got resolved by repeating command.
> Al
When `--main-jar` is specified and the name of the main class is picked from
the jar's manifest, set `app.jarfile` property in launcher cfg file instead of
`app.mainclass` and `app.classpath` properties to make app launcher run the app
from the jar and not as a class from the classpath.
---
On Mon, 10 Apr 2023 21:16:19 GMT, Alexey Semenyuk wrote:
> When `--main-jar` is specified and the name of the main class is picked from
> the jar's manifest, set `app.jarfile` property in launcher cfg file instead
> of `app.mainclass` and `app.classpath` properties to make ap
On Mon, 10 Apr 2023 21:16:19 GMT, Alexey Semenyuk wrote:
> When `--main-jar` is specified and the name of the main class is picked from
> the jar's manifest, set `app.jarfile` property in launcher cfg file instead
> of `app.mainclass` and `app.classpath` properties to make ap
On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The chec
On Thu, 18 May 2023 21:25:26 GMT, Alexander Matveev
wrote:
> did we test jpackage on AIX system?
I don't think so. What is the native packaging on this platform?
-
PR Comment: https://git.openjdk.org/jdk/pull/13586#issuecomment-1553675715
Run a script extracting icons from executables as PowerShell command line
rather than a script
-
Commit messages:
- 8287401: jpackage tests failing on Windows due to powershell issue
Changes: https://git.openjdk.org/jdk19/pull/26/files
Webrev: https://webrevs.openjdk.org/?repo=jdk
On Thu, 16 Jun 2022 05:15:27 GMT, Alexey Semenyuk wrote:
> Run a script extracting icons from executables as PowerShell command line
> rather than a script
This pull request has now been integrated.
Changeset: c254c9d0
Author:Alexey Semenyuk
URL:
https://git.openjdk.org
On Thu, 16 Jun 2022 18:21:02 GMT, Alexander Matveev
wrote:
>> - Error will be thrown if app image is generated with another JDK version or
>> has malformed .jpackage.xml.
>> - Re-fixed as Alexey suggested in
>> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9098__;!!ACWV5N9M2
On Thu, 16 Jun 2022 18:14:45 GMT, Alexander Matveev
wrote:
>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java line 272:
>>
>>> 270: ));
>>> 271: }
>>> 272:
>>
>> 1. This is jpackage specific, so it should belong to JPackageCommand class.
>> 2. Please use proper XML
On Fri, 17 Jun 2022 04:07:47 GMT, Alexander Matveev
wrote:
>> - Error will be thrown if app image is generated with another JDK version or
>> has malformed .jpackage.xml.
>> - Re-fixed as Alexey suggested in
>> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9098__;!!ACWV5N9M2
On Fri, 17 Jun 2022 21:49:55 GMT, Alexander Matveev
wrote:
>> - Error will be thrown if app image is generated with another JDK version or
>> has malformed .jpackage.xml.
>> - Re-fixed as Alexey suggested in
>> https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/9098__;!!ACWV5N9M2
On Wed, 22 Jun 2022 11:53:39 GMT, Alex Kasko wrote:
> Please review this minor fix to the jpackage test suite.
>
> When `INSTALL` and `UNINSTALL` actions are enabled for jpackage test suite
> runs (disabled by default), installation of `EXE` and `MSI` packages is
> performed. `EXE` package is
On Wed, 8 Jun 2022 11:46:42 GMT, Alex Kasko wrote:
> In jpackage test suite there is a test utility
> WindowsHelper.queryRegistryValue . It is used to verify changes to Windows
> registry that can be done by installer packages. It spawns `reg.exe query`
> process and parses its output. This pa
On Tue, 21 Jun 2022 09:30:30 GMT, Alex Kasko wrote:
> jpackage implementation of file association on Windows currently passes a
> selected filename as an only argument to associated executable.
>
> It is proposed to introduce additional option in file association property
> file to allow optio
On Tue, 21 Jun 2022 09:30:30 GMT, Alex Kasko wrote:
> jpackage implementation of file association on Windows currently passes a
> selected filename as an only argument to associated executable.
>
> It is proposed to introduce additional option in file association property
> file to allow optio
On Tue, 28 Jun 2022 21:03:28 GMT, Alex Kasko wrote:
> I assume we will need an additional similar property for a verb label
> displayed in a context menu.
Agree. At least we need to provide l10n for it.
> Can we change the existing default behaviour? Should we? It won't break
> existing usage
On Wed, 29 Jun 2022 12:30:05 GMT, Alex Kasko wrote:
> For runtime installers it would be great to have a custom verb label, to be
> able to use something like: "Open with VendorName OpenJDK". I intend to
> prototype this and file in a separate PR
Sounds good.
> %* contains all the arguments b
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev
wrote:
> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG
> or PKG otherwise it invalidates signature.
> - .package should be created when app image is generated, so th
On Wed, 29 Jun 2022 03:03:15 GMT, Alexander Matveev
wrote:
> Fixed 3 issues which made signature invalid:
> - We should not remove .jpackage.xml from signed app image when creating DMG
> or PKG otherwise it invalidates signature.
> - .package should be created when app image is generated, so th
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association property
>> file to allow o
On Mon, 4 Jul 2022 23:38:08 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association property
>> file to allow o
On Wed, 29 Jun 2022 12:29:33 GMT, Alex Kasko wrote:
>> jpackage implementation of file association on Windows currently passes a
>> selected filename as an only argument to associated executable.
>>
>> It is proposed to introduce additional option in file association property
>> file to allow
On Thu, 7 Jul 2022 19:30:07 GMT, Alexander Matveev wrote:
>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacBaseInstallerBundler.java
>> line 171:
>>
>>> 169:
>>> Files.deleteIfExists(AppImageFile.getPathInAppImage(appDir));
>>> 170: }
>>> 171:
>>
>> I think ther
On Thu, 7 Jul 2022 07:27:56 GMT, Alexander Matveev wrote:
>> Fixed 3 issues which made signature invalid:
>> - We should not remove .jpackage.xml from signed app image when creating DMG
>> or PKG otherwise it invalidates signature.
>> - .package should be created when app image is generated, so
On Fri, 8 Jul 2022 00:14:27 GMT, Alexander Matveev wrote:
>> Fixed 3 issues which made signature invalid:
>> - We should not remove .jpackage.xml from signed app image when creating DMG
>> or PKG otherwise it invalidates signature.
>> - .package should be created when app image is generated, so
8283707: Support version format on Windows
-
Commit messages:
- Create separate tests for the new feature.
- Trailing whitespaces fixed
- Better test coverage
- Bugfixes after manual testing
- 8283707: Support version format on Windows
Changes: https://git.openjdk.org/jdk/pull
8290398: jpackage exe instellers are not installed in jtreg tests
-
Commit messages:
- 8290398: jpackage exe instellers are not installed in jtreg tests
Changes: https://git.openjdk.org/jdk/pull/9530/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9530&range=00
Issue: http
8290400: Must run exe installers in jpackage jtreg tests without UI
-
Commit messages:
- 8290400: Must run exe installers in jpackage jtreg tests without UI
Changes: https://git.openjdk.org/jdk/pull/9531/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9531&range=00
Issue:
8290402: jpackage exe uninstallers don't return correct exit code in case of
failure
-
Commit messages:
- 8290402: jpackage exe uninstallers don't return correct exit code in case of
failure
Changes: https://git.openjdk.org/jdk/pull/9532/files
Webrev: https://webrevs.openjdk.org/
> 8283707: Support version format on Windows
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Comments fixed and better naming in the code.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/9507/files
-
On Mon, 18 Jul 2022 22:01:09 GMT, Alexander Matveev
wrote:
>> 8290402: jpackage exe uninstallers don't return correct exit code in case of
>> failure
>
> src/jdk.jpackage/windows/native/msiwrapper/MsiWrapper.cpp line 53:
>
>> 51:
>> 52: // Uninstall product.
>> 53: msi::Suppre
On Mon, 18 Jul 2022 22:33:15 GMT, Alex Kasko wrote:
> It is proposed to introduce support for `--win-codepage` argument, and
> substitute the `Codepage` attribute with `--win-codepage` specified value in
> primary l10n file when it is being copied to the config dir.
>
> Instead of copying all
On Sat, 16 Jul 2022 21:47:43 GMT, Alexey Semenyuk wrote:
> 8290402: jpackage exe uninstallers don't return correct exit code in case of
> failure
This pull request has now been integrated.
Changeset: d67e7ccd
Author:Alexey Semenyuk
URL:
https://git.openjdk.org
On Fri, 15 Jul 2022 04:37:58 GMT, Alexey Semenyuk wrote:
> 8283707: Support version format on Windows
This pull request has now been integrated.
Changeset: 977e0948
Author: Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/977e09489dd1f49d8f373ef7b8c5e47fedb82793
St
1 - 100 of 744 matches
Mail list logo
