On Thu, 16 Jun 2022 18:14:45 GMT, Alexander Matveev <almat...@openjdk.org> wrote:
>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TKit.java line 272: >> >>> 270: )); >>> 271: } >>> 272: >> >> 1. This is jpackage specific, so it should belong to JPackageCommand class. >> 2. Please use proper XML API to create XML output. >> 3. Having `<app-version>1.0</app-version>` in .jpackage.xml file will make >> `AppImageFile.isValid()` return `false` and `AppImageFile.load()` to throw >> exception. This seems to be equivalent to not having .jpackage.xml file in >> app image at all raising a question if this new function is needed at all. > > 1 and 2 done. I think you mistaken `<app-version>1.0</app-version>` with > `<jpackage-state version="%s"`. We never read <app-version> and I do put > correct value for `<jpackage-state version="%s"`. It is required for several > tests which uses empty/dummy app images and since we started required > .jpackage.xml file we need it for empty app images as well. Right! My bad, sorry for the confusion. ------------- PR: https://git.openjdk.org/jdk19/pull/9
