Withdrawn: 8346230: [perf] scalability issue for the specjvm2008::xml.transform workload

2025-03-18 Thread duke
On Fri, 17 Jan 2025 23:08:20 GMT, Vladimir Ivanov wrote: > The HashMap for caching was deleted. Now it use only ThreadLocal variable > without synchronization. > According to the specjvm2008::xml.transform workload the performance for low > threads counts was not affected and improved for high

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Lance Andersen
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote: >> Add public identifiers to the JDK built-in Catalog; Replace the incorrect >> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct >> Shema 1.0 DTDs. > > Joe Wang has updated the pull request incrementally with one addi

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Joe Wang
On Tue, 18 Mar 2025 18:50:24 GMT, Roger Riggs wrote: > The XMLSchema.dtd changes the referenced version from the 2009 version to the > 2001 version. Is that intentional. Yes. Note the Public Identifier: "-//W3C//DTD XSD 1.1//EN" vs "-//W3C//DTD XMLSCHEMA 200102//EN" at line 2. The 2009 version

Re: RFR: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage

2025-03-18 Thread Justin Lu
On Tue, 18 Mar 2025 18:37:17 GMT, Alexey Semenyuk wrote: >> Follow up code cleanup for https://github.com/openjdk/jdk/pull/23936 PR. >> >> Details on cleanup actions are given in commit descriptions. > > @justin-curtis-lu PTAL. Is it a valid assumption that removing property keys > from the mai

Integrated: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-18 Thread Matthias Baesken
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. This pull req

Re: RFR: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings

2025-03-18 Thread Matthias Baesken
On Fri, 14 Mar 2025 11:15:26 GMT, Matthias Baesken wrote: > On Linux there are some special settings for LIBVERIFY_OPTIMIZATION that are > most likely not needed any more and could be removed. > The removal (on Linux) brings the lib optimization level de facto from LOW to > HIGH. Thanks for th

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Erik Joelsson
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. make/modules/java.base/Copy.gmk line 128: > 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \ >

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Erik Joelsson
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. If we want to support CDS archives for the imported JVMs, then we would need to modify the loop i

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Magnus Ihse Bursie
On Tue, 18 Mar 2025 13:09:10 GMT, Erik Joelsson wrote: > If we want to support CDS archives for the imported JVMs, then we would need > to modify the loop in Images.gmk so that it covers them as well. I think that > makes sense to do. Yes, I agree. That, and importing the whole directory, is t

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher [v2]

2025-03-18 Thread Joachim Kern
> After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now with this change we can enable the statically linked launch

Re: RFR: 8342382: Implementation of JEP G1: Improve Application Throughput with a More Efficient Write-Barrier [v24]

2025-03-18 Thread Thomas Schatzl
> Hi all, > > please review this change that implements (currently Draft) JEP: G1: > Improve Application Throughput with a More Efficient Write-Barrier. > > The reason for posting this early is that this is a large change, and the JEP > process is already taking very long with no end in sight

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool [v2]

2025-03-18 Thread Dmitry Chuyko
> Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) > in one case when TC subfield in ctl field is decremented, the applied masking > (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. In JDKs > prior to 19 FJP may stop executing tasks, which requires

Re: RFR: 8351933: Inaccurate masking of TC subfield decrement in ForkJoinPool

2025-03-18 Thread Dmitry Chuyko
On Thu, 13 Mar 2025 13:34:51 GMT, Dmitry Chuyko wrote: > Please review a tiny fix in the ForkJoinPool. Since JDK 9 (JDK-8134852 [1]) > in one case when TC subfield in ctl field is decremented, the applied masking > (UMASK, upper bits) may not preserve neighbor RC subfield sometimes. In JDKs >

Re: RFR: 8345687: Improve the implementation of SegmentFactories::allocateSegment [v7]

2025-03-18 Thread Quan Anh Mai
On Thu, 13 Mar 2025 16:21:07 GMT, Maurizio Cimadamore wrote: >> Quan Anh Mai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> expand wildcard imports > > Marked as reviewed by mcimadamore (Reviewer). @mcimadamore @JornVernee Thanks a lo

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-18 Thread Magnus Ihse Bursie
On Tue, 18 Mar 2025 10:44:46 GMT, Joachim Kern wrote: >> Ups, thank you for giving me the 'S'. But nevertheless if I make with >> `make all LOG=info` an `$(info generate_export_list: >> $(generate_export_list))` still shows an empty list > > I did not get the SetupExecute to function, even if I

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Magnus Ihse Bursie
On Mon, 17 Mar 2025 09:10:50 GMT, Alan Bateman wrote: > The discussion on jdk-dev was useful but I don't think adding > --with-import-jvms is the right direction. It's too fragile and loose to > import from a build created somewhere else. Why's that? It's more loose than just "importing" a jtr

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 15:49:44 GMT, Magnus Ihse Bursie wrote: > We should allow pre-built JVMs to be included in a build, so they are just > copied into place, and the jvm.cfg file properly updated. And to be absolutely clear: this PR is just about adding new functionality that was not present b

RFR: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage

2025-03-18 Thread Alexey Semenyuk
Follow up code cleanup for https://github.com/openjdk/jdk/pull/23936 PR. Details on cleanup actions are given in commit descriptions. - Commit messages: - Update copyright year - "message.version-string-too-many-components" ID is not used - Remove dead code. ERR_NoJreInstallerName

Integrated: 8345687: Improve the implementation of SegmentFactories::allocateSegment

2025-03-18 Thread Quan Anh Mai
On Fri, 6 Dec 2024 16:30:47 GMT, Quan Anh Mai wrote: > Hi, > > This patch improves the performance of a typical `Arena::allocate` in several > ways: > > - Delay the creation of the NativeMemorySegmentImpl. This avoids the merge of > the instance with the one obtained from the call in the unco

Re: RFR: 8352064: AIX: now also able to build static-jdk image with a statically linked launcher

2025-03-18 Thread Magnus Ihse Bursie
On Fri, 14 Mar 2025 15:41:56 GMT, Joachim Kern wrote: > After "JDK-8339480: Build static-jdk image with a statically linked launcher" > AIX was not able to build the new target. Therefore with "JDK-8345590 AIX > 'make all' fails after JDK-8339480" the new target was disabled again. > > Now wit

Re: RFR: 8352044: Add --with-import-jvms to configure

2025-03-18 Thread Erik Joelsson
On Tue, 18 Mar 2025 13:12:16 GMT, Magnus Ihse Bursie wrote: >> make/modules/java.base/Copy.gmk line 128: >> >>> 126: $(foreach import_jvm, $(IMPORT_JVM_NAMES), \ >>> 127: $(eval $(import_jvm)_path := $(patsubst $(import_jvm):%,%,$(filter >>> $(import_jvm):%, $(IMPORT_JVMS \ >>> 128:

Re: RFR: 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372

2025-03-18 Thread Alexey Semenyuk
On Tue, 18 Mar 2025 18:11:36 GMT, Alexey Semenyuk wrote: > Fix a typo. @sashamatveev PTAL - PR Comment: https://git.openjdk.org/jdk/pull/24101#issuecomment-2734354464

RFR: 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372

2025-03-18 Thread Alexey Semenyuk
Fix a typo. - Commit messages: - 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372 Changes: https://git.openjdk.org/jdk/pull/24101/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24101&range=00 Issue: https://bugs.openjdk.org/browse/JDK

Re: RFR: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage

2025-03-18 Thread Alexey Semenyuk
On Tue, 18 Mar 2025 15:25:40 GMT, Alexey Semenyuk wrote: > Follow up code cleanup for https://github.com/openjdk/jdk/pull/23936 PR. > > Details on cleanup actions are given in commit descriptions. @sashamatveev PTAL - PR Comment: https://git.openjdk.org/jdk/pull/24099#issuecomment

Re: RFR: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage

2025-03-18 Thread Alexander Matveev
On Tue, 18 Mar 2025 15:25:40 GMT, Alexey Semenyuk wrote: > Follow up code cleanup for https://github.com/openjdk/jdk/pull/23936 PR. > > Details on cleanup actions are given in commit descriptions. Looks good. - Marked as reviewed by almatvee (Reviewer). PR Review: https://git.ope

Integrated: 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372

2025-03-18 Thread Alexey Semenyuk
On Tue, 18 Mar 2025 18:11:36 GMT, Alexey Semenyuk wrote: > Fix a typo. This pull request has now been integrated. Changeset: c8a11f28 Author:Alexey Semenyuk URL: https://git.openjdk.org/jdk/commit/c8a11f28dff58382f943b3615ca8c7e33d6eab8e Stats: 1 line in 1 file changed: 0 ins; 0

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Roger Riggs
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote: >> Add public identifiers to the JDK built-in Catalog; Replace the incorrect >> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct >> Shema 1.0 DTDs. > > Joe Wang has updated the pull request incrementally with one addi

Re: RFR: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK

2025-03-18 Thread David Holmes
On Tue, 18 Mar 2025 18:57:04 GMT, Jiangli Zhou wrote: > Please review this PR that adds `@requires !jdk.static` to tests, thanks. > > - runtime/StackGap/TestStackGap.java > - runtime/StackGuardPages/TestStackGuardPages.java > - runtime/TLS/TestTLS.java > - runtime/jni/daemonDestroy/TestDaemonDes

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Joe Wang
On Tue, 18 Mar 2025 19:05:32 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the test: change variables and etc. > > test/jaxp/javax/xml/jaxp/unittest/common/jdkcatalog/JDKCatalogTest.java line

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v3]

2025-03-18 Thread Joe Wang
> Add public identifiers to the JDK built-in Catalog; Replace the incorrect > Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct > Schema 1.0 DTDs. The JDK built-in Catalog contains Schema 1.0 files only. > > DTD files: the Schema 1.1 files, XMLSchema.dtd and datatypes.

Re: RFR: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK

2025-03-18 Thread Jiangli Zhou
On Wed, 19 Mar 2025 00:29:49 GMT, David Holmes wrote: > @jianglizhou shouldn't these native executables be built differently to work > with the static JDK? Otherwise how does a user create a native executable > that launches the JVM? I think it's the case of using customized launcher and we ne

Integrated: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage

2025-03-18 Thread Alexey Semenyuk
On Tue, 18 Mar 2025 15:25:40 GMT, Alexey Semenyuk wrote: > Follow up code cleanup for https://github.com/openjdk/jdk/pull/23936 PR. > > Details on cleanup actions are given in commit descriptions. This pull request has now been integrated. Changeset: 8e530633 Author:Alexey Semenyuk URL:

Re: RFR: 8351565: Implement JEP 502: Stable Values (Preview) [v6]

2025-03-18 Thread John R Rose
On Thu, 13 Mar 2025 15:22:43 GMT, Per Minborg wrote: >> Implement JEP 502. >> >> The PR passes tier1-tier3 tests. > > Per Minborg has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains 246 commits: > > - Merge branch 'master' into imple

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Iris Clark
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote: >> Add public identifiers to the JDK built-in Catalog; Replace the incorrect >> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct >> Shema 1.0 DTDs. > > Joe Wang has updated the pull request incrementally with one addi

Re: RFR: 8352107: Allow jtreg test cases to query test VM properties

2025-03-18 Thread Leonid Mesnik
On Sun, 16 Mar 2025 02:54:36 GMT, Ioi Lam wrote: > This PR tries to cut down the use of `WhiteBox` in the HotSpot test cases. It > modifies `VMProps` to save the set of VM properties into a file called > "vm.properties" under Jtreg's work directory. The new API > `jdk.test.lib.VMPropsGetter` l

Re: RFR: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK

2025-03-18 Thread Jiangli Zhou
On Tue, 18 Mar 2025 18:57:04 GMT, Jiangli Zhou wrote: > Please review this PR that adds `@requires !jdk.static` to tests, thanks. > > - runtime/StackGap/TestStackGap.java > - runtime/StackGuardPages/TestStackGuardPages.java > - runtime/TLS/TestTLS.java > - runtime/jni/daemonDestroy/TestDaemonDes

Integrated: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run

2025-03-18 Thread Kim Barrett
On Fri, 7 Mar 2025 23:17:53 GMT, Kim Barrett wrote: > Please review this revision of a previously puzzling comment intending to > provide the rationale for a bit of non-obvious code. This pull request has now been integrated. Changeset: 355b2f3b Author:Kim Barrett URL: https://git.o

RFR: 8352176: Automate setting up environment for mac signing tests

2025-03-18 Thread Alexey Semenyuk
Automate setting up an environment for mac signing tests: create keychain(s), self-signing certificates, and register them in the system. To set up the environment, run `make test-only TEST=test/jdk/tools/jpackage/macosx/base/SigningBase.java JTREG=JAVA_OPTIONS=-Djpackage.test.SignEnv=setup` co

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Joe Wang
On Tue, 18 Mar 2025 18:26:09 GMT, Roger Riggs wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> update the test: change variables and etc. > > src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/w3c/dtd/schema10/XMLSc

Re: RFR: 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372

2025-03-18 Thread Alexander Matveev
On Tue, 18 Mar 2025 18:11:36 GMT, Alexey Semenyuk wrote: > Fix a typo. Looks good. - Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24101#pullrequestreview-2696339103

Re: RFR: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run [v2]

2025-03-18 Thread Kim Barrett
On Mon, 17 Mar 2025 17:22:10 GMT, Kim Barrett wrote: >> Please review this revision of a previously puzzling comment intending to >> provide the rationale for a bit of non-obvious code. > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revisio

RFR: 8352276: Skip jtreg tests using native executable with libjvm.so/libjli.so dependencies on static JDK

2025-03-18 Thread Jiangli Zhou
Please review this PR that adds `@requires !jdk.static` to tests, thanks. - runtime/StackGap/TestStackGap.java - runtime/StackGuardPages/TestStackGuardPages.java - runtime/TLS/TestTLS.java - runtime/jni/daemonDestroy/TestDaemonDestroy.java - runtime/jni/getCreatedJavaVMs/TestGetCreatedJavaVMs.java

Re: RFR: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage

2025-03-18 Thread Alexey Semenyuk
On Tue, 18 Mar 2025 15:25:40 GMT, Alexey Semenyuk wrote: > Follow up code cleanup for https://github.com/openjdk/jdk/pull/23936 PR. > > Details on cleanup actions are given in commit descriptions. @justin-curtis-lu PTAL. Is it a valid assumption that removing property keys from the main L10N p

Re: RFR: 8351969: Add Public Identifiers to the JDK built-in Catalog [v2]

2025-03-18 Thread Roger Riggs
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote: >> Add public identifiers to the JDK built-in Catalog; Replace the incorrect >> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct >> Shema 1.0 DTDs. > > Joe Wang has updated the pull request incrementally with one addi