Follow up code cleanup for https://github.com/openjdk/jdk/pull/23936 PR.

Details on cleanup actions are given in commit descriptions.

-------------

Commit messages:
 - Update copyright year
 - "message.version-string-too-many-components" ID is not used
 - Remove dead code. ERR_NoJreInstallerName is never used because in case of 
runtime packaging the name always available - it is picked from the name of 
runtime image directory (the value of `--runtime-image` option) if `--name` is 
missing.
 - Remove dead code. `ERR_InputNotDirectory` and `ERR_CannotReadInputDir` are 
not referenced
 - Remove dead code. `ERR_MissingAppResources` is not referenced
 - Remove dead code. Exception with `error.no.name` can not be thrown from 
WinMsiBundler.prepareProto() because app name is validated earlier.
 - Remove unreferenced `message.app-image-dir-does-not-exist` and 
`message.app-image-dir-does-not-exist.advice` keys
 - Remove dead code. Exceptions with `message.app-image-dir-does-not-exist` id 
never thrown, because DeployParams.validate() would throw 
`ERR_AppImageNotExist` early
 - Remove dead code. `message.app-image-requires-app-name` can not be reported 
because if name is not explicitly specified, jpackage will use name from the 
external app image. In other words, there is no need to set app name if 
`--app-image` is specified.
 - Remove dead code. Exception with `message.app-image-requires-identifier` id 
will never be thrown from MacPkgBundler because bundle identifier will fallback 
to app name in the worst case scenario. app name is validated before 
MacPkgBundler.validate() is called.
 - ... and 3 more: https://git.openjdk.org/jdk/compare/19154f7a...c17e612c

Changes: https://git.openjdk.org/jdk/pull/24099/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24099&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8352275
  Stats: 76 lines in 9 files changed: 2 ins; 67 del; 7 mod
  Patch: https://git.openjdk.org/jdk/pull/24099.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24099/head:pull/24099

PR: https://git.openjdk.org/jdk/pull/24099

Reply via email to