On Thu, 3 Jul 2025 14:23:00 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/lang/Process.java line 113:
>>
>>> 111: * releasing the operating system resources.
>>> 112: * {@code Try-with-resources} can be used to open and close the
>>> streams.
>>> 113: * For example, to capture
On Thu, 3 Jul 2025 11:46:32 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix links per review comments and snippet syntax in
>> ProcessBuilder.Redirect.DISCARD.
>
> src/java.base/share/classes/
On Wed, 2 Jul 2025 14:52:06 GMT, Roger Riggs wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
>
On Wed, 2 Jul 2025 13:02:04 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc cleanup
>
> src/java.base/share/classes/java/lang/Process.java line 208:
>
>> 206: *
>> 207: * @apiNot
On Wed, 2 Jul 2025 14:46:20 GMT, Roger Riggs wrote:
> But including both links makes the sentence hard to read, so I picked the
> more expressive reader method to link to.
It didn't realize you had intentionally used the `CharSet` one. If you think
the CharSet would provide better guidance to
On Wed, 2 Jul 2025 14:49:01 GMT, Roger Riggs wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
>
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add advice and example using try-with-resources to open an
On Tue, 1 Jul 2025 22:30:57 GMT, Roger Riggs wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
>
On Fri, 27 Jun 2025 16:23:59 GMT, Jaikiran Pai wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc cleanup
>
> src/java.base/share/classes/java/lang/ProcessBuilder.java line 545:
>
>> 543: * {@snippet
On Tue, 1 Jul 2025 22:30:57 GMT, Roger Riggs wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
>
On Tue, 1 Jul 2025 22:30:57 GMT, Roger Riggs wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
>
On Tue, 1 Jul 2025 22:30:57 GMT, Roger Riggs wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
>
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add advice and example using try-with-resources to open an
On Fri, 27 Jun 2025 19:06:22 GMT, Roger Riggs wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add advice and example using try-with-resources to open an
On Fri, 27 Jun 2025 16:02:45 GMT, Jaikiran Pai wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
On Wed, 18 Jun 2025 20:16:18 GMT, Roger Riggs wrote:
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add
On Wed, 18 Jun 2025 20:16:18 GMT, Roger Riggs wrote:
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add
On Fri, 27 Jun 2025 16:12:53 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/lang/Process.java line 202:
>>
>>> 200: *
>>> 201: * @apiNote
>>> 202: * Avoid using both {@link #getInputStream} and {@link
>>> #inputReader(Charset)}.
>>
>> The reworded sentence I think
On Fri, 27 Jun 2025 16:09:02 GMT, Jaikiran Pai wrote:
>> Improve the documentation of Process use of system resources.
>>
>> Describe the implementation closing streams when no longer referenced.
>> Clarify the interactions between inputStream and inputReader and errorStream
>> and errorReader.
On Wed, 18 Jun 2025 20:16:18 GMT, Roger Riggs wrote:
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add
On Wed, 18 Jun 2025 20:16:18 GMT, Roger Riggs wrote:
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add
On Wed, 18 Jun 2025 20:16:18 GMT, Roger Riggs wrote:
> Improve the documentation of Process use of system resources.
>
> Describe the implementation closing streams when no longer referenced.
> Clarify the interactions between inputStream and inputReader and errorStream
> and errorReader.
> Add
23 matches
Mail list logo
