On Wed, 2 Jul 2025 13:02:04 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> javadoc cleanup
>
> src/java.base/share/classes/java/lang/Process.java line 208:
>
>> 206: *
>> 207: * @apiNote
>> 208: * Use either this method or an {@linkplain #inputReader(Charset)
>> input reader}
>
> I think this should be `{@linkplain #inputReader() input reader}` (i.e. the
> one that doesn't take a CharSet) to match what was there previously before
> the changes in this PR.
Conundrum... The readable text refers to "an input reader" and covers the case
of either inputReader method.
But including both links makes the sentence hard to read, so I picked the more
expressive reader method to link to.
Reverting to no-arg version.
Ditto below.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25884#discussion_r2180256774
