Re: RFR: 8359123: Misleading examples in jmod man page [v5]

2025-06-18 Thread duke
On Wed, 18 Jun 2025 07:17:13 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Re: RFR: 8359123: Misleading examples in jmod man page [v5]

2025-06-18 Thread Christian Stein
On Wed, 18 Jun 2025 07:17:13 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Re: RFR: 8359123: Misleading examples in jmod man page [v5]

2025-06-18 Thread Alan Bateman
On Wed, 18 Jun 2025 07:17:13 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Re: RFR: 8359123: Misleading examples in jmod man page [v5]

2025-06-18 Thread Ana Maria Mihalceanu
> Please review my PR. This PR includes the following: > > - [x] Fix a small typo in a word and copyright. > - [x] Enhance description for `--target-platform`. > - [x] Rearrange `jmod create` example from basic to complex. Ana Maria Mihalceanu has updated the pull request incrementally with one

Re: RFR: 8359123: Misleading examples in jmod man page [v4]

2025-06-18 Thread Ana Maria Mihalceanu
On Wed, 18 Jun 2025 07:02:59 GMT, Alan Bateman wrote: >> Ana Maria Mihalceanu has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update commands and description according to review. > > src/jdk.jlink/share/man/jmod.md line 186: > >> 184:

Re: RFR: 8359123: Misleading examples in jmod man page [v4]

2025-06-18 Thread Alan Bateman
On Tue, 17 Jun 2025 17:08:17 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Re: RFR: 8359123: Misleading examples in jmod man page [v4]

2025-06-17 Thread Iris Clark
On Tue, 17 Jun 2025 17:08:17 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Re: RFR: 8359123: Misleading examples in jmod man page [v4]

2025-06-17 Thread Ana Maria Mihalceanu
> Please review my PR. This PR includes the following: > > - [x] Fix a small typo in a word and copyright. > - [x] Enhance description for `--target-platform`. > - [x] Rearrange `jmod create` example from basic to complex. Ana Maria Mihalceanu has updated the pull request incrementally with one

Re: RFR: 8359123: Misleading examples in jmod man page [v3]

2025-06-17 Thread Ana Maria Mihalceanu
On Tue, 17 Jun 2025 16:51:19 GMT, Iris Clark wrote: >> Ana Maria Mihalceanu has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Enhance --target-platform explanation. > > src/jdk.jlink/share/man/jmod.md line 182: > >> 180: >> 181: `--targe

Re: RFR: 8359123: Misleading examples in jmod man page [v3]

2025-06-17 Thread Iris Clark
On Mon, 16 Jun 2025 19:59:06 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Re: RFR: 8359123: Misleading examples in jmod man page [v3]

2025-06-16 Thread Ana Maria Mihalceanu
> Please review my PR. This PR includes the following: > > - [x] Fix a small typo in a word and copyright. > - [x] Enhance description for `--target-platform`. > - [x] Rearrange `jmod create` example from basic to complex. Ana Maria Mihalceanu has updated the pull request incrementally with one

Re: RFR: 8359123: Misleading examples in jmod man page [v2]

2025-06-16 Thread Ana Maria Mihalceanu
On Mon, 16 Jun 2025 18:52:02 GMT, Alan Bateman wrote: >> Ana Maria Mihalceanu has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix whitespaces. >> - Update description of commands as per code review > > src/jdk.jlink/share/man/jmod.md

Re: RFR: 8359123: Misleading examples in jmod man page [v2]

2025-06-16 Thread Alan Bateman
On Sat, 14 Jun 2025 18:16:46 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Re: RFR: 8359123: Misleading examples in jmod man page [v2]

2025-06-16 Thread Alan Bateman
On Sat, 14 Jun 2025 18:16:46 GMT, Ana Maria Mihalceanu wrote: >> Please review my PR. This PR includes the following: >> >> - [x] Fix a small typo in a word and copyright. >> - [x] Enhance description for `--target-platform`. >> - [x] Rearrange `jmod create` example from basic to complex. > > An

Re: RFR: 8359123: Misleading examples in jmod man page [v2]

2025-06-14 Thread Ana Maria Mihalceanu
On Fri, 13 Jun 2025 17:07:20 GMT, Iris Clark wrote: >> Ana Maria Mihalceanu has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix whitespaces. >> - Update description of commands as per code review > > src/jdk.jlink/share/man/jmod.md li

Re: RFR: 8359123: Misleading examples in jmod man page [v2]

2025-06-14 Thread Ana Maria Mihalceanu
> Please review my PR. This PR includes the following: > > - [x] Fix a small typo in a word and copyright. > - [x] Enhance description for `--target-platform`. > - [x] Rearrange `jmod create` example from basic to complex. Ana Maria Mihalceanu has updated the pull request incrementally with two

Re: RFR: 8359123: Misleading examples in jmod man page

2025-06-13 Thread Iris Clark
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote: > Please review my PR. This PR includes the following: > > - [x] Fix a small typo in a word and copyright. > - [x] Enhance description for `--target-platform`. > - [x] Rearrange `jmod create` example from basic to complex. Changes re

Re: RFR: 8359123: Misleading examples in jmod man page

2025-06-12 Thread Christian Stein
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote: > Please review my PR. This PR includes the following: > > - [x] Fix a small typo in a word and copyright. > - [x] Enhance description for `--target-platform`. > - [x] Rearrange `jmod create` example from basic to complex. Marked as

RFR: 8359123: Misleading examples in jmod man page

2025-06-12 Thread Ana Maria Mihalceanu
Please review my PR. This PR includes the following: - [ ] Fix a small typo in a word and copyright - Commit messages: - Attempt to fix whitespaces - Apply suggestions from code review - Update jmod create examples - Update copyright text - Fix a small typo Changes: https://git

Re: RFR: 8359123: Misleading examples in jmod man page

2025-06-12 Thread Christian Stein
On Thu, 12 Jun 2025 07:57:20 GMT, Ana Maria Mihalceanu wrote: > Please review my PR. This PR includes the following: > > - [ ] Fix a small typo in a word and copyright src/jdk.jlink/share/man/jmod.md line 183: > 181: `--target-platform` *platform* > 182: : Specifies the target platform. The