On Mon, 16 Jun 2025 18:52:02 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Ana Maria Mihalceanu has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Fix whitespaces. >> - Update description of commands as per code review > > src/jdk.jlink/share/man/jmod.md line 183: > >> 181: `--target-platform` *platform* >> 182: : Specifies the target platform. The value is a string identifying >> 183: the module's intended platform, typically in the form `<os>-<arch>`. > > Maybe we could say that it specifies the target platform when creating a JMOD > file that is platform specific. The value is `<os>-<arch>` where `<os>` is > the operating system and `<arch>` is the architecture. Examples values are ... Thank you for the suggestion. Below is an excerpt from the update. Please let me know if it works. Specifies the target platform when creating a JMOD file intended for a specific operating system and architecture. The value should follow the format `<os>-<arch>`, where `<os>` is the operating system and `<arch>` is the hardware architecture. Example values include`linux-x64`, `windows-x64`, and `macos-aarch64`. > src/jdk.jlink/share/man/jmod.md line 205: > >> 203: --libs lib --main-class com.greetings.Main >> 204: --man-pages man --module-version 1.0 >> 205: --target-platform "macOS-aarch64" greetingsmod > > Can you change it to "macos-aarch64" as it is case sensitive. Thank you for spotting this. I updated both areas related to the target platform. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25772#discussion_r2150762624 PR Review Comment: https://git.openjdk.org/jdk/pull/25772#discussion_r2150757942
