Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-02 Thread Roger Riggs
On Wed, 2 Jul 2025 13:02:04 GMT, Jaikiran Pai wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> javadoc cleanup > > src/java.base/share/classes/java/lang/Process.java line 208: > >> 206: * >> 207: * @apiNot

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-02 Thread Jaikiran Pai
On Wed, 2 Jul 2025 14:46:20 GMT, Roger Riggs wrote: > But including both links makes the sentence hard to read, so I picked the > more expressive reader method to link to. It didn't realize you had intentionally used the `CharSet` one. If you think the CharSet would provide better guidance to

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-02 Thread Jaikiran Pai
On Tue, 1 Jul 2025 22:30:57 GMT, Roger Riggs wrote: >> Improve the documentation of Process use of system resources. >> >> Describe the implementation closing streams when no longer referenced. >> Clarify the interactions between inputStream and inputReader and errorStream >> and errorReader. >

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-02 Thread Roger Riggs
On Fri, 27 Jun 2025 16:23:59 GMT, Jaikiran Pai wrote: >> Roger Riggs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> javadoc cleanup > > src/java.base/share/classes/java/lang/ProcessBuilder.java line 545: > >> 543: * {@snippet

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-02 Thread Jaikiran Pai
On Tue, 1 Jul 2025 22:30:57 GMT, Roger Riggs wrote: >> Improve the documentation of Process use of system resources. >> >> Describe the implementation closing streams when no longer referenced. >> Clarify the interactions between inputStream and inputReader and errorStream >> and errorReader. >

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-02 Thread Jaikiran Pai
On Tue, 1 Jul 2025 22:30:57 GMT, Roger Riggs wrote: >> Improve the documentation of Process use of system resources. >> >> Describe the implementation closing streams when no longer referenced. >> Clarify the interactions between inputStream and inputReader and errorStream >> and errorReader. >

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-02 Thread Jaikiran Pai
On Tue, 1 Jul 2025 22:30:57 GMT, Roger Riggs wrote: >> Improve the documentation of Process use of system resources. >> >> Describe the implementation closing streams when no longer referenced. >> Clarify the interactions between inputStream and inputReader and errorStream >> and errorReader. >

Re: RFR: 8354872: Clarify java.lang.Process resource cleanup [v3]

2025-07-01 Thread Roger Riggs
> Improve the documentation of Process use of system resources. > > Describe the implementation closing streams when no longer referenced. > Clarify the interactions between inputStream and inputReader and errorStream > and errorReader. > Add advice and example using try-with-resources to open an