Re: RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException [v3]

2025-02-26 Thread Naoto Sato
On Wed, 26 Feb 2025 19:48:10 GMT, Justin Lu wrote: >> Please review this PR which prevents an `AIOOBE` from leaking out when >> `java.util.Calendar.Builder` is used to build a Japanese calendar with an >> era value too large. >> >> Note that we don't check under `BEFORE_MEIJI`/0 as historicall

Re: RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException [v3]

2025-02-26 Thread Justin Lu
> Please review this PR which prevents an `AIOOBE` from leaking out when > `java.util.Calendar.Builder` is used to build a Japanese calendar with an era > value too large. > > Note that we don't check under `BEFORE_MEIJI`/0 as historically Japanese > calendar ignores negative values during norm

Re: RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException [v2]

2025-02-26 Thread Justin Lu
On Wed, 26 Feb 2025 19:23:06 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Naoto - correct comment regarding REIWA, add test case for IAE check w/ >> additional era via sys prop > > test/jdk/java/ut

Re: RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException [v2]

2025-02-26 Thread Naoto Sato
On Wed, 26 Feb 2025 18:26:15 GMT, Justin Lu wrote: >> Please review this PR which prevents an `AIOOBE` from leaking out when >> `java.util.Calendar.Builder` is used to build a Japanese calendar with an >> era value too large. >> >> Note that we don't check under `BEFORE_MEIJI`/0 as historicall

Re: RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException [v2]

2025-02-26 Thread Justin Lu
On Wed, 26 Feb 2025 17:20:47 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Naoto - correct comment regarding REIWA, add test case for IAE check w/ >> additional era via sys prop > > Looks good to me

Re: RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException [v2]

2025-02-26 Thread Justin Lu
> Please review this PR which prevents an `AIOOBE` from leaking out when > `java.util.Calendar.Builder` is used to build a Japanese calendar with an era > value too large. > > Note that we don't check under `BEFORE_MEIJI`/0 as historically Japanese > calendar ignores negative values during norm

Re: RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException

2025-02-26 Thread Naoto Sato
On Tue, 25 Feb 2025 23:58:21 GMT, Justin Lu wrote: > Please review this PR which prevents an `AIOOBE` from leaking out when > `java.util.Calendar.Builder` is used to build a Japanese calendar with an era > value too large. > > Note that we don't check under `BEFORE_MEIJI`/0 as historically Jap

Re: RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException

2025-02-25 Thread Chen Liang
On Tue, 25 Feb 2025 23:58:21 GMT, Justin Lu wrote: > Please review this PR which prevents an `AIOOBE` from leaking out when > `java.util.Calendar.Builder` is used to build a Japanese calendar with an era > value too large. > > Note that we don't check under `BEFORE_MEIJI`/0 as historically Jap

RFR: 8350646: Calendar.Builder.build() Throws ArrayIndexOutOfBoundsException

2025-02-25 Thread Justin Lu
Please review this PR which prevents an `AIOOBE` from leaking out when `java.util.Calendar.Builder` is used to build a Japanese calendar with an era value too large. Note that we don't check under `BEFORE_MEIJI`/0 as historically Japanese calendar ignores negative values during normalization. S