On Tue, 25 Feb 2025 23:58:21 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which prevents an `AIOOBE` from leaking out when > `java.util.Calendar.Builder` is used to build a Japanese calendar with an era > value too large. > > Note that we don't check under `BEFORE_MEIJI`/0 as historically Japanese > calendar ignores negative values during normalization. See > `JapaneseImperialCalendar` L2018: `date.setEra(era > 0 ? eras[era] : null);`. > > We also check against `eras.length` over `REIWA`/5 due to the possibility of > additional eras via the property override. (Which ensures > `SupplementalJapaneseEraTestRun.java` passes, which also tests against > building (and succeeding) with an era value of 6. This appears to be a behavioral change and warrants a CSR. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23789#issuecomment-2683573479
