On Tue, 8 Jul 2025 20:45:20 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [x] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not con
On Thu, 3 Jul 2025 01:44:27 GMT, simon wrote:
>> src/java.sql/share/classes/java/sql/Connection.java line 303:
>>
>>> 301:
>>> //==
>>> 302: // Advanced features:
>>> 303:
>>
>> Why was this removed as this is not for
On Mon, 23 Jun 2025 23:09:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Mon, 30 Jun 2025 16:49:44 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test-only change which addresses the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8359337?
>>
>> On macOS, the JDK by default (without any explicit system properties) picks
>> up the proxy setti
On Wed, 25 Jun 2025 10:20:15 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8359830?
>>
>> macOS operating system's newer version 26 (currently in Beta) is reported as
>> a 16 by older ver
On Mon, 9 Jun 2025 21:03:27 GMT, Brian Burkhalter wrote:
> Relax testing the inequality `usable_space <= free_space` to testing the
> inequality `usable_space <= total_space`.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25704#pullrequestr
On Mon, 23 Jun 2025 17:18:13 GMT, simon wrote:
>> 8360122: Refine formatting of Connection.java interface
>>
>> -
>> ### Progress
>> - [ ] Change must be properly reviewed (1 review required, with at least 1
>> [Reviewer](https://openjdk.org/bylaws#reviewer))
>> - [x] Change must not co
On Tue, 17 Jun 2025 21:47:49 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
On Fri, 13 Jun 2025 17:47:16 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
On Thu, 12 Jun 2025 18:05:04 GMT, Justin Lu wrote:
>> Please review this PR which finishes Applet removal for the test:
>> jdk/internal/loader/URLClassPath/ClassnameCharTest.java.
>>
>> `testclasses.jar` is updated such that the two classes no longer extend
>> Applet.
>>
>>
>> $ javap fo\ o.
On Wed, 4 Jun 2025 09:53:13 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8349914?
>
> The ZIP specification allows for more than one entry to have the same file
> name (and may have differ
On Wed, 4 Jun 2025 06:47:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial doc-only change to the
> `jdk.zipfs`'s documentation? This moves the `accessMode` property listing to
> the top of the table instead of being at the bottom. With this change, the
> text about throw
On Tue, 3 Jun 2025 06:35:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8358456?
>
> In Java 24, through https://bugs.openjdk.org/browse/JDK-8341597 we did a
> change which started using the "compr
On Tue, 27 May 2025 19:21:45 GMT, David Beaumont wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a l
On Wed, 28 May 2025 14:53:39 GMT, Henry Jen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
> Henry Jen has updated t
On Tue, 27 May 2025 16:23:47 GMT, Henry Jen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
> Henry Jen has updated t
On Wed, 21 May 2025 23:30:18 GMT, David Beaumont wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a l
On Sat, 17 May 2025 17:21:01 GMT, Nizar Benalla wrote:
> Please review this trivial patch to fix a javadoc bug.
>
> TIA
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25286#pullrequestreview-2864609961
On Thu, 22 May 2025 01:46:40 GMT, Lance Andersen wrote:
>> I use exit code, but still keep non-zero instead of > 0. Leave that to
>> future work if we want to have more specific value for exit code for
>> different situations.
>
> Non-zero could also mean negative w
On Thu, 22 May 2025 01:39:45 GMT, Henry Jen wrote:
>>> Nit - we should call it exit code instead of status code, both for 0 and
>>> non-zero exit codes.
>>
>> I don't have a preference but unix/MacOS commands vary:
>>
>> - ls command: The ls utility exits 0 on success, and >0 if an error occu
On Wed, 21 May 2025 10:43:12 GMT, David Beaumont wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a l
On Wed, 21 May 2025 16:42:14 GMT, Jaikiran Pai wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Mismatched order is considered invalid
>
> src/jdk.jartool/share/man/jar.md line 223:
>
>> 221: As a jar archive is based
On Wed, 21 May 2025 16:45:51 GMT, Jaikiran Pai wrote:
> Nit - we should call it exit code instead of status code, both for 0 and
> non-zero exit codes.
I don't have a preference but unix/MacOS commands vary:
- ls command: The ls utility exits 0 on success, and >0 if an error occurs.
- grep co
On Wed, 21 May 2025 12:58:37 GMT, Jaikiran Pai wrote:
>> Hello Lance/Henry,
>>
>>> Well, now would be a good time to consider say a value of 2 for duplicates,
>>> 3 for invalid names, etc...
>>
>> I think from a specification point of view, for this current PR, we should
>> only specify that
On Tue, 20 May 2025 18:14:15 GMT, Henry Jen wrote:
>>> I am wondering if we should not explicitly said status code of 1 to be more
>>> flexible. s/status code of 1/non-zero status code
>>
>> Well, now would be a good time to consider say a value of 2 for duplicates,
>> 3 for invalid names, etc
On Tue, 20 May 2025 16:55:44 GMT, Henry Jen wrote:
> I am wondering if we should not explicitly said status code of 1 to be more
> flexible. s/status code of 1/non-zero status code
Well, now would be a good time to consider say a value of 2 for duplicates, 3
for invalid names, etc...
On Sat, 17 May 2025 01:27:38 GMT, Henry Jen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
> Henry Jen has updated t
On Thu, 15 May 2025 21:57:17 GMT, Henry Jen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
> Henry Jen has updated t
On Fri, 16 May 2025 05:34:09 GMT, Alan Bateman wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on review feedback.
>
> src/jdk.zipfs/share/classes/module-info.java line 299:
>
>> 297: *
On Fri, 16 May 2025 14:30:38 GMT, Jaikiran Pai wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on review feedback.
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 230:
>
>> 22
On Mon, 12 May 2025 09:49:12 GMT, David Beaumont wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on review feedback.
>
> src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipFileSystem.java line 221:
>
>>
On Wed, 14 May 2025 16:39:54 GMT, Henry Jen wrote:
> UTF-8 messed up the index, we don't want any conversion to happen. Warning:
> Entry META-INFMAANIFEST.MF in local file header is not in central directory
> Warning: Entry META-INF/BANIFEST.MF in local file header is not in central
> director
On Mon, 12 May 2025 10:16:33 GMT, David Beaumont wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a l
On Mon, 12 May 2025 10:16:33 GMT, David Beaumont wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a l
On Mon, 12 May 2025 15:53:42 GMT, Roger Riggs wrote:
> The failure of the new StringBuilder HugeCapacity test testHugePlus is
> intermittent with some GC's.
> It could be reliably reproduced with the serialGC and parallelGC's.
>
> Raise the memory limit from 6G to 8G to accommodate the new test
On Thu, 8 May 2025 13:29:36 GMT, Alan Bateman wrote:
> > I'll run some experiments and see what it shows up.
>
> Thanks as that will help inform as to whether this will need a compatibility
> knob.
The crc is calculated as part of the write of the entry and I have not seen any
cases, where th
On Thu, 8 May 2025 12:08:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8354799?
>
> `java.util.zip.ZipInputStream` when dealing with a `STORED` entry of zero
> size was missing a CRC check for tha
On Wed, 7 May 2025 16:17:07 GMT, Joe Wang wrote:
> This is a refactor patch, no change in functionality.
>
> This patch refactor the configuration code. Rather than for each factory to
> go through the whole configuration process, a base configuration as
> represented in JdkXmlConfig is create
On Tue, 6 May 2025 18:21:30 GMT, Henry Jen wrote:
>> This PR check the jar file to ensure entries are consistent from the central
>> directory and local file header. Also check there is no duplicate entry
>> names that could override the desired content by accident.
>
> Henry Jen has updated th
On Wed, 30 Apr 2025 14:14:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Thu, 1 May 2025 01:15:26 GMT, Jaikiran Pai wrote:
> > I think throwing the SkippedException is the right way to go long term but
> > I assume this shows as a reported failure in Mach5 and in the case of
> > assumeTrue it does not result in a failure being reported?
>
> That is correct, use
On Wed, 30 Apr 2025 14:20:37 GMT, Jaikiran Pai wrote:
>> test/jdk/java/util/zip/ZipFile/ZipFileCharsetTest.java line 68:
>>
>>> 66: // ISO-8859-15 is not a standard charset in Java. We skip this
>>> test
>>> 67: // when it is unavailable
>>> 68:
>>> assumeTrue(Charset.a
On Wed, 30 Apr 2025 12:02:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to fix an issue
>> `java.util.zip.ZipFile` which would cause failures when multiple instances
>> of `ZipFile` using non-UTF8 `Charset` were operating against the same
>> underlying
On Wed, 30 Apr 2025 13:13:30 GMT, Roger Riggs wrote:
>> Improve StringBuilder getChar and putChar robustness with racy updates to
>> StringBuilder.
>> Test racing threads with append, insert, and reading characters.
>
> Roger Riggs has updated the pull request incrementally with one additional
On Mon, 28 Apr 2025 17:03:10 GMT, Roger Riggs wrote:
> There are lots of tests using @requires to only run on relevant
> configurations. If there needs to be more complete accounting of tests not
> run on each platform, it belongs as a feature in jtreg. Switching to use
> SkippedException in s
On Thu, 24 Apr 2025 20:46:42 GMT, Brian Burkhalter wrote:
> Use the `@requires` tag instead of obtaining the operating system name from
> the `os.name` property and then exiting if the test is not run on that
> operating system.
Marked as reviewed by lancea (Reviewer).
-
PR Revie
On Mon, 21 Apr 2025 16:19:30 GMT, Joe Wang wrote:
>> Fix a NPE on calling DocumentBuilderFactory::getAttribute, refer to the bug
>> report.
>>
>> Also in this patch: consolidates get and set properties to use the same Util
>> methods to reduce potential errors when code changes.
>>
>> Test:
>
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjdk.org/browse/
On Thu, 3 Apr 2025 12:55:11 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this doc-only change which proposes to improve
>> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`,
>> `InflaterInputStream` and `InflaterOutputStream` classes?
>>
>> As noted in https://
On Mon, 31 Mar 2025 17:42:20 GMT, Joe Wang wrote:
> Refactor XMLSecurityPropertyManager.
> The Xerces and Xalan components each had its own XMLSecurityManager and
> XMLSecurityPropertyManager. In a previous fix, the former had been unified as
> part of that changeset. This change will allow fut
On Fri, 4 Apr 2025 16:12:56 GMT, Lance Andersen wrote:
>> As we checking entry uniqueness and the size match, and all LOC entries
>> should be in CEN, that would means all CEN entries in LOC.
>> But if we would like to be specific about the inconsistency, then we will
>
On Fri, 4 Apr 2025 16:01:40 GMT, Henry Jen wrote:
>> src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties line
>> 147:
>>
>>> 145: in incompatible public interfaces
>>> 146: warn.validator.duplicate.entry=\
>>> 147: Warning: More than one copy of {0} is detected
On Fri, 4 Apr 2025 16:06:07 GMT, Henry Jen wrote:
>> Is the ordering required by ZIP or Jar format? We can certainly do that if
>> that's under spec and not an implementation detail.
>
> As we checking entry uniqueness and the size match, and all LOC entries
> should be in CEN, that would mean
On Fri, 4 Apr 2025 00:39:04 GMT, Henry Jen wrote:
> This PR check the jar file to ensure entries are consistent from the central
> directory and local file header. Also check there is no duplicate entry names
> that could override the desired content by accident.
Thank you for starting the wor
On Mon, 31 Mar 2025 19:18:58 GMT, Joe Wang wrote:
>> LGTM. Technically it is still March in PDT though
>
>> LGTM. Technically it is still March in PDT though
>
> Thanks. It is, tricky. Thought by the time it's out, it would be April.
@JoeWang-Java,
Can you confirm which Mach5 tiers have run wi
On Sun, 23 Mar 2025 12:38:04 GMT, Jason Zaugg wrote:
> 8352642: Set zipinfo-time=false when constructing zipfs FileSystem in
> com.sun.tools.javac.file.JavacFileManager$ArchiveContainer for better
> performance
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.ope
On Fri, 14 Mar 2025 18:35:22 GMT, Joe Wang wrote:
>> Add public identifiers to the JDK built-in Catalog; Replace the incorrect
>> Schema 1.1 DTD files (note the Public Identifier at line 2) with the correct
>> Shema 1.0 DTDs.
>
> Joe Wang has updated the pull request incrementally with one addi
On Mon, 10 Mar 2025 18:06:43 GMT, Roger Riggs wrote:
> Remove misleading/invalid diagnostic output from the JAR manifest test
> ValueUtf8Coding.java.
>
> The Manifest binary stream is not a well formed UTF-8 string due to the
> inserted continuation characters used for lines longer than 70 cha
On Mon, 3 Mar 2025 11:59:36 GMT, Eirik Bjørsnøs wrote:
> > Given the inputs from Alan, Eirik and Lance, I have now updated this PR
> > [...]
>
> > Does this look better?
>
> I like the structure this is shaping into, with the affected constructors
> linking into a note. I like that the note e
On Mon, 24 Feb 2025 05:50:40 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which proposes to address
> an intermittent failure in the
> `test/jdk/java/util/zip/ZipFile/TestCleaner.java` test?
>
> This test does operations on Inflater/Deflater/ZipFile and closes
On Wed, 19 Feb 2025 00:16:13 GMT, Joe Wang wrote:
>> Fix an edge case in the patch for JDK-8207760.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> add tests verifying invalid sequence; also add tests to verify cases where
> t
On Fri, 14 Feb 2025 19:09:53 GMT, Joe Wang wrote:
>> Fix an edge case in the patch for JDK-8207760.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> un-needed property removed
Marked as reviewed by lancea (Reviewer).
-
On Fri, 14 Feb 2025 00:56:03 GMT, Joe Wang wrote:
> Fix an edge case in the patch for JDK-8207760.
Marked as reviewed by lancea (Reviewer).
test/jaxp/javax/xml/jaxp/unittest/transform/JDK8207760.java line 125:
> 123: Transformer t = createTransformerFromInputstream(
> 124:
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote:
> This change adds an API note to these methods recommending that the caller
> should perform further validation steps on the code signers that signed the
> JAR file, such as validating the code signer's certificate chain, and
> determining
On Fri, 14 Feb 2025 07:41:26 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to properly close the
> `Inflater` instance used in
> `jdk.internal.jimage.decompressor.ZipDecompressor.decompress()` method? This
> addresses https://bugs.openjdk.org/browse/JDK-834
On Wed, 12 Feb 2025 15:45:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change in
>> `jdk.tools.jlink.internal.plugins.ZipPlugin` which proposes to close the
>> `Deflater` instance cleanly? This addresses
>> https://bugs.openjdk.org/browse/JDK-8349907.
>>
>> As noted in tha
On Fri, 7 Feb 2025 20:03:21 GMT, Joe Wang wrote:
> Fix an error handling where the XMLStreamReader impl throws EOFException
> instead of XMLStreamException as defined.
Looks OK Joe
I might suggest an RN to give a heads up on the change of Exception to match he
spec
-
Marked as r
On Thu, 6 Feb 2025 20:19:53 GMT, Joe Wang wrote:
>> Fix an issue where the translet-name is incorrectly set when the
>> package-name is also specified.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update test
Marked as rev
On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang wrote:
> Fix an issue where the translet-name is incorrectly set when the package-name
> is also specified.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/23446#pullrequestreview-2599444141
On Fri, 19 Jul 2024 15:16:01 GMT, Lance Andersen wrote:
>>> I understand the request here, but is there a current use case for needing
>>> a custom Deflater?
>>
>> I think the primary use case is when you want to set a non-default
>> compression level, e.g.
On Thu, 23 Jan 2025 00:46:07 GMT, Joe Wang wrote:
>> Fix broken links in java.xml:
>>
>> Catalog: contacted Oasis. The standard page
>> (https://www.oasis-open.org/standard/xmlcatalogs/) now links to the PDF
>> version. That is what I'm using now, replacing the html pages. Not ideal,
>> but a
On Tue, 14 Jan 2025 09:23:35 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> prop
On Thu, 9 Jan 2025 00:27:15 GMT, Brian Burkhalter wrote:
> Change the test as done in #22957 for
> [JDK-8346671](https://bugs.openjdk.org/browse/JDK-8346671).
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22994#pullrequestreview-2540788054
On Wed, 8 Jan 2025 06:01:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Tue, 7 Jan 2025 10:45:09 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this enhancement which proposes to enhance
>> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>>
>> The actual work for this was done a few years back when we discussed the
>> propo
On Sun, 29 Dec 2024 14:51:06 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which improves the
> `test/jdk/java/util/zip/EntryCount64k.java` test code to allow for it to pass
> when the JVM logs any warning when launching an application through `java
> -jar ...`?
On Fri, 20 Dec 2024 14:15:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8302293?
>>
>> As noted in the issue, when creating a temporary file during the "jar
>> --create" operation, if the
On Thu, 19 Dec 2024 00:36:44 GMT, Brian Burkhalter wrote:
> Update the specification of `java.io.File.exists()` to match its behavior,
> which seems correct in the context of how the empty abstract pathname is
> documented elsewhere in the class.
Marked as reviewed by lancea (Reviewer).
Marke
On Wed, 18 Dec 2024 14:58:26 GMT, Roger Riggs wrote:
> Continuing SM removal cleanup of tests for test/jdk/java/beans and
> test/jdk/java/io/Serializable.
> Removing doPrivileged, Permissions, and SecurityException.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://gi
ly do not suggest that we should define any kind of default for
this option. This should be entirely up to the user.
Feedback on this proposal is welcome. (I have a draft implementation around,
but let's focus on the merits of the proposal before we dive into any code)
Eirik.
[oracle_sig_
On Mon, 16 Dec 2024 20:33:38 GMT, Naoto Sato wrote:
> A very minor test fix.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22773#pullrequestreview-2507320144
On Mon, 16 Dec 2024 15:15:25 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address the issue
>> reported in https://bugs.openjdk.org/browse/JDK-8345506?
>>
>> The `jar` tool has several operations which take `--file` as a parameter.
>> The value for tha
On Sun, 15 Dec 2024 17:48:06 GMT, Lance Andersen wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [ab1dbd40](https://github.com/openjdk/jdk/commit/ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repositor
Hi all,
This pull request contains a backport of commit
[ab1dbd40](https://github.com/openjdk/jdk/commit/ab1dbd4089a1a15bdf1b6b39994d5b1faacc40ab)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Lance Andersen on 15 Dec 2024
On Fri, 13 Dec 2024 16:54:05 GMT, Lance Andersen wrote:
> Please review this trivial PR which removes `(See below)` which was missed
> during the SQLPermission update as part of the updates for [JEP 486:
> Permanently Disable the Security Manager](https://openjdk.org/jeps/486)
&g
On Fri, 13 Dec 2024 20:21:49 GMT, Sean Mullan wrote:
> Can you add a `jep486` label to the bug? Otherwise, looks good.
Done, thank you Sean
-
PR Comment: https://git.openjdk.org/jdk/pull/22739#issuecomment-2542244627
Please review this trivial PR which removes `(See below)` which was missed
during the SQLPermission update as part of the updates for [JEP 486:
Permanently Disable the Security Manager](https://openjdk.org/jeps/486)
I have confirmed there are no issues with the build via a macht tier1 run
---
On Tue, 10 Dec 2024 15:31:08 GMT, Roger Riggs wrote:
> Backport this trivial fix to parsing of the system property
> "resource.bundle.debug" to jdk24.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/22664#pullrequestreview-2500333810
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 17:22:14 GMT, Roger Riggs wrote:
> Replace broken getProperty with Boolean.getBoolean.
>
> Manual testing confirms trace messages are enabled with
> `-Dresource.bundle.debug=true`
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk
On Fri, 6 Dec 2024 19:24:51 GMT, Brent Christian wrote:
>> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call
>> through `ReflectUtil.forName()`. When
>> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`,
>> it is doing so from `java.base`, and so u
On Fri, 6 Dec 2024 17:38:22 GMT, Brent Christian wrote:
>> `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call
>> through `ReflectUtil.forName()`. When
>> `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`,
>> it is doing so from `java.base`, and so u
On Wed, 4 Dec 2024 15:46:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to address
>> https://bugs.openjdk.org/browse/JDK-8341551?
>>
>> The primary work in this PR is the specification of the previously existing
>> `sun.misc.URLClassPath.disableJarChec
On Tue, 3 Dec 2024 02:22:15 GMT, Joe Wang wrote:
> Add test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
Looks OK. As this is a new test, I would have preferred this to be a junit
test, but lets get this back given where we are for 24 and can address
afterwards
-
Ma
On Tue, 3 Dec 2024 01:04:30 GMT, Joe Wang wrote:
> Disables XSLT and XPath Extension Functions by default, setting
> jdk.xml.enableExtensionFunctions to false.
>
> Adjusted tests accordingly.
Overall Looks good Joe
please see the comment below
test/jaxp/javax/xml/jaxp/unittest/transform/XSLT
On Mon, 2 Dec 2024 20:12:39 GMT, Roger Riggs wrote:
> Remove sun/security/action/GetPropertyAction.java and all uses.
>
> Dependent on PR#22418
Changes Look Good Roger
-
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22497#pullrequestreview-2
On Mon, 2 Dec 2024 20:13:55 GMT, Joe Wang wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> value unnecessary for the ternary expression
Marked
On Mon, 2 Dec 2024 04:19:08 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in the javadoc of
> `javax.sql.rowset.BaseRowSet#setBigDecimal()` method?
>
> As noted in https://bugs.openjdk.org/browse/JDK-8345279, the javadoc
> incorrectly mentions `java.lang.BigDeci
On Sat, 30 Nov 2024 19:47:15 GMT, Joe Wang wrote:
>> Add DTDs and XSDs from the W3C specifications to the JDK built-in Catalog.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> list files vertically
Changes look good Joe
than
On Tue, 26 Nov 2024 18:14:22 GMT, Joe Wang wrote:
>> Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
>>
>> Tests:
>> Updated the config test with the new settings.
>>
>> Removed obsolete tests Bug6309988.java and
>> Bug4674384_MAX_OCCURS_Test.java, and files used by
1 - 100 of 815 matches
Mail list logo
