On Mon, 23 Jun 2025 23:09:13 GMT, simon <d...@openjdk.org> wrote: >> 8360122: Refine formatting of Connection.java interface >> >> --------- >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> >> >> >> ### Reviewing >> <details><summary>Using <code>git</code></summary> >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jdk.git pull/25925/head:pull/25925` \ >> `$ git checkout pull/25925` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/25925` \ >> `$ git pull https://git.openjdk.org/jdk.git pull/25925/head` >> >> </details> >> <details><summary>Using Skara CLI tools</summary> >> >> Checkout this PR locally: \ >> `$ git pr checkout 25925` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 25925` >> >> </details> >> <details><summary>Using diff file</summary> >> >> Download this PR as a diff file: \ >> <a >> href="https://git.openjdk.org/jdk/pull/25925.diff";>https://git.openjdk.org/jdk/pull/25925.diff</a> >> >> </details> >> <details><summary>Using Webrev</summary> >> >> [Link to Webrev >> Comment](https://git.openjdk.org/jdk/pull/25925#issuecomment-2993856738) >> </details> > > simon has updated the pull request incrementally with one additional commit > since the last revision: > > 8360122: revert reformatting method signatures
Some initial comments. There are some lines in the methods that were modified that need to wrap around 80 characters, but it would be best to leave as is and can be done as part of the updates that will be coming shorty src/java.sql/share/classes/java/sql/Connection.java line 303: > 301: > //====================================================================== > 302: // Advanced features: > 303: Why was this removed as this is not format related src/java.sql/share/classes/java/sql/Connection.java line 1175: > 1173: */ > 1174: void setClientInfo(String name, String value) > 1175: throws SQLClientInfoException; The throws clause could be moved up src/java.sql/share/classes/java/sql/Connection.java line 1208: > 1206: */ > 1207: void setClientInfo(Properties properties) > 1208: throws SQLClientInfoException; The throws clause could be moved up src/java.sql/share/classes/java/sql/Connection.java line 1232: > 1230: * @see java.sql.DatabaseMetaData#getClientInfoProperties > 1231: */ > 1232: String getClientInfo(String name) the throws clause could be moved up src/java.sql/share/classes/java/sql/Connection.java line 1251: > 1249: */ > 1250: Properties getClientInfo() > 1251: throws SQLException; The throws clause could be moved up ------------- Changes requested by lancea (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25925#pullrequestreview-2979431612 PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2180233608 PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2180324024 PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2180322060 PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2180318581 PR Review Comment: https://git.openjdk.org/jdk/pull/25925#discussion_r2180317869
