On Tue, 8 Jul 2025 14:04:56 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](http
On Wed, 2 Jul 2025 07:47:31 GMT, Daniel Jeliński wrote:
>> src/java.base/share/classes/sun/security/ssl/X509Authentication.java line
>> 224:
>>
>>> 222: // TODO in future, when QuicTLSEngine might become a
>>> public exported interface
>
On Fri, 27 Jun 2025 13:21:12 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java wit
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Thu, 26 Jun 2025 17:34:45 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java wit
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Fri, 27 Jun 2025 09:49:44 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java wit
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Thu, 26 Jun 2025 17:43:21 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java wit
On Thu, 26 Jun 2025 16:36:40 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](htt
On Mon, 28 Apr 2025 18:52:10 GMT, Sean Mullan wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 409 commits:
>>
>> - merge latest changes from master branch
>> - http3: add missing separator to Http3Discove
On Fri, 25 Apr 2025 19:42:34 GMT, Artur Barashev wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 409 commits:
>>
>> - merge latest changes from master branch
>> - http3: add missing separator to Http3Disc
On Tue, 22 Apr 2025 16:49:10 GMT, Artur Barashev wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java w
On Tue, 22 Apr 2025 16:21:30 GMT, Artur Barashev wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java w
On Thu, 26 Jun 2025 16:57:53 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java wit
On Mon, 28 Apr 2025 18:56:31 GMT, Sean Mullan wrote:
>> Sounds good, this was just FYI.
>
> I may be wrong, but it seems you only re-enable 3DES to test a non-TLS 1.3
> cipher suite. But you don't have to use a 3DES suite to do that, you could
> use one of the suites that are already enabled (a
On Tue, 10 Jun 2025 22:55:31 GMT, Artur Barashev wrote:
>> src/java.base/share/classes/sun/security/ssl/CertificateMessage.java line
>> 1221:
>>
>>> 1219: tm.checkClientTrusted(
>>> 1220: certs.clone(),
>>> 1221:
On Wed, 7 May 2025 08:30:28 GMT, Per Minborg wrote:
>> This PR proposes to skip a stress test if the `main` thread is a virtual
>> thread.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Cleanup merges
LGTM.
-
On Wed, 7 May 2025 07:52:22 GMT, Per Minborg wrote:
> This PR proposes to skip a stress test if the `main` thread is a virtual
> thread.
test/jdk/java/foreign/TestBufferStackStress2.java line 69:
> 67: // this stress test will not work as the main thread is always
> alive causing
> 68
On Tue, 8 Apr 2025 13:59:11 GMT, Per Minborg wrote:
> This PR proposes to increase the timeout values for two tests.
Marked as reviewed by djelinski (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24511#pullrequestreview-2752626632
On Fri, 14 Mar 2025 18:31:38 GMT, Roger Riggs wrote:
> Cleanup the single use of JavaLangAccess.exit() it is no longer necessary;
> System.exit() can be called directly.
Marked as reviewed by djelinski (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/24066#pullrequestrevi
On Mon, 3 Feb 2025 19:13:10 GMT, Brent Christian wrote:
>> 3 finalizers in RMI code can be removed, as they do not perform meaningful
>> cleanup.
>>
>> **`jdk.naming.rmi/share/classes/com/sun/jndi/rmi/registry/RegistryContext`**
>>
>> `RegistryContext.finalize()` just calls `close()`. The `clo
On Fri, 17 Jan 2025 20:27:54 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Remove v
On Fri, 17 Jan 2025 20:00:16 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Remove W
On Fri, 17 Jan 2025 17:09:51 GMT, Brian Burkhalter wrote:
>> No, it wouldn't cover any future Windows versions, but it would definitely
>> buy us a few years.
>>
>> Regarding a more permanent solution: the test is supposed to verify the fix
>> for [JDK-8013827](https://bugs.openjdk.org/browse/
On Fri, 17 Jan 2025 16:46:58 GMT, Brian Burkhalter wrote:
>> test/jdk/java/io/File/createTempFile/SpecialTempFile.java line 95:
>>
>>> 93:
>>> 94: String cmd = "Systeminfo";
>>> 95: Process p = Runtime.getRuntime().exec(new String[] {cmd});
>>
>> I'm not a big fan of running th
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which adds the `final` modifier to non-subclassable
> classes in `java.base`.
>
> The classes were identified using an automated analysis. See CSR for details.
>
> Besides simply adding the `final` access modifier,
On Wed, 15 Jan 2025 21:26:49 GMT, Brian Burkhalter wrote:
>> Fix the means of determining whether an exception is to be expected in the
>> Windows test.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8347740: Change W
On Thu, 19 Dec 2024 03:33:43 GMT, Valerie Peng wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> be precise in method spec
>
> test/lib/jdk/test/lib/Asserts.java line 256:
>
>> 254: * @see #assertNotEqualsByteAr
On Tue, 17 Dec 2024 15:07:26 GMT, Weijun Wang wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to f
On Mon, 16 Dec 2024 22:32:39 GMT, Valerie Peng wrote:
>> `Asserts.assertNotEquals` shows "expected 12345 to not equal 12345" which
>> sounds redundant, just say "expected not equals but was 12345".
>>
>> `Asserts.assertEqualsByteArray` uses the words "expected... to equal...".
>> Modify it to
On Tue, 17 Dec 2024 00:48:58 GMT, Weijun Wang wrote:
>> test/lib/jdk/test/lib/Asserts.java line 272:
>>
>>> 270: msg = Objects.toString(msg, "assertEqualsByteArray")
>>> 271: + ": expected " + HexFormat.of().formatHex(lhs)
>>> 272: + " but was
On Mon, 30 Sep 2024 16:11:14 GMT, sbgoog wrote:
>> FIleSystemPreferences.lockFile() catches an InterruptedException and just
>> returns false, forgetting to re-interrupt the current thread. This leaves
>> the caller with no way to observe that the thread was interrupted. This
>> change restore
On Mon, 30 Sep 2024 14:31:51 GMT, sbgoog wrote:
>> FIleSystemPreferences.lockFile() catches an InterruptedException and just
>> returns false, forgetting to re-interrupt the current thread. This leaves
>> the caller with no way to observe that the thread was interrupted. This
>> change restore
On Mon, 30 Sep 2024 13:07:42 GMT, sbgoog wrote:
>> src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line
>> 961:
>>
>>> 959: } catch(InterruptedException e) {
>>> 960: checkLockFile0ErrorCode(errorCode);
>>> 961: // Don't lose th
On Tue, 10 Sep 2024 16:37:11 GMT, sbgoog wrote:
> FIleSystemPreferences.lockFile() catches an InterruptedException and just
> returns false, forgetting to re-interrupt the current thread. This leaves the
> caller with no way to observe that the thread was interrupted. This change
> restores th
On Mon, 16 Sep 2024 19:09:03 GMT, Brian Burkhalter wrote:
>> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and
>> `isHidden` behave when the `File` represents a symbolic link.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit si
On Fri, 13 Sep 2024 20:41:27 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
On Fri, 13 Sep 2024 02:47:18 GMT, Joe Darcy wrote:
> Candidates for this refactoring were found programmatically; the program to
> find candidates is in a comment on the bug.
Marked as reviewed by djelinski (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20981#pullreques
On Thu, 12 Sep 2024 02:10:00 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
On Tue, 10 Sep 2024 19:58:45 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/sun/nio/ch/IOUtil.java line 575:
>>
>>> 573: * Used to trigger loading of native libraries
>>> 574: */
>>> 575: public static void load() { }
>>
>> do we still need this method?
>
> Yes, it st
On Wed, 11 Sep 2024 16:33:28 GMT, Brian Burkhalter wrote:
>> Right. This PR moves FileDispatcherImpl.c to libjava, so
>> FileDispatcherImpl.obj is no longer there. I'm guessing that our makefiles
>> don't detect source files that were removed, and Brian didn't run `make
>> clean`.
>
> From a c
On Tue, 10 Sep 2024 21:42:08 GMT, Magnus Ihse Bursie wrote:
>> well I'm not satisfied with the answers :) I removed mswsock.lib from libnio
>> dependencies
>> [here](https://github.com/openjdk/jdk/blob/f57b6f13e9f375bfd2e8a05afd2b900a4d42285e/make/modules/java.base/Lib.gmk#L89)
>> and the buil
On Tue, 10 Sep 2024 13:30:05 GMT, Magnus Ihse Bursie wrote:
>> make/modules/java.base/lib/CoreLibraries.gmk line 71:
>>
>>> 69: -framework Foundation \
>>> 70: -framework SystemConfiguration, \
>>> 71: LIBS_windows := advapi32.lib mswsock.lib ole32.lib shell32.lib
>>> versio
On Fri, 9 Aug 2024 17:59:12 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request inc
On Mon, 9 Sep 2024 22:29:23 GMT, Aleksei Efimov wrote:
>> This PR proposes the following changes to address wrong timeout computations
>> in the `com.sun.jndi.dns.DnsClient`:
>> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
>> clock. The existing `Timeout` test ha
On Mon, 9 Sep 2024 19:22:19 GMT, Brian Burkhalter wrote:
>> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and
>> `isHidden` behave when the `File` represents a symbolic link.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit sin
On Fri, 6 Sep 2024 17:47:35 GMT, Brian Burkhalter wrote:
>> Make explicit how the `java.io.File` methods `isDirectory`, `isFile`, and
>> `isHidden` behave when the `File` represents a symbolic link.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit sin
On Mon, 9 Sep 2024 11:42:25 GMT, Aleksei Efimov wrote:
>> This PR proposes the following changes to address wrong timeout computations
>> in the `com.sun.jndi.dns.DnsClient`:
>> - The `DnsClient` has been updated to use a monotonic high-resolution (nano)
>> clock. The existing `Timeout` test ha
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 19 Jul 2024 14:20:48 GMT, Nizar Benalla wrote:
>> Can I get a review for this change that fixes some broken links in javadoc
>> comments? The new docs are hosted
>> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>>
>> It's mostly fixing some relative li
On Fri, 19 Jul 2024 13:11:05 GMT, Chen Liang wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove docroot based on review
>
> src/java.base/share/classes/java/lang/foreign/Arena.java line 64:
>
>> 62: * such,
On Fri, 19 Jul 2024 11:11:38 GMT, Nizar Benalla wrote:
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
On Fri, 19 Jul 2024 11:11:38 GMT, Nizar Benalla wrote:
> Can I get a review for this change that fixes some broken links in javadoc
> comments? The new docs are hosted
> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/).
>
> It's mostly fixing some relative links.
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Sun, 23 Jun 2024 19:03:38 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
On Sun, 23 Jun 2024 10:33:08 GMT, fabioromano1 wrote:
>> Which program are you referring to?
>>
>> It is the responsibility of the caller of `subtract` to ensure that the
>> arguments are normalized. This may or may not require calling `normalize`,
>> depending on whether the argument is norma
On Sun, 23 Jun 2024 09:53:48 GMT, fabioromano1 wrote:
>>> why the documentation does not specify that the method assumes the
>>> arguments are normalized?
>>
>> Well, the best answer I can offer is "because no one documented it yet".
>> `MutableBigInteger` is an internal class, so most people
On Sun, 23 Jun 2024 08:55:17 GMT, fabioromano1 wrote:
> why the documentation does not specify that the method assumes the arguments
> are normalized?
Well, the best answer I can offer is "because no one documented it yet".
`MutableBigInteger` is an internal class, so most people never see its
On Sat, 22 Jun 2024 21:12:36 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
On Tue, 18 Jun 2024 15:34:16 GMT, fabioromano1 wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused import
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 293:
>
>> 291: */
>>
On Tue, 11 Jun 2024 17:39:29 GMT, Vladimir Kozlov wrote:
>> There is no other use.. That array is there for the sole purpose of holding
>> the input as a long array before it gets xor-ed into the state.
>
> okay
Could you try using MethodHandles instead of b2lLittle? Similar to what's used
in
On Mon, 10 Jun 2024 15:01:55 GMT, Ferenc Rakoczi wrote:
> This PR removes some unnecessary conversions between byte arrays and long
> arrays during SHA3 digest computations.
src/java.base/share/classes/sun/security/provider/SHA3.java line 70:
> 68: private long[] state = new long[DM*DM];
>
On Thu, 6 Jun 2024 18:40:51 GMT, Daniel Jeliński wrote:
> `GetExitCodeProcess` method is not reliable for checking if a process exited
> already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but
> the same value is returned when the process exited with code 25
On Mon, 10 Jun 2024 13:48:08 GMT, Roger Riggs wrote:
>> I don't have a test or counter example and don't have a detailed
>> understanding of the blocking needs of Hotspot.
>
> Another reason to retain the checking of GetThreadInterruptEvent is to be
> belt and suspenders against the Java code c
ot sure the problem is
> important enough to justify an extra JNI call in the (probably typical)
> still-alive case.
>
> Tier1-3 testing clean. I modified the existing OnExitTest to cover this case.
Daniel Jeliński has updated the pull request incrementally with one additional
comm
On Fri, 7 Jun 2024 20:36:45 GMT, Roger Riggs wrote:
>> I only left it here because the wait for interrupt event was already
>> present. Is being stuck in a blocking os call a bad thing? If not, I can
>> drop the interrupt event, and wait on the process handle only.
>
> I think waiting on JVM_Ge
On Fri, 7 Jun 2024 20:35:00 GMT, Roger Riggs wrote:
>> I don't follow. Could you explain?
>
> The `WaitForSingleObject(handle, 0)` seems like an indirect way to determine
> if the process is alive.
> Whereas `isProcessAlive(handle)` seems to directly answer the question.
sorry, I still don't ge
On Fri, 7 Jun 2024 14:58:30 GMT, Roger Riggs wrote:
>> `GetExitCodeProcess` method is not reliable for checking if a process exited
>> already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but
>> the same value is returned when the process exited with code 259. In order
>> t
`GetExitCodeProcess` method is not reliable for checking if a process exited
already; it returns 259 (STILL_ACTIVE) if the process hasn't exited yet, but
the same value is returned when the process exited with code 259. In order to
check if the process exited, we need to check if its handle is i
On Sun, 26 May 2024 07:24:16 GMT, SendaoYan wrote:
>> Hi all,
>> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
>> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
>> this testcase run failed. So I make change from `throw new SkippedExce
On Sun, 26 May 2024 07:24:16 GMT, SendaoYan wrote:
>> Hi all,
>> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
>> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
>> this testcase run failed. So I make change from `throw new SkippedExce
On Fri, 24 May 2024 18:37:13 GMT, Vladimir Kozlov wrote:
>> Changed to `lea` with `InternalAddress()`. Generates the exact same code,
>> but makes more sense. I looked at `movdqu` and see no code that generates
>> RIP-relative loads. It merely checks `reachable()` and adds an intermediate
>
On Sun, 26 May 2024 02:58:02 GMT, SendaoYan wrote:
> Hi all,
> When there is no `/usr/bin/expect` in system, `throw new SkippedException`
> will not make the jvm exit in `@BeforeAll` junit stage, thus this will cause
> this testcase run failed. So I make change from `throw new SkippedExceptio
On Fri, 24 May 2024 14:19:13 GMT, Scott Gibbons wrote:
>> the RIP-relative lea should have a shorter encoding. I think something like
>> `lea(r15, ExternalAddress(small_jump_table))` should produce it (untested)
>
> Just did the experiment and it turns out that `mov64(r15,
> (int64_t)small_jump
On Thu, 23 May 2024 19:26:10 GMT, Scott Gibbons wrote:
>> src/hotspot/cpu/x86/stubGenerator_x86_64_string.cpp line 268:
>>
>>> 266: __ cmpq(needle_len_p, 0);
>>> 267: __ jg_b(L_nextCheck);
>>> 268: __ xorq(rax, rax);
>>
>> out of curiosity, is there any advantage to using `xorq` instead o
On Thu, 23 May 2024 17:25:34 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Wed, 8 May 2024 08:19:54 GMT, Daniel Jeliński wrote:
> Replace the custom unsigned divide / remainder functions with the
> compiler-optimized Long.divideUnsigned / remainderUnsigned.
>
> No new tests. Existing tier1-3 tests continue to pass.
>
> I added a new set of
On Fri, 10 May 2024 16:16:18 GMT, Daniel Jeliński wrote:
>> Replace the custom unsigned divide / remainder functions with the
>> compiler-optimized Long.divideUnsigned / remainderUnsigned.
>>
>> No new tests. Existing tier1-3 tests continue to pass.
>>
the BigDecimal.toString benchmarks. They no longer serve their
> purpose - toString caches the returned value, so we were only benchmarking
> the cache access time.
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision:
Integer
the BigDecimal.toString benchmarks. They no longer serve their
> purpose - toString caches the returned value, so we were only benchmarking
> the cache access time.
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision
On Fri, 10 May 2024 13:39:42 GMT, Daniel Jeliński wrote:
>> Replace the custom unsigned divide / remainder functions with the
>> compiler-optimized Long.divideUnsigned / remainderUnsigned.
>>
>> No new tests. Existing tier1-3 tests continue to pass.
>>
the BigDecimal.toString benchmarks. They no longer serve their
> purpose - toString caches the returned value, so we were only benchmarking
> the cache access time.
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision:
On Wed, 8 May 2024 08:19:54 GMT, Daniel Jeliński wrote:
> Replace the custom unsigned divide / remainder functions with the
> compiler-optimized Long.divideUnsigned / remainderUnsigned.
>
> No new tests. Existing tier1-3 tests continue to pass.
>
> I added a new set of
Replace the custom unsigned divide / remainder functions with the
compiler-optimized Long.divideUnsigned / remainderUnsigned.
No new tests. Existing tier1-3 tests continue to pass.
I added a new set of divide benchmarks. Results in thread.
I also removed the BigDecimal.toString benchmarks. They
On Mon, 22 Jan 2024 18:52:32 GMT, fabioromano1 wrote:
>> As you note, that would probably require two divisions. I don't know if the
>> JIT compiler can detect that the arguments are the same and emit just one
>> division instead.
>> I think your code is good enough for the purpose of [Mutable]
On Tue, 27 Feb 2024 11:19:59 GMT, Magnus Ihse Bursie wrote:
>> The idea of setting up general "toolchains" in the native build was good,
>> but it turned out that we really only need a single toolchain, with a single
>> twist: if it should use CC or CPP to link. This is better described by a
>
On Mon, 26 Feb 2024 20:21:55 GMT, Magnus Ihse Bursie wrote:
>> The idea of setting up general "toolchains" in the native build was good,
>> but it turned out that we really only need a single toolchain, with a single
>> twist: if it should use CC or CPP to link. This is better described by a
>
On Tue, 27 Feb 2024 03:11:37 GMT, Jiangli Zhou wrote:
> Please help review this trivial change. This was branched from
> https://github.com/openjdk/jdk/pull/18013, based on discussion with
> @plummercj in https://github.com/openjdk/jdk/pull/18013 comments. Thanks
LGTM
-
Marked as
On Thu, 22 Feb 2024 01:42:17 GMT, Brent Christian wrote:
>> Classes in the `java.lang.ref` package would benefit from an update to bring
>> the spec in line with how the VM already behaves. The changes would focus on
>> _happens-before_ edges at some key points during reference processing.
>>
On Thu, 22 Feb 2024 12:04:05 GMT, Daniel Jeliński wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Cleaner thread dequeue happens-before running cleaning action
>
> src/java.ba
On Fri, 24 Nov 2023 07:58:18 GMT, Daniel Jeliński wrote:
> The recent cdb versions do not support `.dump /f`:
>
> *
> * .dump /f is not supported on a user
On Fri, 24 Nov 2023 09:58:17 GMT, Daniel Jeliński wrote:
>> The recent cdb versions do not support `.dump /f`:
>>
>> *
>> * .dump /f is not supporte
On Fri, 24 Nov 2023 11:36:27 GMT, Alan Bateman wrote:
>> It's ignoring the rest of the command line after `/f`, which means it
>> ignores the `;qd` (quit and detach) part and enters the interactive mode.
>
>> It's ignoring the rest of the command line after `/f`, which means it
>> ignores the `
On Fri, 24 Nov 2023 10:28:30 GMT, Alan Bateman wrote:
>> good point, 10 minutes should be more than enough. I'll update.
>
> Out of curiosity, do we know why it takes more than an hour? Is it attempting
> to connect to the Microsoft symbol server?
It's ignoring the rest of the command line afte
On Fri, 24 Nov 2023 09:09:03 GMT, Alan Bateman wrote:
>> Daniel Jeliński has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review comments
>
> test/failure_handler/src/share/conf/windows.proper
This PR updates the dump command to use the recommended `/ma` parameter. This
> allows the command to produce a dump and complete in a timely manner.
Daniel Jeliński has updated the pull request incrementally with one additional
commit since the last revision:
Address review comments
1 - 100 of 194 matches
Mail list logo
