On Tue, 24 Jun 2025 08:08:58 GMT, Andrey Turbanov wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8358533: Init StringBuilder to size zero; use StringBuilder.isEmpty()
>
> test/micro/org/openjdk/bench/java/io/R
On Mon, 23 Jun 2025 21:23:05 GMT, Stuart Marks wrote:
>> src/java.base/share/classes/java/io/Reader.java line 508:
>>
>>> 506: }
>>> 507:
>>> 508: return lines;
>>
>> Do we really want to return a mutable `ArrayList` here? In earlier
>> discussions about this very API I was to
On Tue, 24 Jun 2025 13:25:20 GMT, Anton Artemov wrote:
>> This PR contains changes for the 1st phase of the `LockingMode` flag
>> obsoletion.
>>
>> The work is done by @fbredber, I have taken it over and am finishing it
>> while he's on vacation.
>>
>> In the 1st phase one keeps the `Lockin
> In BufferedReader.readLine and other similar scenarios, we need to use
> StringBuilder.append(char[]) to build the string.
>
> For these scenarios, we can Unsafe.copyMemory instead of the character copy
> of the char-by-char loop to improve the speed.
>
> @RogerRiggs completed the optimizatio
On Mon, 23 Jun 2025 22:48:52 GMT, Chen Liang wrote:
> sun.invoke.empty.Empty and java.lang.invoke.InvokeDynamic are useless
> remnants - Empty can be replaced by java.lang.Void, and InvokeDynamic was
> previously used as a stub for javac to compile signature polymorphic methods.
> They should
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Mon, 26 May 2025 19:20:06 GMT, Shaojin Wen wrote:
>> Through JVM Option +PrintInlining, we found that String has a constructor
>> codeSize of 852, which is too large. This caused failed to inline.
>>
>> The following is the output information of PrintInlining:
>>
>> @ 9 ja
On Tue, 24 Jun 2025 11:16:21 GMT, Anton Artemov wrote:
>> This PR contains changes for the 1st phase of the `LockingMode` flag
>> obsoletion.
>>
>> The work is done by @fbredber, I have taken it over and am finishing it
>> while he's on vacation.
>>
>> In the 1st phase one keeps the `Lockin
> With the recent approval of UUIDv7
> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new static
> method UUID.timestampUUID() which constructs and returns a UUID in support of
> the new time generated UUID version.
>
> The specification requires embedding the current times
> In BufferedReader.readLine and other similar scenarios, we need to use
> StringBuilder.append(char[]) to build the string.
>
> For these scenarios, we can Unsafe.copyMemory instead of the character copy
> of the char-by-char loop to improve the speed.
>
> @RogerRiggs completed the optimizatio
On Mon, 23 Jun 2025 22:48:52 GMT, Chen Liang wrote:
> sun.invoke.empty.Empty and java.lang.invoke.InvokeDynamic are useless
> remnants - Empty can be replaced by java.lang.Void, and InvokeDynamic was
> previously used as a stub for javac to compile signature polymorphic methods.
> They should
Currently, the list of classes that have interdependencies and those
that need runtimeSetup are maintained in a hardcoded list in CDS. This makes it
risky for core library developers as they might introduce new interdependencies
and observe CDS to fail. By moving the mechanism of these lists to
On Mon, 9 Jun 2025 21:03:27 GMT, Brian Burkhalter wrote:
> Relax testing the inequality `usable_space <= free_space` to testing the
> inequality `usable_space <= total_space`.
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25704#pullrequestr
On Tue, 24 Jun 2025 14:59:18 GMT, Weijun Wang wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update to german translations
>
> src/java.base/share/classes/sun/security/util/resources/security_zh_CN.properties
> l
On Sat, 21 Jun 2025 00:03:26 GMT, Chen Liang wrote:
> Currently, the list of classes that have interdependencies and those
> that need runtimeSetup are maintained in a hardcoded list in CDS. This makes
> it risky for core library developers as they might introduce new
> interdependencies and
> Through JVM Option +PrintInlining, we found that String has a constructor
> codeSize of 852, which is too large. This caused failed to inline.
>
> The following is the output information of PrintInlining:
>
> @ 9 java.lang.String:: (12 bytes) inline (hot)
> !m
On Mon, 9 Jun 2025 21:03:27 GMT, Brian Burkhalter wrote:
> Relax testing the inequality `usable_space <= free_space` to testing the
> inequality `usable_space <= total_space`.
This pull request has now been integrated.
Changeset: 50910576
Author:Brian Burkhalter
URL:
https://git.op
On Mon, 26 May 2025 19:20:06 GMT, Shaojin Wen wrote:
>> Through JVM Option +PrintInlining, we found that String has a constructor
>> codeSize of 852, which is too large. This caused failed to inline.
>>
>> The following is the output information of PrintInlining:
>>
>> @ 9 ja
Currently, fake parameters are created with "arg0" etc. strings that are
retained for class file methods with no MethodParameters attribute. The
original issue report observes many of these strings present in the heap. To
address this issue, we can remove these eagerly created fake names, bringi
On Tue, 24 Jun 2025 18:10:45 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version
On Tue, 24 Jun 2025 19:12:25 GMT, Roger Riggs wrote:
> One possibility is to copy the remaining fragment of a line to a new transfer
> buffer (maybe twice the size).
It's probably worth testing this.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25863#discussion_r216472586
On Mon, 26 May 2025 19:20:06 GMT, Shaojin Wen wrote:
>> Through JVM Option +PrintInlining, we found that String has a constructor
>> codeSize of 852, which is too large. This caused failed to inline.
>>
>> The following is the output information of PrintInlining:
>>
>> @ 9 ja
On Mon, 9 Jun 2025 21:03:27 GMT, Brian Burkhalter wrote:
> Relax testing the inequality `usable_space <= free_space` to testing the
> inequality `usable_space <= total_space`.
Seems like a reasonable re-calibration of the available info.
-
Marked as reviewed by rriggs (Reviewer).
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK since the previous L10n drop.
Alisen Chung has updated the pull request incrementally with three additional
commits since the last revision:
- Update
src/jdk.compiler/share/classes/com/s
On Sun, 8 Jun 2025 16:15:40 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version.
On Tue, 24 Jun 2025 18:46:49 GMT, Brian Burkhalter wrote:
>> The `readAllLines` method has a specification of line terminators that
>> agrees with that of `BufferedReader::readLine` and `String::lines` and so we
>> don't want to change it to be different.
>>
>> Unfortunately `Scanner` doesn't
On Tue, 24 Jun 2025 19:00:42 GMT, Brian Burkhalter wrote:
>>> My suggestion is to call `new StringBuilder(0)`
>>
>> So changed in 8ccfd54.
>
>> When a partial line is left in the transfer buffer, copy it to the beginning
>> of the buffer and read more characters for the remaining size of the bu
On Wed, 18 Jun 2025 00:05:17 GMT, Brian Burkhalter wrote:
> The throughput of the implementation [...].
The performance comments made
[here](https://github.com/openjdk/jdk/pull/25863#issuecomment-2982169343) still
apply to the most recent commit.
-
PR Comment: https://git.openjdk
On Thu, 19 Jun 2025 10:59:14 GMT, Markus KARG wrote:
> Is there a reason for `sb.length() == 0` instead of `sb.isEmpty()`?
The former is identical. Modified to use `isEmpty` in 8ccfd54.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/25863#discussion_r2164686620
On Wed, 18 Jun 2025 02:12:50 GMT, Shaojin Wen wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8358533: Init StringBuilder to size zero; use StringBuilder.isEmpty()
>
> src/java.base/share/classes/java/io/Reader
On Wed, 18 Jun 2025 02:25:03 GMT, Chen Liang wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8358533: Init StringBuilder to size zero; use StringBuilder.isEmpty()
>
> src/java.base/share/classes/java/io/Reader.
On Mon, 23 Jun 2025 21:16:30 GMT, Stuart Marks wrote:
>> `Scanner` seems to scan for even more characters:
>> https://github.com/openjdk/jdk/blob/c4fb00a7be51c7a05a29d3d57d787feb5c698ddf/src/java.base/share/classes/java/util/Scanner.java#L490
>>
>> Would it make sense to resemble this? Would it
On Mon, 23 Jun 2025 22:48:52 GMT, Chen Liang wrote:
> sun.invoke.empty.Empty and java.lang.invoke.InvokeDynamic are useless
> remnants - Empty can be replaced by java.lang.Void, and InvokeDynamic was
> previously used as a stub for javac to compile signature polymorphic methods.
> They should
On Tue, 24 Jun 2025 18:29:38 GMT, ExE Boss wrote:
>> sun.invoke.empty.Empty and java.lang.invoke.InvokeDynamic are useless
>> remnants - Empty can be replaced by java.lang.Void, and InvokeDynamic was
>> previously used as a stub for javac to compile signature polymorphic
>> methods. They shoul
> Replaces the implementation `readAllCharsAsString().lines().toList()` with
> reading into a temporary `char` array which is then processed to detect line
> terminators and copy non-terminating characters into strings which are added
> to the list.
Brian Burkhalter has updated the pull request
On Sun, 8 Jun 2025 16:15:40 GMT, Kieran Farrell wrote:
>> With the recent approval of UUIDv7
>> (https://datatracker.ietf.org/doc/rfc9562/), this PR aims to add a new
>> static method UUID.timestampUUID() which constructs and returns a UUID in
>> support of the new time generated UUID version.
On Tue, 24 Jun 2025 11:16:21 GMT, Anton Artemov wrote:
>> This PR contains changes for the 1st phase of the `LockingMode` flag
>> obsoletion.
>>
>> The work is done by @fbredber, I have taken it over and am finishing it
>> while he's on vacation.
>>
>> In the 1st phase one keeps the `Lockin
On Tue, 17 Jun 2025 15:22:24 GMT, Nizar Benalla wrote:
> Once https://bugs.openjdk.org/browse/JDK-8358769 is resolved,
> JavaBaseCheckSince no longer needs to be problemlisted.
Marked as reviewed by liach (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/25855#pullrequestr
> This collects miscellaneous open issues that can be resolved with
> documentation updates; each indicated by adding JDK issue numbers
Doug Lea has updated the pull request incrementally with one additional commit
since the last revision:
Add JDK-8311131
-
Changes:
- all: htt
On Tue, 24 Jun 2025 14:42:57 GMT, Brian Burkhalter wrote:
>> Replaces the implementation `readAllCharsAsString().lines().toList()` with
>> reading into a temporary `char` array which is then processed to detect line
>> terminators and copy non-terminating characters into strings which are added
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Tue, 24 Jun 2025 14:54:17 GMT, Weijun Wang wrote:
>> Thank you for the clarification.
>
> However, there is no space required between two Chinese sentences. In
> English, we usually write "I am here, and you are there." But in Chinese,
> with the full-width punctuation, it's always "我在这里，你在那
On Wed, 18 Jun 2025 00:04:37 GMT, Brian Burkhalter wrote:
> Replaces the implementation `readAllCharsAsString().lines().toList()` with
> reading into a temporary `char` array which is then processed to detect line
> terminators and copy non-terminating characters into strings which are added
>
On Mon, 16 Jun 2025 16:36:43 GMT, Gautham Krishnan
wrote:
> Some methods in the java.time.chrono interfaces—ChronoLocalDate,
> ChronoLocalDateTime, and ChronoZonedDateTime—override methods from the
> java.time.temporal.Temporal interface that are documented to throw
> UnsupportedTemporalTypeE
On Wed, 18 Jun 2025 16:43:02 GMT, Alexey Ivanov wrote:
>> There is still only one space, the new one is a full width colon (U+FF1A).
>> Localization rules have been observed to make the switch from regular colons
>> (U+003A) into the full width version depending on the language.
>
> Thank you f
> Replaces the implementation `readAllCharsAsString().lines().toList()` with
> reading into a temporary `char` array which is then processed to detect line
> terminators and copy non-terminating characters into strings which are added
> to the list.
Brian Burkhalter has updated the pull request
> This collects miscellaneous open issues that can be resolved with
> documentation updates; each indicated by adding JDK issue numbers
Doug Lea has updated the pull request incrementally with 20 additional commits
since the last revision:
- Merge remote-tracking branch 'refs/remotes/origin/JD
> This collects miscellaneous open issues that can be resolved with
> documentation updates; each indicated by adding JDK issue numbers
Doug Lea has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
th
On Sun, 22 Jun 2025 12:54:29 GMT, Doug Lea wrote:
>> This collects miscellaneous open issues that can be resolved with
>> documentation updates; each indicated by adding JDK issue numbers
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremen
On Tue, 24 Jun 2025 13:48:02 GMT, Paul Hohensee wrote:
> Please review a jstat test-only fix.
>
> 1. Ensure that jstat tests that run more than one sub-test per test file
> check the result of each sub-test before continuing.
> 2. Allow '-' as a valid jstat -gcutil heap space percent occupancy
jstat test-only fix.
1. Ensure that jstat tests that run more than one sub-test per test file check
the result of each sub-test before continuing.
2. Allow '-' as a valid jstat -gcutil heap space percent occupancy field value,
see lineCounts[1-4].awk. Occupancy is computed as ((capacity - used)
On Tue, 24 Jun 2025 12:43:36 GMT, Alan Bateman wrote:
>> Anton Artemov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8359437: Addressed reviewer's comments
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest/StopThreadTe
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode` variable in all places, but
> makes it non-settable from
On Tue, 24 Jun 2025 13:10:41 GMT, Jaikiran Pai wrote:
> I've been experimenting with using these Objective-C APIs in this C++ code
> of hotspot, but have been running into build issues. I am currently
> discussing those with people familiar with this area and plan to continue
> pursuing it fu
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode` variable in all places, but
> makes it non-settable from
On Mon, 23 Jun 2025 16:44:23 GMT, Alisen Chung wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK since the previous L10n drop.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the las
On Tue, 24 Jun 2025 03:09:06 GMT, David Holmes wrote:
>> Anton Artemov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8359437: Addressed reviewers' comments
>> - 8359437: Addressed reviewers' comments
>
> test/jtreg-ext/requires/VMPr
On Tue, 24 Jun 2025 09:14:37 GMT, David Holmes wrote:
>> Anton Artemov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8359437: Addressed reviewers' comments
>> - 8359437: Addressed reviewers' comments
>
> test/hotspot/jtreg/runtime/M
On Mon, 23 Jun 2025 21:21:44 GMT, ExE Boss wrote:
> Note that as mentioned in the bug discussion, the same also occurs when doing
> `new StringTokenizer("some string", (String) null)`.
Right, and it's super weird, but seems to have been specified since JDK 5 to
defer the NPE to later. I don't
On Tue, 24 Jun 2025 09:59:50 GMT, Anton Artemov wrote:
>> This PR contains changes for the 1st phase of the `LockingMode` flag
>> obsoletion.
>>
>> The work is done by @fbredber, I have taken it over and am finishing it
>> while he's on vacation.
>>
>> In the 1st phase one keeps the `Lockin
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode` variable in all places, but
> makes it non-settable from
On Mon, 23 Jun 2025 17:04:37 GMT, Leonid Mesnik wrote:
>> Anton Artemov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8359437: Addressed reviewers' comments
>> - 8359437: Addressed reviewers' comments
>
> test/hotspot/jtreg/gtest/Lo
On Mon, 23 Jun 2025 15:48:41 GMT, Alan Bateman wrote:
>> Anton Artemov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8359437: Addressed reviewers' comments
>> - 8359437: Addressed reviewers' comments
>
> test/jdk/java/lang/Thread/vi
On Tue, 17 Jun 2025 08:39:49 GMT, Anton Artemov wrote:
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode`
> This PR contains changes for the 1st phase of the `LockingMode` flag
> obsoletion.
>
> The work is done by @fbredber, I have taken it over and am finishing it while
> he's on vacation.
>
> In the 1st phase one keeps the `LockingMode` variable in all places, but
> makes it non-settable from
On Wed, 18 Jun 2025 00:04:37 GMT, Brian Burkhalter wrote:
> Replaces the implementation `readAllCharsAsString().lines().toList()` with
> reading into a temporary `char` array which is then processed to detect line
> terminators and copy non-terminating characters into strings which are added
>
66 matches
Mail list logo
