Re: RFR: 8345335: Add excluded jdk_foreign tests to manual group

2024-12-05 Thread Alan Bateman
On Thu, 5 Dec 2024 22:21:45 GMT, Mark Sheppard wrote: >> @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore >> @JornVernee >> >> adding as manual tests > > test/jdk/TEST.groups line 625: > >> 623: javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataUtil.java \ >> 62

Re: RFR: 8341184: Clean up the interaction between the launcher native code and the LauncherHelper [v12]

2024-12-05 Thread Jaikiran Pai
> Can I please get a review of this change, which simplifies the interaction > between the `java` launcher's native code with the > `sun.launcher.LauncherHelper`? > > As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change > reduces the back and forth between the launcher

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Adam Sotona
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler

2024-12-05 Thread Alan Bateman
On Thu, 5 Dec 2024 21:41:28 GMT, Brent Christian wrote: > `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call > through `ReflectUtil.forName()`. When > `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, > it is doing so from `java.base`, and so using

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v4]

2024-12-05 Thread Taizo Kurashige
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use > Cygwin’s `df` to get the size for comparison if the test target drive is a > CD-ROM drive. > > As described in JDK-8343342, GetDiskSpaceInformationW can't get information > about the size of the CD-ROM drive. > Ge

Re: RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v3]

2024-12-05 Thread Taizo Kurashige
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use > Cygwin’s `df` to get the size for comparison if the test target drive is a > CD-ROM drive. > > As described in JDK-8343342, GetDiskSpaceInformationW can't get information > about the size of the CD-ROM drive. > Ge

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Fri, 6 Dec 2024 00:30:03 GMT, Justin Lu wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties >> line 190: >> >>> 188: javac.opt.Xdoclint.package.args = [-]<程序包>(,[-]<程序包>)* >>> 189: >>> 190: javac.opt.Xdoclint.package.desc=在特定的程序包中启用或禁用检查。每个 >>> 是\

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Fri, 6 Dec 2024 00:24:27 GMT, Damon Nguyen wrote: > Looks generally fine overall. But, looking at the URL for the differences in > each file per language, I see changes for > `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher`. I > don't see any changes for this file in

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Justin Lu
On Fri, 6 Dec 2024 00:21:34 GMT, Damon Nguyen wrote: >> Please review this PR which contains the open L10n drop changes for RDP1. >> >> I recommend viewing the improved diffs which are built out by Jon's tool >> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the >> co

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Justin Lu
On Fri, 6 Dec 2024 00:27:36 GMT, Damon Nguyen wrote: > > Looks generally fine overall. But, looking at the URL for the differences > > in each file per language, I see changes for > > `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/launcher`. I > > don't see any changes for this

Re: RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Damon Nguyen
On Thu, 5 Dec 2024 22:36:12 GMT, Justin Lu wrote: > Please review this PR which contains the open L10n drop changes for RDP1. > > I recommend viewing the improved diffs which are built out by Jon's tool > here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the > correctnes

Re: RFR: 8344168: Change Unsafe base offset from int to long [v4]

2024-12-05 Thread Shaojin Wen
On Tue, 26 Nov 2024 18:05:44 GMT, Shaojin Wen wrote: >> The type of the Unsafe base offset constant is int, which may cause overflow >> when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027) >> fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are >> st

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 23:24:56 GMT, Scott Marlow wrote: >> I made a quick test for this, but you might not want to include it if you >> aim to backport this improvement to LTS releases as it uses the >> recently-finalized ClassFile API. >> >> >> /* >> * Copyright (c) 2024, Oracle and/or its aff

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 23:24:56 GMT, Scott Marlow wrote: >> I made a quick test for this, but you might not want to include it if you >> aim to backport this improvement to LTS releases as it uses the >> recently-finalized ClassFile API. >> >> >> /* >> * Copyright (c) 2024, Oracle and/or its aff

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 23:18:59 GMT, Chen Liang wrote: > I made a quick test for this, but you might not want to include it if you aim > to backport this improvement to LTS releases as it uses the > recently-finalized ClassFile API. Excellent, I'm +1000 for adding your test, thank you very much fo

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

RFR: 8345327: JDK 24 RDP1 L10n resource files update

2024-12-05 Thread Justin Lu
Please review this PR which contains the open L10n drop changes for RDP1. I recommend viewing the improved diffs which are built out by Jon's tool here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the correctness on the quality of the translations themselves. Generally sp

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 22:26:31 GMT, Chen Liang wrote: >> test/langtools/tools/javac/annotations/parameter/ParameterAnnotations.java >> line 643: >> >>> 641: >>> 642: Task.Result result = new JavacTask(tb) >>> 643: .processors(new TestAP()) >> >> I assume this fix does not

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 21:54:19 GMT, Mandy Chung wrote: >> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> cleanup/cf-preview >> - 8334

Re: RFR: 8345335: Add excluded jdk_foreign tests to manual group

2024-12-05 Thread Mark Sheppard
On Thu, 5 Dec 2024 16:23:17 GMT, Ivan Šipka wrote: > @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore > @JornVernee > > adding as manual tests test/jdk/TEST.groups line 625: > 623: javax/xml/jaxp/datatype/8033980/GregorianCalAndDurSerDataUtil.java \ > 624: java/fo

Re: RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 21:41:28 GMT, Brent Christian wrote: > `XmlReaderContentHandler.endElement()` routes a `Class.forName()` call > through `ReflectUtil.forName()`. When > `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, > it is doing so from `java.base`, and so using

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 20:44:59 GMT, Chen Liang wrote: >> Remove the redundant `@enablePreview` and `--enable-preview` flags for >> enabling ClassFile API in the tests. The remainder of these flags in all >> tests seem to serve preview APIs (such as ScopedValue) or language features >> (primitive

RFR: 8344575: Examine usage of ReflectUtil.forName() in java.sql.rowset - XmlReaderContentHandler

2024-12-05 Thread Brent Christian
`XmlReaderContentHandler.endElement()` routes a `Class.forName()` call through `ReflectUtil.forName()`. When `sun.reflect.misc.ReflectUtil.forName()` calls the 1-arg `Class.forName()`, it is doing so from `java.base`, and so using the boot loader. Changing `XmlReaderContentHandler` to use the 3

Re: RFR: 8345335: Add excluded jdk_foreign tests to manual group

2024-12-05 Thread Alexandre Iline
On Thu, 5 Dec 2024 16:23:17 GMT, Ivan Šipka wrote: > @AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore > @JornVernee > > adding as manual tests LGTM - PR Comment: https://git.openjdk.org/jdk/pull/22580#issuecomment-2521377846

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-05 Thread Paul Sandoz
On Tue, 26 Nov 2024 18:15:47 GMT, Quan Anh Mai wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/AbstractVector.java >> line 228: >> >>> 226: } >>> 227: >>> 228: AbstractVector iota = vspecies().asIntegral().iota(); >> >> I suspect the non-power of two code

Re: RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

2024-12-05 Thread Paul Sandoz
On Tue, 26 Nov 2024 18:11:59 GMT, Quan Anh Mai wrote: >> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Int256Vector.java >> line 870: >> >>> 868: @Override >>> 869: public final Int256Shuffle rearrange(VectorShuffle >>> shuffle) { >>> 870: return (Int2

Re: RFR: 8315487: Security Providers Filter [v15]

2024-12-05 Thread Martin Balao
> In addition to the goals, scope, motivation, specification and requirement > notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we would > like to describe the most relevant decisions taken during the implementation > of this enhancement. These notes are organized by feature,

Re: RFR: 8334733: Remove obsolete @enablePreview from tests after JDK-8334714 [v2]

2024-12-05 Thread Chen Liang
> Remove the redundant `@enablePreview` and `--enable-preview` flags for > enabling ClassFile API in the tests. The remainder of these flags in all > tests seem to serve preview APIs (such as ScopedValue) or language features > (primitive pattern, module imports, etc.), or testing the enable pr

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v9]

2024-12-05 Thread Sergey Chernyshev
> Cgroup V1 subsustem fails to initialize mounted controllers properly in > certain cases, that may lead to controllers left undetected/inactive. We > observed the behavior in CloudFoundry deployments, it affects also host > systems. > > The relevant /proc/self/mountinfo line is > > > 2207 21

Re: RFR: 8333377: Migrate Generic Signature parsing to ClassFile API [v4]

2024-12-05 Thread Chen Liang
> Core reflection's generic signature parsing uses an ancient library with > outdated visitor pattern on a tree model and contains unnecessary > boilerplates. This is a duplication of ClassFile API's signature model. We > should just move to ClassFile API, which is more throughoutly tested as we

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 19:05:07 GMT, Scott Marlow wrote: >> Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you. > >> Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you. > > I'll force push once more to rename the commit to issue reference the ^ > issue. Th

Re: RFR: 8345614: Include container in "java.lang.annotation.AnnotationFormatError: Duplicate annotation for class" error

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Include container in "java.lang.annotation.AnnotationFormatError: Duplicate annotation for class" error

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 19:05:07 GMT, Scott Marlow wrote: >> Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you. > >> Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you. > > I'll force push once more to rename the commit to issue reference the ^ > issue. Th

Re: RFR: 8345614: Include container in "java.lang.annotation.AnnotationFormatError: Duplicate annotation for class" error

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

Re: RFR: 8345614: Include container in "java.lang.annotation.AnnotationFormatError: Duplicate annotation for class" error

2024-12-05 Thread Scott Marlow
On Thu, 5 Dec 2024 18:43:50 GMT, Chen Liang wrote: > Created a JBS issue https://bugs.openjdk.org/browse/JDK-8345614 for you. I'll force push once more to rename the commit to issue reference the ^ issue. Thank you @liach for creating that! > src/java.base/share/classes/sun/reflect/annotation

Re: RFR: 8345614: Include container in "java.lang.annotation.AnnotationFormatError: Duplicate annotation for class" error

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 16:24:29 GMT, Scott Marlow wrote: > I am getting the `Duplication annotation for class` error as mentioned in > https://hibernate.atlassian.net/browse/HHH-18901. The current error message > does not include the application class name (e.g. container) that the > specified an

RFR: 8345614: Include container in "java.lang.annotation.AnnotationFormatError: Duplicate annotation for class" error

2024-12-05 Thread Scott Marlow
I am getting the `Duplication annotation for class` error as mentioned in https://hibernate.atlassian.net/browse/HHH-18901. The current error message does not include the application class name (e.g. container) that the specified annotation is unexpectedly duplicated. This pull request is for

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v11]

2024-12-05 Thread Brian Burkhalter
> This proposed change would move the native objects required for NIO file > interaction from the libnio native library to the libjava native library on > Linux, macOS, and Windows. Brian Burkhalter has updated the pull request with a new target base due to a merge or a rebase. The pull request

Re: RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v2]

2024-12-05 Thread Henry Jen
On Tue, 3 Dec 2024 22:43:17 GMT, Mandy Chung wrote: >> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix style > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java line 552: > >> 550:

Re: RFR: 8345465: Fix performance regression on x64 after JDK-8345120 [v3]

2024-12-05 Thread Jorn Vernee
On Thu, 5 Dec 2024 11:43:16 GMT, Per Minborg wrote: >> This PR proposes to fix a performance regression (on x64 platforms) for >> 32-bit strings introduced by >> [JDK-8345120](https://bugs.openjdk.org/browse/JDK-8345120). >> >> The PR also fixes a performance regression in the benchmarks cause

Re: RFR: 8342035: jlink plugins for setting java.vendor, java.vm.vendor and java.vendor.url [v5]

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 03:08:36 GMT, Henry Jen wrote: >> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor >> and java.vendor.url. >> >> The jlink plugin will change the value in java.lang.VersionProps, which will >> set those property values. The `java.vm.vendor` was init

Re: RFR: 8343251: Facelift for Type and AnnotatedType specifications [v7]

2024-12-05 Thread Chen Liang
> The Type and AnnotatedType hierarchies have been enigmatic to new users: > users have no clue how to categorize arbitrary type objects, when it is safe > to cast to more specific types, and the exact conditions for method contracts. > > A manifest is [JDK-8306039](https://bugs.openjdk.org/brow

Re: RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v2]

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 17:30:17 GMT, Henry Jen wrote: >> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java line >> 552: >> >>> 550: if (potentiallyGnuOption && param.length() >= >>> 2 && >>> 551: param.charAt(0) == '-' && param

Re: JEP 473: Proposal for new built-in gatherer `indexed`

2024-12-05 Thread Viktor Klang
Hi! I've been thinking a bit about it [the problem] and arrived somewhere along the lines of it not necessarily being worth adding a new type to represent an index and an element (or trying to repurpose something existing), as I think the ergonomics of providing a mapper BiFunction is better, s

Re: RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v2]

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 17:31:24 GMT, Henry Jen wrote: >> test/jdk/tools/jlink/TaskHelperTest.java line 115: >> >>> 113: { "--raw-arg-plugin", "--main-no-arg --list", >>> "--main-no-arg"}, >>> 114: { "--raw-arg-plugin", " --main-no-arg", "--main-no-arg" }, >>> 115: };

Re: RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v2]

2024-12-05 Thread Mandy Chung
On Thu, 5 Dec 2024 17:09:47 GMT, Henry Jen wrote: >> Improving option value handling to support passing argument value starts >> with "--". >> >> Before the fix, in following example, --add-modules will be considered as >> another option for JLink instead of argument value for --add-options. >

Re: JEP 473: Proposal for new built-in gatherer `indexed`

2024-12-05 Thread Olexandr Rotan
Hi. There has been a proposal from me (that Chen mentioned), approximately half a year ago. At the time I have insisted on creating stream sub interface, and even got a working prototype for sequential streams, but there have been such a huge complexity blowup in parallisation that I have just deci

Re: JEP 473: Proposal for new built-in gatherer `indexed`

2024-12-05 Thread Chen Liang
Hi Henrik, I recall there was a thread for EnumeratedStream (https://mail.openjdk.org/pipermail/core-libs-dev/2024-April/thread.html#121871) back in April; it calls for the same feature, to add a stage for indexing entries. This approach of using a gatherer is simple; its disadvantage is that wh

Re: RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided [v2]

2024-12-05 Thread Henry Jen
> Improving option value handling to support passing argument value starts with > "--". > > Before the fix, in following example, --add-modules will be considered as > another option for JLink instead of argument value for --add-options. > --add-options --add-modules=jdk.incubator.concurrent > -

Integrated: 8342979: Start of release updates for JDK 25

2024-12-05 Thread Pavel Rappo
On Tue, 29 Oct 2024 13:26:37 GMT, Pavel Rappo wrote: > Prepare for JDK 25. This pull request has now been integrated. Changeset: 5cc150c6 Author:Pavel Rappo URL: https://git.openjdk.org/jdk/commit/5cc150c63632c3ab8bf23d94f941d3b6db45d55c Stats: 6176 lines in 98 files changed: 61

JEP 473: Proposal for new built-in gatherer `indexed`

2024-12-05 Thread Henrik Wall
Hey folks, Not having access to the index of an element of a stream is often a reason to fall back to a traditional loop, at least for me. I'd love to have `Gatherers.indexed()` that looks something like this: public static Gatherer> indexed() { return Gatherer.ofSequential( () -

RFR: 8345335: Add excluded jdk_foreign tests to ATR job

2024-12-05 Thread Ivan Šipka
@AlanBateman @mahendrachhipa @bwhuang-us @serhiysachkov @mcimadamore @JornVernee adding as manual tests - Commit messages: - added TestMatrix and TestUpcallStress to non interactive manual tests Changes: https://git.openjdk.org/jdk/pull/22580/files Webrev: https://webrevs.openj

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 15:01:27 GMT, Alan Bateman wrote: >> src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.java >> line 138: >> >>> 136: assert genericDeclaration instanceof Class || >>> 137: genericDeclaration instanceof Method || >>> 13

Integrated: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util

2024-12-05 Thread Alan Bateman
On Thu, 5 Dec 2024 10:20:50 GMT, Alan Bateman wrote: > We hollowed out ReflectUtil as one of the early steps when removing the code > for running in the SecurityManager execution mode. Most of the usages have > now been removed so the empty (and unused) methods can be removed. FieldUtils > and

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Alan Bateman
On Thu, 5 Dec 2024 15:16:46 GMT, Chen Liang wrote: >> I had hoped to keep the change focused on the removal of the left over >> ReflectUtil.checkPackageAccess, the else throw AssertionError was a surprise >> to see. So yes, I agree it can be removed but I'd prefer not touch it now, >> future w

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Alan Bateman
On Thu, 5 Dec 2024 14:50:53 GMT, Chen Liang wrote: >> Alan Bateman has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright header end dates > > src/java.base/share/classes/sun/reflect/generics/reflectiveObjects/TypeVariableImpl.

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Chen Liang
On Thu, 5 Dec 2024 14:46:14 GMT, Alan Bateman wrote: >> We hollowed out ReflectUtil as one of the early steps when removing the code >> for running in the SecurityManager execution mode. Most of the usages have >> now been removed so the empty (and unused) methods can be removed. >> FieldUtils

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Roger Riggs
On Thu, 5 Dec 2024 14:46:14 GMT, Alan Bateman wrote: >> We hollowed out ReflectUtil as one of the early steps when removing the code >> for running in the SecurityManager execution mode. Most of the usages have >> now been removed so the empty (and unused) methods can be removed. >> FieldUtils

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Sean Mullan
On Thu, 5 Dec 2024 14:46:14 GMT, Alan Bateman wrote: >> We hollowed out ReflectUtil as one of the early steps when removing the code >> for running in the SecurityManager execution mode. Most of the usages have >> now been removed so the empty (and unused) methods can be removed. >> FieldUtils

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util [v2]

2024-12-05 Thread Alan Bateman
> We hollowed out ReflectUtil as one of the early steps when removing the code > for running in the SecurityManager execution mode. Most of the usages have > now been removed so the empty (and unused) methods can be removed. FieldUtils > and ConstructorUtils can be removed too. > > ObjectInputS

Re: RFR: 8345259: When linking from the run-time image ALL-MODULE-PATH is not accepted

2024-12-05 Thread Alan Bateman
On Tue, 3 Dec 2024 18:51:04 GMT, Severin Gehwolf wrote: > Abort the link with an appropriate error when ALL-MODULE-PATH is being used > and a link from the run-time image is used but no module path given > (--module-path arg missing). Just to double check, with the default build, then `jlink -

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util

2024-12-05 Thread Sean Mullan
On Thu, 5 Dec 2024 10:20:50 GMT, Alan Bateman wrote: > We hollowed out ReflectUtil as one of the early steps when removing the code > for running in the SecurityManager execution mode. Most of the usages have > now been removed so the empty (and unused) methods can be removed. FieldUtils > and

Re: RFR: 8329251: Print custom truststore/ keystore name [v13]

2024-12-05 Thread Alan Bateman
On Wed, 27 Nov 2024 14:39:31 GMT, Prasadrao Koppula wrote: >> Using SharedSecrets, I attempted to expose FileInputStream::path >> information. After implementing the fix, I validated the startup performance >> tests. Observed no consistent pattern of performance drops or gains, can >> disrega

Re: RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided

2024-12-05 Thread Alan Bateman
On Tue, 3 Dec 2024 19:59:56 GMT, Henry Jen wrote: > Improving option value handling to support passing argument value starts with > "--". > > Before the fix, in following example, --add-modules will be considered as > another option for JLink instead of argument value for --add-options. > --ad

Re: RFR: 8303884: jlink --add-options plugin does not allow GNU style options to be provided

2024-12-05 Thread Alan Bateman
On Tue, 3 Dec 2024 19:59:56 GMT, Henry Jen wrote: > Improving option value handling to support passing argument value starts with > "--". > > Before the fix, in following example, --add-modules will be considered as > another option for JLink instead of argument value for --add-options. > --ad

Re: RFR: 8341184: Clean up the interaction between the launcher native code and the LauncherHelper [v11]

2024-12-05 Thread Jaikiran Pai
> Can I please get a review of this change, which simplifies the interaction > between the `java` launcher's native code with the > `sun.launcher.LauncherHelper`? > > As noted in https://bugs.openjdk.org/browse/JDK-8341184, this proposed change > reduces the back and forth between the launcher

Integrated: 8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual

2024-12-05 Thread Doug Lea
On Wed, 4 Dec 2024 14:03:58 GMT, Doug Lea wrote: > Accommodate compensations when checking for missed signals; add a better test > for this. This pull request has now been integrated. Changeset: 92e9ac6d Author:Doug Lea URL: https://git.openjdk.org/jdk/commit/92e9ac6dc7302a14077244

Re: RFR: 8344611: Add missing classpath exception

2024-12-05 Thread Alan Bateman
On Wed, 20 Nov 2024 10:46:54 GMT, Sorna Sarathi wrote: > This PR adds missing Classpath exception in several files. > > JBS Issue: [JDK-8334611](https://bugs.openjdk.org/browse/JDK-8344611) If you want, you could separate the two areas so that you at least get the jlink source updated. --

Re: RFR: 8342035: jlink plugins for setting java.vendor, java.vm.vendor and java.vendor.url [v5]

2024-12-05 Thread Alan Bateman
On Thu, 5 Dec 2024 03:08:36 GMT, Henry Jen wrote: >> Add jlink plugins to allow branding change for java.vendor, java.vm.vendor >> and java.vendor.url. >> >> The jlink plugin will change the value in java.lang.VersionProps, which will >> set those property values. The `java.vm.vendor` was init

Re: RFR: 8345465: Fix performance regression on x64 after JDK-8345120 [v3]

2024-12-05 Thread Per Minborg
> This PR proposes to fix a performance regression (on x64 platforms) for > 32-bit strings introduced by > [JDK-8345120](https://bugs.openjdk.org/browse/JDK-8345120). > > The PR also fixes a performance regression in the benchmarks caused by using > the wrong type for `MemorySegment`. > > Regr

Re: RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util

2024-12-05 Thread Kevin Walls
On Thu, 5 Dec 2024 10:20:50 GMT, Alan Bateman wrote: > We hollowed out ReflectUtil as one of the early steps when removing the code > for running in the SecurityManager execution mode. Most of the usages have > now been removed so the empty (and unused) methods can be removed. FieldUtils > and

Re: RFR: 8341551: Revisit jdk.internal.loader.URLClassPath.JarLoader after JEP 486 [v5]

2024-12-05 Thread Jaikiran Pai
On Thu, 5 Dec 2024 04:38:04 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to address >> https://bugs.openjdk.org/browse/JDK-8341551? >> >> The primary work in this PR is the specification of the previously existing >> `sun.misc.URLClassPath.disableJarChec

Integrated: 8341551: Revisit jdk.internal.loader.URLClassPath.JarLoader after JEP 486

2024-12-05 Thread Jaikiran Pai
On Wed, 4 Dec 2024 14:23:40 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to address > https://bugs.openjdk.org/browse/JDK-8341551? > > The primary work in this PR is the specification of the previously existing > `sun.misc.URLClassPath.disableJarChecking`

RFR: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util

2024-12-05 Thread Alan Bateman
We hollowed out ReflectUtil as one of the early steps when removing the code for running in the SecurityManager execution mode. Most of the usages have now been removed so the empty (and unused) methods can be removed. FieldUtils and ConstructorUtils can be removed too. ObjectInputStream/Object

Re: RFR: 8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual [v3]

2024-12-05 Thread Alan Bateman
On Wed, 4 Dec 2024 19:24:20 GMT, Doug Lea wrote: >> Accommodate compensations when checking for missed signals; add a better >> test for this. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes bro

Integrated: 8344540: Remove superseded wildcard description from java manpage

2024-12-05 Thread Christian Stein
On Tue, 19 Nov 2024 11:12:01 GMT, Christian Stein wrote: > Please review this follow-up PR to improve `java`'s manpage section about > wildcards in argument files: the confusing sentence is now removed. > > This is a cleanup of commit > https://github.com/openjdk/jdk/commit/5cb0d438231383d491b

Re: RFR: 8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual [v3]

2024-12-05 Thread Viktor Klang
On Wed, 4 Dec 2024 19:24:20 GMT, Doug Lea wrote: >> Accommodate compensations when checking for missed signals; add a better >> test for this. > > Doug Lea has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes bro

Integrated: 8345403: Add more randomized tests to better cover FloatingDecimal parsing

2024-12-05 Thread Raffaello Giulietti
On Tue, 3 Dec 2024 18:49:43 GMT, Raffaello Giulietti wrote: > `jdk.internal.math.FloatingDecimal` parsing is mostly exercised on inputs > produced by `Float.toString` and `Double.toString`, but should be extended on > more random inputs. This pull request has now been integrated. Changeset:

Re: RFR: 8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual [v3]

2024-12-05 Thread Viktor Klang
On Wed, 4 Dec 2024 18:57:16 GMT, Doug Lea wrote: >> test/jdk/java/lang/Thread/virtual/Starvation.java line 1: >> >>> 1: /* @test >> >> Suggestion: >> >> /* >> * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. >> * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE H

Re: RFR: 8344540: Remove superseded wildcard description from java manpage [v5]

2024-12-05 Thread David Holmes
On Wed, 4 Dec 2024 10:04:17 GMT, Christian Stein wrote: >> Please review this follow-up PR to improve `java`'s manpage section about >> wildcards in argument files: the confusing sentence is now removed. >> >> This is a cleanup of commit >> https://github.com/openjdk/jdk/commit/5cb0d438231383d

Re: RFR: 8341551: Revisit jdk.internal.loader.URLClassPath.JarLoader after JEP 486 [v5]

2024-12-05 Thread Daniel Fuchs
On Thu, 5 Dec 2024 04:38:04 GMT, Jaikiran Pai wrote: >> Can I please get a review of this change which proposes to address >> https://bugs.openjdk.org/browse/JDK-8341551? >> >> The primary work in this PR is the specification of the previously existing >> `sun.misc.URLClassPath.disableJarChec