On Thu, 5 Dec 2024 17:30:17 GMT, Henry Jen <henry...@openjdk.org> wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java line
>> 552:
>>
>>> 550: if (potentiallyGnuOption && param.length() >=
>>> 2 &&
>>> 551: param.charAt(0) == '-' && param.charAt(1)
>>> == '-' &&
>>> 552: !param.contains(" ")) {
>>
>> Why it does not accept this case `--add-options
>> --add-modules=jdk.incubator.concurrent`?
>
> --style argument still could be a real jlink argument, better check would be
> to see if that's a valid jlink option rather than just "--".
> The other alternative would be like what proposed by @YaSuenag, simply take
> the next token as value.
I would expect the next token would be parsed as the value. I suggest to
explore that and see how complex it would be.
It seems awkward if the following are accepted:
--add-options "--add-modules jdk.incubator.concurrent"
--add-options=--add-modules=jdk.incubator.concurrent
but not this:
--add-options "--add-modules=jdk.incubator.concurrent"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22526#discussion_r1871824941
